Patch 8.2.5145

4 views
Skip to first unread message

Bram Moolenaar

unread,
Jun 21, 2022, 1:35:17 PM6/21/22
to vim...@googlegroups.com

Patch 8.2.5145
Problem: Exit test causes spurious valgrind reports.
Solution: Skip test. Add CheckNotValgrind.
Files: src/testdir/test_exit.vim, src/testdir/check.vim,
src/testdir/test_channel.vim


*** ../vim-8.2.5144/src/testdir/test_exit.vim 2022-02-23 12:23:04.501304722 +0000
--- src/testdir/test_exit.vim 2022-06-21 18:26:26.106700395 +0100
***************
*** 115,120 ****
--- 115,121 ----
CheckNotMSWindows
" The early exit causes memory not to be freed somehow
CheckNotAsan
+ CheckNotValgrind

call writefile([":au VimLeave * call writefile(['l = ' .. v:exiting], 'Xtestout')", ":tabnew", "q:"], 'Xscript', 'b')

*** ../vim-8.2.5144/src/testdir/check.vim 2022-04-04 15:46:37.602126829 +0100
--- src/testdir/check.vim 2022-06-21 18:29:32.934280823 +0100
***************
*** 217,222 ****
--- 217,230 ----
endif
endfunc

+ " Command to check for not running under valgrind
+ command CheckNotValgrind call CheckNotValgrind()
+ func CheckNotValgrind()
+ if RunningWithValgrind()
+ throw 'Skipped: does not work well with valgrind'
+ endif
+ endfunc
+
" Command to check for X11 based GUI
command CheckX11BasedGui call CheckX11BasedGui()
func CheckX11BasedGui()
*** ../vim-8.2.5144/src/testdir/test_channel.vim 2022-06-21 17:40:43.820707677 +0100
--- src/testdir/test_channel.vim 2022-06-21 18:30:21.278188124 +0100
***************
*** 1793,1801 ****

func Test_job_stop_immediately()
" With valgrind this causes spurious leak reports
! if RunningWithValgrind()
! return
! endif

let g:job = job_start([s:python, '-c', 'import time;time.sleep(10)'])
try
--- 1793,1799 ----

func Test_job_stop_immediately()
" With valgrind this causes spurious leak reports
! CheckNotValgrind

let g:job = job_start([s:python, '-c', 'import time;time.sleep(10)'])
try
*** ../vim-8.2.5144/src/version.c 2022-06-21 18:10:35.919881737 +0100
--- src/version.c 2022-06-21 18:27:24.038558597 +0100
***************
*** 736,737 ****
--- 736,739 ----
{ /* Add new patch number below this line */
+ /**/
+ 5145,
/**/

--
Lower life forms have more fun!

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages