Patch 8.2.3715

6 views
Skip to first unread message

Bram Moolenaar

unread,
Dec 1, 2021, 7:42:01 AM12/1/21
to vim...@googlegroups.com

Patch 8.2.3715
Problem: Vim9: valgrind reports spurious problems for a test.
Solution: Move the test to the set that is known to fail.
Files: src/testdir/test_vim9_builtin.vim, src/testdir/test_vim9_fails.vim


*** ../vim-8.2.3714/src/testdir/test_vim9_builtin.vim 2021-11-22 15:37:11.752625328 +0000
--- src/testdir/test_vim9_builtin.vim 2021-12-01 12:37:25.131952631 +0000
***************
*** 1879,1895 ****
endif
enddef

! def Test_job_info_return_type()
! if !has('job')
! CheckFeature job
! else
! job_start(&shell)
! var jobs = job_info()
! assert_equal('list<job>', typename(jobs))
! assert_equal('dict<any>', typename(job_info(jobs[0])))
! job_stop(jobs[0])
! endif
! enddef

def Test_job_setoptions()
if !has('job')
--- 1879,1885 ----
endif
enddef

! " Test_job_info_return_type() is in test_vim9_fails.vim

def Test_job_setoptions()
if !has('job')
*** ../vim-8.2.3714/src/testdir/test_vim9_fails.vim 2020-10-12 19:31:11.291727542 +0100
--- src/testdir/test_vim9_fails.vim 2021-12-01 12:37:00.619968528 +0000
***************
*** 8,10 ****
--- 8,24 ----
var job2: job = job_start('willfail')
endif
enddef
+
+ " Unclear why this test causes valgrind to report problems.
+ def Test_job_info_return_type()
+ if !has('job')
+ CheckFeature job
+ else
+ var job: job = job_start(&shell)
+ var jobs = job_info()
+ assert_equal('list<job>', typename(jobs))
+ assert_equal('dict<any>', typename(job_info(jobs[0])))
+ job_stop(job)
+ endif
+ enddef
+
*** ../vim-8.2.3714/src/version.c 2021-12-01 11:24:46.784558743 +0000
--- src/version.c 2021-12-01 12:40:07.967835223 +0000
***************
*** 755,756 ****
--- 755,758 ----
{ /* Add new patch number below this line */
+ /**/
+ 3715,
/**/

--
OLD WOMAN: Well, how did you become king, then?
ARTHUR: The Lady of the Lake, her arm clad in the purest shimmering samite,
held Excalibur aloft from the bosom of the water to signify by Divine
Providence ... that I, Arthur, was to carry Excalibur ... That is
why I am your king!
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages