[vim/vim] Don't map gx and Q in select mode (#8471)

16 views
Skip to first unread message

zeertzjq

unread,
Jun 27, 2021, 9:55:01 PM6/27/21
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/8471

Commit Summary

  • netrw: don't map gx in select mode
  • defaults.vim: don't map Q in select mode

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

zeertzjq

unread,
Jun 27, 2021, 10:13:04 PM6/27/21
to vim/vim, Push

@zeertzjq pushed 2 commits.

  • 932b79f netrw: don't map gx in select mode
  • eecb259 defaults.vim: don't map Q in select mode


You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

codecov[bot]

unread,
Jun 28, 2021, 7:24:13 AM6/28/21
to vim/vim, Subscribed

Codecov Report

Merging #8471 (eecb259) into master (ffec6dd) will decrease coverage by 87.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@

##           master    #8471       +/-   ##

===========================================

- Coverage   90.02%    2.50%   -87.53%     

===========================================

  Files         149      147        -2     

  Lines      167875   162674     -5201     

===========================================

- Hits       151130     4068   -147062     

- Misses      16745   158606   +141861     
Flag Coverage Δ
huge-clang-none ?
huge-gcc-none ?
huge-gcc-testgui ?
huge-gcc-unittests 2.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/float.c 0.00% <0.00%> (-98.91%) ⬇️
src/digraph.c 0.00% <0.00%> (-97.78%) ⬇️
src/gui_gtk_f.c 0.00% <0.00%> (-97.54%) ⬇️
src/match.c 0.00% <0.00%> (-97.13%) ⬇️
src/crypt_zip.c 0.00% <0.00%> (-97.06%) ⬇️
src/sha256.c 0.00% <0.00%> (-96.94%) ⬇️
src/evalbuffer.c 0.00% <0.00%> (-96.83%) ⬇️
src/cmdhist.c 0.00% <0.00%> (-96.63%) ⬇️
src/debugger.c 0.00% <0.00%> (-96.62%) ⬇️
src/libvterm/src/rect.h 0.00% <0.00%> (-96.56%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffec6dd...eecb259. Read the comment docs.

zeertzjq

unread,
Aug 10, 2021, 12:25:45 AM8/10/21
to vim/vim, Subscribed

Closed #8471.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

cecamp

unread,
Aug 12, 2021, 3:40:06 PM8/12/21
to vim/vim, Subscribed

If you'd like for me to include changes to netrw.vim in the distribution, please send me the changes (diff file, the complete thing, etc).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Bram Moolenaar

unread,
Aug 13, 2021, 9:53:34 AM8/13/21
to vim...@googlegroups.com, cecamp

Charles Campbell wrote:

> If you'd like for me to include changes to netrw.vim in the
> distribution, please send me the changes (diff file, the complete
> thing, etc).

You can get the diff from a pull request by appending .diff to the
number:
https://github.com/vim/vim/pull/8471.diff

For unclear reasons the web interface doesn't offer a link.
I also didn't know until someone pointed it out.

--
The war between Emacs and Vi is over. Vi has won with 3 to 1.
http://m.linuxjournal.com/files/linuxjournal.com/linuxjournal/articles/030/3044/3044s1.html

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Christian Brabandt

unread,
Aug 13, 2021, 10:11:58 AM8/13/21
to vim...@googlegroups.com

On Fr, 13 Aug 2021, Bram Moolenaar wrote:

> For unclear reasons the web interface doesn't offer a link.
> I also didn't know until someone pointed it out.

Yeah, that's clearly an advantage of reading the github notification
mails. It always contains patch and diff links (one has only the diff,
the other includes the commit message).

Mit freundlichen Grüßen
Christian
--
Glaub' es nicht, wenn jemand Dir sagt, daß man mit dem Kopf nicht durch
die Wand kommt.
-- Jozéf Pilsudski, Gründer des zweiten polnischen Staates
Reply all
Reply to author
Forward
0 new messages