[vim/vim] Make 'virtualedit' option global-local (#8638)
Gary Johnson
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/8638
Commit Summary
- Make the 'virtualedit' option global-local
- Merge branch 'master' into gj_ve_global_local
File Changes
- M runtime/doc/options.txt (2)
- M src/buffer.c (1)
- M src/change.c (2)
- M src/drawscreen.c (8)
- M src/edit.c (6)
- M src/misc2.c (21)
- M src/normal.c (6)
- M src/ops.c (16)
- M src/option.c (20)
- M src/option.h (1)
- M src/optiondefs.h (3)
- M src/optionstr.c (32)
- M src/proto/option.pro (1)
- M src/register.c (9)
- M src/structs.h (2)
- M src/testdir/test_virtualedit.vim (64)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
codecov[bot]
Codecov Report
Merging #8638 (c7a4cc0) into master (a764e73) will decrease coverage by
87.60%.
The diff coverage is8.62%.
@@ Coverage Diff @@ ## master #8638 +/- ## =========================================== - Coverage 90.08% 2.47% -87.61% =========================================== Files 150 148 -2 Lines 169462 164221 -5241 =========================================== - Hits 152659 4072 -148587 - Misses 16803 160149 +143346
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | ? |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 2.47% <8.62%> (+<0.01%) |
⬆️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/buffer.c | 3.47% <0.00%> (-88.98%) |
⬇️ |
| src/change.c | 1.54% <0.00%> (-91.43%) |
⬇️ |
| src/drawscreen.c | 1.63% <0.00%> (-84.75%) |
⬇️ |
| src/edit.c | 0.00% <0.00%> (-92.89%) |
⬇️ |
| src/misc2.c | 5.35% <0.00%> (-87.07%) |
⬇️ |
| src/normal.c | 0.50% <0.00%> (-95.54%) |
⬇️ |
| src/ops.c | 0.00% <0.00%> (-96.00%) |
⬇️ |
| src/register.c | 0.21% <0.00%> (-91.82%) |
⬇️ |
| src/optionstr.c | 21.48% <7.14%> (-73.66%) |
⬇️ |
| src/option.c | 16.84% <33.33%> (-77.45%) |
⬇️ |
| ... and 146 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update a764e73...c7a4cc0. Read the comment docs.
vim-dev ML
> -------------------------------------------------------------------------------
example, a build titled "linux (huge, gcc, none)" fails with these
last lines in the log:
749 File 'sign.c'
750 Lines executed:94.58% of 1200
751 Creating 'sign.c.gcov'
752
753 {'message': "Couldn't find a repository matching this job.", 'error': True}
754 Error: Process completed with exit code 1.
Huh? I have no idea what that means or what to do about it.
How do I fix that?
Regards,
Gary
Christian Brabandt
This error can be ignored. For some reason the coverity job only works when the patch has been merged. Don't know why or how to fix it.
—
You are receiving this because you commented.
Bram Moolenaar
Thanks, mostly looks good.
One situation is not covered: If the global value is set, there is no way do disable it locally, since an empty value means to use the global value. How about using "none", using it for the local value would then overrule the global value.
There are actually other options where this could be useful. But since nobody asked for it, probably less so.
—
You are receiving this because you commented.
Gary Johnson
> Thanks, mostly looks good.
> One situation is not covered: If the global value is set, there is no way do
> disable it locally, since an empty value means to use the global value. How
> about using "none", using it for the local value would then overrule the global
> value.
> There are actually other options where this could be useful. But since nobody
> asked for it, probably less so.
that same problem, I thought it was a deliberate feature of
global-local options.
If you'd like "none", I'll add it.
Regards,
Gary
vim-dev ML
Gabriel Dupras
An example of this is 'showbreak'. From the help files:
A window-local value overrules a global value. If the global value is
set and you want no value in the current window use NONE:
:setlocal showbreak=NONE
—
You are receiving this because you commented.
Bram Moolenaar
Gabriel Dupras wrote:
> An example of this is `'showbreak'`. From the help files:
>
> ```
> A window-local value overrules a global value. If the global value is
> set and you want no value in the current window use NONE:
> :setlocal showbreak=NONE
For 'virtualedit' we can use either NONE or none. Best is probably to
accept both.
--
hundred-and-one symptoms of being an internet addict:
242. You turn down a better-paying job because it doesn't come with
a free e-mail account.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
You are receiving this because you commented.