Patch 8.2.2699

[Bram Moolenaar]

Patch 8.2.2699
Problem: Lua test fails.
Solution: Fix condition. (Yegappan Lakshmanan, closes #8060)
Files: src/testdir/test_lua.vim


*** ../vim-8.2.2698/src/testdir/test_lua.vim 2021-04-03 15:35:43.217048704 +0200
--- src/testdir/test_lua.vim 2021-04-03 17:11:40.498357804 +0200
***************
*** 20,26 ****
endif
let s:major = str2nr(s:luaver[0])
let s:minor = str2nr(s:luaver[1])
! if len(s:luaver >= 3)
let s:patch = str2nr(s:luaver[2])
else
let s:patch = 0
--- 20,26 ----
endif
let s:major = str2nr(s:luaver[0])
let s:minor = str2nr(s:luaver[1])
! if len(s:luaver) >= 3
let s:patch = str2nr(s:luaver[2])
else
let s:patch = 0
*** ../vim-8.2.2698/src/version.c 2021-04-03 15:35:43.221048697 +0200
--- src/version.c 2021-04-03 17:18:31.396988805 +0200
***************
*** 752,753 ****
--- 752,755 ----
{ /* Add new patch number below this line */
+ /**/
+ 2699,
/**/

--
There is a difference between "should work" and "does work",
it's called testing.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Yegappan Lakshmanan]

Hi Bram,

On Sat, Apr 3, 2021 at 8:19 AM Bram Moolenaar <Br...@moolenaar.net> wrote:
>
>
> Patch 8.2.2699
> Problem: Lua test fails.
> Solution: Fix condition. (Yegappan Lakshmanan, closes #8060)
> Files: src/testdir/test_lua.vim
>
>

There are still two test failures (not related to lua).

A memory leak is detected by leak sanitizer:

#1 0x9a6a87 in lalloc /home/runner/work/vim/vim/src/misc2.c:925:11
32 #2 0x9a6a5d in alloc /home/runner/work/vim/vim/src/misc2.c:828:12
33 #3 0x9a7638 in vim_strsave /home/runner/work/vim/vim/src/misc2.c:1281:9
34 #4 0xf097b3 in call_def_function
/home/runner/work/vim/vim/src/vim9execute.c:2461:24
35 #5 0xe797c0 in call_user_func /home/runner/work/vim/vim/src/userfunc.c:2204:2
36 #6 0xe76dbc in call_user_func_check
/home/runner/work/vim/vim/src/userfunc.c:2592:2
37 #7 0xe73144 in call_func /home/runner/work/vim/vim/src/userfunc.c:3070:11
38 #8 0xe71e25 in get_func_tv /home/runner/work/vim/vim/src/userfunc.c:1469:8
39 #9 0xe93e82 in ex_call /home/runner/work/vim/vim/src/userfunc.c:4710:6

Another test failure in test_terminal.vim:

From test_terminal.vim:
11818 Found errors in Test_terminal_nested_autocmd():
11819 Run 1:
11820 Caught exception in Test_terminal_nested_autocmd():
Vim(bwipeout):E89: No write since last change for buffer 54 (add ! to
override) @ command line..script
D:/a/vim/vim/src2/testdir/runtest.vim[473]..function
RunTheTest[44]..Test_terminal_nested_autocmd, line 16


- Yegappan

[Bram Moolenaar]

Yegappan wrote:

> On Sat, Apr 3, 2021 at 8:19 AM Bram Moolenaar <Br...@moolenaar.net> wrote:
> >
> >
> > Patch 8.2.2699
> > Problem: Lua test fails.
> > Solution: Fix condition. (Yegappan Lakshmanan, closes #8060)
> > Files: src/testdir/test_lua.vim
> >
> >
>
> There are still two test failures (not related to lua).
>
> A memory leak is detected by leak sanitizer:
>
> #1 0x9a6a87 in lalloc /home/runner/work/vim/vim/src/misc2.c:925:11
> 32 #2 0x9a6a5d in alloc /home/runner/work/vim/vim/src/misc2.c:828:12
> 33 #3 0x9a7638 in vim_strsave /home/runner/work/vim/vim/src/misc2.c:1281:9
> 34 #4 0xf097b3 in call_def_function
> /home/runner/work/vim/vim/src/vim9execute.c:2461:24
> 35 #5 0xe797c0 in call_user_func /home/runner/work/vim/vim/src/userfunc.c:2204:2
> 36 #6 0xe76dbc in call_user_func_check
> /home/runner/work/vim/vim/src/userfunc.c:2592:2
> 37 #7 0xe73144 in call_func /home/runner/work/vim/vim/src/userfunc.c:3070:11
> 38 #8 0xe71e25 in get_func_tv /home/runner/work/vim/vim/src/userfunc.c:1469:8
> 39 #9 0xe93e82 in ex_call /home/runner/work/vim/vim/src/userfunc.c:4710:6

Yes, caused by the new check for a locked script varialbe. Fixed by
8.2.2703.

> Another test failure in test_terminal.vim:
>
> >From test_terminal.vim:
> 11818 Found errors in Test_terminal_nested_autocmd():
> 11819 Run 1:
> 11820 Caught exception in Test_terminal_nested_autocmd():
> Vim(bwipeout):E89: No write since last change for buffer 54 (add ! to
> override) @ command line..script
> D:/a/vim/vim/src2/testdir/runtest.vim[473]..function
> RunTheTest[44]..Test_terminal_nested_autocmd, line 16

Depending on the system the external command may finish sooner or later.
More reliable way to handle that in 8.2.2700.

--
hundred-and-one symptoms of being an internet addict:
52. You ask a plumber how much it would cost to replace the chair in front of
your computer with a toilet.