[vim/vim] Add %check as allowed section in SPEC files. (#5531)
Matěj Cepl
@ignatenkobrain What do you think?
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/5531
Commit Summary
- Add %check as allowed section in SPEC files.
File Changes
- M runtime/syntax/spec.vim (2)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Codecov
Codecov Report
Merging #5531 into master will increase coverage by
<.01%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #5531 +/- ## ========================================== + Coverage 83% 83% +<.01% ========================================== Files 134 134 Lines 147991 147991 ========================================== + Hits 122837 122841 +4 + Misses 25154 25150 -4
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/highlight.c | 82.52% <0%> (-0.27%) |
⬇️ |
| src/screen.c | 84.63% <0%> (-0.23%) |
⬇️ |
| src/gui.c | 63.48% <0%> (-0.16%) |
⬇️ |
| src/channel.c | 84.23% <0%> (-0.08%) |
⬇️ |
| src/window.c | 88.37% <0%> (-0.04%) |
⬇️ |
| src/if_xcmdsrv.c | 86.17% <0%> (ø) |
⬆️ |
| src/drawline.c | 84.8% <0%> (+0.13%) |
⬆️ |
| src/os_unix.c | 63.63% <0%> (+0.22%) |
⬆️ |
| src/ui.c | 72.32% <0%> (+1.11%) |
⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 1d9215b...e76022f. Read the comment docs.
Igor Gnatenko
LGTM
Matěj Cepl
LGTM
So, how I should proceed to get this merged?
Christian Brabandt
the usual way is to have the runtime file maintainer send an update to Bram for inclusion.
Matěj Cepl
the usual way is to have the runtime file maintainer send an update to Bram for inclusion.
The hope that Bram would actually follow vim_dev is probably just a fantasy, right?
Igor Gnatenko
I remember in past @brammool has merged runtime PR related to spec.vim where I gave lgtm. Let's see if this is still the case...
Bram Moolenaar
I'll include it and update the date in the header, thanks.
Bram Moolenaar
Closed #5531.
Bram Moolenaar
> > the usual way is to have the runtime file maintainer send an update
> > to Bram for inclusion.
>
> The hope that Bram would actually follow ``vim_dev`` is probably just
> a fantasy, right?
--
Those who live by the sword get shot by those who don't.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///