[patch] fixed typos in tests

10 views
Skip to first unread message

Dominique Pellé

unread,
Sep 1, 2019, 3:56:27 AM9/1/19
to vim_dev
Attached patch fixes typos in tests.

One of them in a typo in the list of flaky test names
So 'Test_terminal_termwinsize_minimum'
was not marked as flaky. If it did not fail recently,
perhaps it can be removed from the list of flaky tests?

Regards
Dominique
fixed-typos-tests-8.1.1954.diff

Bram Moolenaar

unread,
Sep 1, 2019, 8:46:28 AM9/1/19
to vim...@googlegroups.com, Dominique Pellé

Dominique wrote:

> Attached patch fixes typos in tests.

Thanks!

> One of them in a typo in the list of flaky test names
> So 'Test_terminal_termwinsize_minimum'
> was not marked as flaky. If it did not fail recently,
> perhaps it can be removed from the list of flaky tests?

Well, it's there because it failed some time ago. It doesn't hurt
anyway. I had been considering assuming all tests can be flaky. The
main reason not to do that is that running tests when they fail makes it
slow to try out fixing them.

--
hundred-and-one symptoms of being an internet addict:
156. You forget your friend's name but not her e-mail address.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages