Undeclared sign function parameters without +diff

11 views
Skip to first unread message

Tom Ryder

unread,
Jun 18, 2019, 5:51:24 PM6/18/19
to vim...@vim.org
Hello Vim developers; attached is a patch for an issue that cropped up
for me when rebuilding Vim without +diff (FEAT_DIFF) since the recent
work on 'signcolumn'.

--
Tom Ryder <https://sanctum.geek.nz/>
0001-Include-but-zero-diff-related-params-if-no-feature.patch

Bram Moolenaar

unread,
Jun 19, 2019, 8:30:22 AM6/19/19
to vim...@googlegroups.com, vim...@vim.org

Tom Ryder wrote:

> Hello Vim developers; attached is a patch for an issue that cropped up
> for me when rebuilding Vim without +diff (FEAT_DIFF) since the recent
> work on 'signcolumn'.

> The function get_sign_display_info() in screen.c includes parameters for
> integers filler_lines and filler_todo, but these are only declared and
> defined if FEAT_DIFF is defined for the +diff feature. If that feature
> is excluded, but signs are included, compilation to screen.o fails.
> This patch declares the two integers unconditionally, but defines them
> to zero later on if the feature is unavailable.

Thanks, I'll include it with a slight change.

--
hundred-and-one symptoms of being an internet addict:
238. You think faxes are old-fashioned.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages