Patch 8.1.1478

[Bram Moolenaar]

Patch 8.1.1478
Problem: Still an error when running tests with the tiny version.
Solution: Do not try reading test.log
Files: src/testdir/Makefile, src/testdir/summarize.vim


*** ../vim-8.1.1477/src/testdir/Makefile 2019-06-06 13:37:56.967789508 +0200
--- src/testdir/Makefile 2019-06-06 14:27:30.830283175 +0200
***************
*** 49,54 ****
--- 49,59 ----
benchmark: $(SCRIPTS_BENCH)

report:
+ # without the +eval feature test_result.log is a copy of test.log
+ @/bin/sh -c "if test -f test.log; \
+ then cp test.log test_result.log; \
+ else echo No failures reported > test_result.log; \
+ fi"
$(RUN_VIMTEST) $(NO_INITS) -S summarize.vim messages $(REDIR_TEST_TO_NULL)
@echo
@echo 'Test results:'
*** ../vim-8.1.1477/src/testdir/summarize.vim 2019-06-06 14:08:47.486391198 +0200
--- src/testdir/summarize.vim 2019-06-06 14:26:49.566573530 +0200
***************
*** 50,61 ****
catch " Catch-all
finally
call writefile(output, 'test_result.log') " overwrites an existing file
- q!
endtry
endif

- " This is executed without the eval feature
- %d
- r test.log
- w test_result.log
q!
--- 50,56 ----
*** ../vim-8.1.1477/src/version.c 2019-06-06 14:08:47.490391171 +0200
--- src/version.c 2019-06-06 14:26:04.654896242 +0200
***************
*** 769,770 ****
--- 769,772 ----
{ /* Add new patch number below this line */
+ /**/
+ 1478,
/**/

--
hundred-and-one symptoms of being an internet addict:
92. It takes you two hours to check all 14 of your mailboxes.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Christian Brabandt]

On Do, 06 Jun 2019, Bram Moolenaar wrote:

> Patch 8.1.1478
> Problem: Still an error when running tests with the tiny version.
> Solution: Do not try reading test.log
> Files: src/testdir/Makefile, src/testdir/summarize.vim

I did not see any failures with the tiny version those and neither did
Travis:
https://travis-ci.org/vim/vim/builds/542222386
https://travis-ci.org/vim/vim/builds/542233477

And Appveyor hasn't even come to that patch yet (currently testing patch
8.1.1473). What error did you see?

Best,
Christian
--
Wenn Frauen sich schön anziehen, sind sie wahrscheinlich der Ansicht,
die Männer hielten sie unbekleidet für genauso reizvoll.
-- Christian Dior

[Bram Moolenaar]

Christian wrote:

> On Do, 06 Jun 2019, Bram Moolenaar wrote:
>
> > Patch 8.1.1478
> > Problem: Still an error when running tests with the tiny version.
> > Solution: Do not try reading test.log
> > Files: src/testdir/Makefile, src/testdir/summarize.vim
>
> I did not see any failures with the tiny version those and neither did
> Travis:
> https://travis-ci.org/vim/vim/builds/542222386
> https://travis-ci.org/vim/vim/builds/542233477
>
> And Appveyor hasn't even come to that patch yet (currently testing patch
> 8.1.1473). What error did you see?

This only shows when you don't redirect output (that's why it was
commented out):

export VIMRUNTIME; ../vim -f -u unix.vim -U NONE --noplugin --not-a-term -S summarize.vim messages
essages" [New File]
Error detected while processing /home/travis/build/vim/vim/src/testdir/summariz
:
line 33:
E10: \ should be followed by /, ? or &
line 34:
E10: \ should be followed by /, ? or &
line 35:
E10: \ should be followed by /, ? or &
line 36:
E10: \ should be followed by /, ? or &
line 37:
E10: \ should be followed by /, ? or &
line 38:
E10: \ should be followed by /, ? or &
line 39:
E10: \ should be followed by /, ? or &
line 58:
E484: Can't open file test.log
Test results:
ALL DONE

--
hundred-and-one symptoms of being an internet addict:

95. Only communication in your household is through email.

[Christian Brabandt]

On Do, 06 Jun 2019, Bram Moolenaar wrote:
> export VIMRUNTIME; ../vim -f -u unix.vim -U NONE --noplugin
> --not-a-term -S summarize.vim messages essages" [New File]
> Error detected while processing /home/travis/build/vim/vim/src/testdir/summariz
> :
> line 33:
> E10: \ should be followed by /, ? or &
> line 34:
> E10: \ should be followed by /, ? or &
> line 35:
> E10: \ should be followed by /, ? or &
> line 36:
> E10: \ should be followed by /, ? or &
> line 37:
> E10: \ should be followed by /, ? or &
> line 38:
> E10: \ should be followed by /, ? or &
> line 39:
> E10: \ should be followed by /, ? or &
> line 58:
> E484: Can't open file test.log
> Test results:
> ALL DONE

Hm, the first part should have been skipped by the if 1.

I suppose the real error is the last one, there was no test.log output
file, hm, perhaps sil! :r would have worked. Note sure. The tiny vim is
often tricky to make work. But since you fixed it now in the Makefile, I
guess I don't have to worry about it ;)

Best,
Christian
--
Unordnung: wo nichts am rechten Platz ist.
Ordnung: wo am rechten Platz nicht ist.

[Bram Moolenaar]

The problem was that with 'compatible' set the line continuation doesn't
work. But yes, it had to be fixed in the Makefile, since without +eval
reading test.log would fail.

--
hundred-and-one symptoms of being an internet addict:

103. When you find yourself in the "Computer" section of Barnes & Noble
enjoying yourself.

[Tony Mechelynck]

On Thu, Jun 6, 2019 at 7:47 PM Christian Brabandt <cbl...@256bit.org> wrote:
[...]

> --
> Unordnung: wo nichts am rechten Platz ist.
> Ordnung: wo am rechten Platz nicht ist.

The following is the start of a chapter from "Citadel" by Antoine de
Saint-Exupéry (my translation, and quoting from memory):

My generals, in their solid stupidity, say that only those objects are
in order which differ no more from each other. Thus, if I let them,
they would take the sacred books, where any little child would see
that the characters are all mixed up, and they would reorder them: all
A's together, all B's together, and so on; and that way they would
obtain a well-ordered book. A book for generals.

(He goes on to say that a real "live" order happens when all people
work, each at his own task, usually different from his neighbour's
task, toward a common goal, as in a ship at sea, or an empire in full
bloom.)

Best rergards,
Tony