e.g.##MonticelloMethodCompilationFailure. --
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to va-smalltalk...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/758ee575-c97c-44ea-958c-bbe6a8a1dbc4n%40googlegroups.com.
Sorry, I was wrong... there is a way to look for EsAtom in CompiledMethod literals... from the Transcript -> Tools -> Browse References and there, put the atom without the ##. For example, "MonticelloMethodCompilationFailure". However, in this case it won't work because the method that Monticello generates in this case its just a sentence like this:##MonticelloMethodCompilationFailure.That is a no-op, it has no effect and hence the Compiler ignores it and that's why that's not even in the bytecode. If the method would have been:
##MonticelloMethodCompilationFailure == 'aaa'or^ ##MonticelloMethodCompilationFailure.or anything that the Compiler wouldn't ignore it, it would have been found.BTW, we changed this behavior for Tonel's #commentedSource
On Tue, Jul 21, 2020 at 10:39 AM Mariano Martinez Peck <mp...@instantiations.com> wrote:
I don't know an easy way (from the menu) to look for references to EsAtom in CompiledMethod literals. So in this case, I usually do a "Options" -> "Browse Methods" -> "Including String...".
On Tue, Jul 21, 2020 at 5:47 AM Marten Feldtmann <m.fel...@dimap.de> wrote:
e.g.##MonticelloMethodCompilationFailure. --
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to va-sma...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/758ee575-c97c-44ea-958c-bbe6a8a1dbc4n%40googlegroups.com.
--Mariano Martinez Peck
Software Engineer, Instantiations Inc.
In this case it would be nice to find all methods, so one can fix them ..
On Tuesday, July 21, 2020 at 10:21:10 AM UTC-7, Marten Feldtmann wrote:In this case it would be nice to find all methods, so one can fix them ..
Fix them?
The MonticelloImporter remarks the original source code out if there is a compile error during import and adds a helper source into that method ... so you visit each method and fixes the errors.
Marten
Marten
Richard, its all ok.The way the MonticelloImporter works is totally ok and good. He imports the source code, tries to compile the method and if that fails, he preserves the original code (put them in "") and write a small helper code into that method - parts of this helper code is the "##ewifwoeifjw" (Atom) construction. Even though the compile errors are printed in the Transcript I personally would like to see, that I can query the system for methods where this specific Atom is placed in the source code.
Richard Sargent schrieb am Mittwoch, 22. Juli 2020 um 09:52:39 UTC+2:On Tuesday, July 21, 2020 at 12:50:02 PM UTC-7, Marten Feldtmann wrote:Am 21.07.20 um 21:31 schrieb Richard Sargent:
On Tuesday, July 21, 2020 at 10:21:10 AM UTC-7, Marten Feldtmann wrote:In this case it would be nice to find all methods, so one can fix them ..
Fix them?
The MonticelloImporter remarks the original source code out if there is a compile error during import and adds a helper source into that method ... so you visit each method and fixes the errors.
Can you elaborate on what's going on? What compile errors? Why? Atoms and Compile-time Constants should compile.Marten
--
You received this message because you are subscribed to a topic in the Google Groups "VA Smalltalk" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/va-smalltalk/C8UUxUDY1Q8/unsubscribe.
To unsubscribe from this group and all its topics, send an email to va-smalltalk...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/va-smalltalk/87634c40-6456-4df1-8af5-23740b1045dfn%40googlegroups.com.