Integrating your personal changes as a dependency into V8

36 views
Skip to first unread message

Pranay Garg

unread,
Oct 27, 2020, 4:18:04 PM10/27/20
to v8-users
Hi,

I am currently playing with different builtins in V8. Trying to add some functionality in-order to do taint tracking. I want to come-up with an efficient way to version-control and integrate my changes within the V8 codebase.

Say I changed the file v8/src/builtins/builtins-string.cc. I want to be able to keep the changed file in my own git repo and automatically integrate it during the build process.

I understand the DEPS file might help me with this, but I'm not sure if this is the right direction.

Can I get some pointers?
Much appreciated :)

Thanks

Alex Kodat

unread,
Oct 27, 2020, 5:38:46 PM10/27/20
to v8-users
I can't imagine you could do much better than maintaining your own V8 branch(es) and just merging V8 changes when you want to upgrade V8. Otherwise you'll have to reinvent some git functionality -- there's no way to avoid merging your changes with V8 changes. If you're willing to go down this path, adding your own versioning scheme on top of V8's shouldn't be daunting. 

Shiv Shankar

unread,
Oct 28, 2020, 12:02:23 AM10/28/20
to v8-u...@googlegroups.com
The best way to do this is use Git Patch tool. Create the patch files for each changed file. Automate the build process in such a way that after fetting V8 code, it will get your patch filesfrom your own repo and apply the patches on the source files.
Thanks,
Shiv

--
--
v8-users mailing list
v8-u...@googlegroups.com
http://groups.google.com/group/v8-users
---
You received this message because you are subscribed to the Google Groups "v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/f94a70c8-a456-4716-a5c5-0522dfe01a1cn%40googlegroups.com.

Ben Noordhuis

unread,
Oct 28, 2020, 4:11:19 AM10/28/20
to v8-users
On Wed, Oct 28, 2020 at 5:02 AM Shiv Shankar <writeto...@gmail.com> wrote:
>
> The best way to do this is use Git Patch tool. Create the patch files for each changed file. Automate the build process in such a way that after fetting V8 code, it will get your patch filesfrom your own repo and apply the patches on the source files.
> Thanks,
> Shiv

I second this suggestion. You can crib from
https://github.com/bnoordhuis/v8-cmake - the update_v8.py script
updates to the HEAD of the release branch listed in update_v8.json and
applies everything in the patches/ directory.
Reply all
Reply to author
Forward
0 new messages