Reaching UNIMPLEMENTED code path

[ibon]

Hi there,

I recently upgraded my Android embedded v8 from 6.3 to 7.2.

I found that live editing code in Chrome Dev Tools crashes my app. All other debugging related stuff works great, but this specific use case ends up in an UNIMPLEMENTED code path inside DefaultWorkerThreadsTaskRunner::PostDelayedTask(std::unique_ptr<Task> task, double delay_in_seconds).

Reaching to this point is triggered only by dev tools' messages sent while typing in CDT console. Just one keystroke is enough to crash the app. I can rewrite a v8::platform::Platform subclass that forces zero delay for this calls which seems to fix the issue, but I wonder if this can be caused by something I am doing wrongly ?

Something specific to v8 > 6.3 since that specific version worked just ok.

v8 compilation is a freshly pulled version, 7.2-lkgr.

Thanks in advance.

- i

[Yang Guo]

v8::platform::Platform is only a barebone default implmentation. Subclassing it and implementing your own PostDelayedTask is the right thing to do.

Yang

[Peter Marshall]

I'm working on implementing DefaultWorkerThreadsTaskRunner::PostDelayedTask() right now: https://chromium-review.googlesource.com/c/v8/v8/+/1521114

Also I'm not sure why you are hitting this - where does the call to PostDelayedTask() with a non-zero delay come from?

On Friday, February 22, 2019 at 4:08:02 PM UTC+1, ibon wrote:

[Kiran Kumar]

Hi All,

I am trying to build  V8 7.2-lkgr version. I also facing exact issue "debugger is getting disconnected when i am typing in CDT console".

Please help.

Regards,

Kiran