Tick processor incorrectly parses comma-separated v8.log, when v8.log contains a log line about RegExp with comma

6 views
Skip to first unread message

Victor Homyakov

unread,
Nov 11, 2019, 7:22:29 AM11/11/19
to v8-dev
Tick processor shows errors when it parses lines in v8.log with a regular expression containing commas.

Two examples:

1. Line

code-creation,RegExp,6,10482353,0x2f967888f80,947,"^[A-Za-z0-9][A-Za-z0-9!#$&^_-]{0\,126}$"

produces error "line 1234: unknown code state: undefined"

2. Line

code-creation,RegExp,6,10482114,0x2f967887f20,1689,"^ *([A-Za-z0-9][A-Za-z0-9!#$&^_-]{0\,126})\\/([A-Za-z0-9][A-Za-z0-9!#$&^_.+-]{0\,126}) *$"

produces error "line 1234: unknown code state: 126}) *$""

It's because the log file is being read as plain CSV, but regular expression may contain commas and should be treated as a single field. Instead of this, parser passes the rest of RegExp after comma into the next parsed field.

Could someone fix this problem?
Reply all
Reply to author
Forward
0 new messages