Canceling a recieved supplier shipment

[Sergi Almacellas Abellana]

Hi,

I canceled a already received supplier shipment (generated from a
purchase) and i found the following behavior:

- Incoming moves are in done state and can not be canceled. Shouldn't
they be in canceled state as the shipment is in canceled state? If so,
the purchase workflow will prevent to draft the shipment and enforce
that the exception is handled from purchase.

- I can go from canceled to draft state. In the draft state I can use
the - button to unlink the already done moves, so no incoming moves are
created for this done move, as it's not linked to any shipment. So I'm
wondering if we should prevent modifying the shipment field of a
done/canceled move.

Toughs?


--
Sergi Almacellas Abellana
www.koolpi.com
Twitter: @pokoli_srk

[Cédric Krier]

On 2015-11-17 14:16, Sergi Almacellas Abellana wrote:
> Hi,
>
> I canceled a already received supplier shipment (generated from a purchase)
> and i found the following behavior:
>
> - Incoming moves are in done state and can not be canceled. Shouldn't they
> be in canceled state as the shipment is in canceled state? If so, the
> purchase workflow will prevent to draft the shipment and enforce that the
> exception is handled from purchase.

You can not change the state of a done move. So if you receive the
product, there are there.

> - I can go from canceled to draft state. In the draft state I can use the -
> button to unlink the already done moves, so no incoming moves are created
> for this done move, as it's not linked to any shipment. So I'm wondering if
> we should prevent modifying the shipment field of a done/canceled move.

I don't see any problem here. So I prefer we don't add constraint if it
is not needed.

--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric...@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/

[Sergi Almacellas Abellana]

El 17/11/15 a les 14:58, Cédric Krier ha escrit:

> On 2015-11-17 14:16, Sergi Almacellas Abellana wrote:
>> >Hi,
>> >
>> >I canceled a already received supplier shipment (generated from a purchase)
>> >and i found the following behavior:
>> >
>> >- Incoming moves are in done state and can not be canceled. Shouldn't they
>> >be in canceled state as the shipment is in canceled state? If so, the
>> >purchase workflow will prevent to draft the shipment and enforce that the
>> >exception is handled from purchase.
> You can not change the state of a done move. So if you receive the
> product, there are there.

So what if I made a mistake and for exemple entered 5 as quantity, but
in the reality I recieved only 4?

>
>> >- I can go from canceled to draft state. In the draft state I can use the -
>> >button to unlink the already done moves, so no incoming moves are created
>> >for this done move, as it's not linked to any shipment. So I'm wondering if
>> >we should prevent modifying the shipment field of a done/canceled move.
> I don't see any problem here. So I prefer we don't add constraint if it
> is not needed.

The move can not be added to another shipment, so it's lost in the limbo.

[Cédric Krier]

On 2015-11-17 15:04, Sergi Almacellas Abellana wrote:
> El 17/11/15 a les 14:58, Cédric Krier ha escrit:
> >On 2015-11-17 14:16, Sergi Almacellas Abellana wrote:
> >>>Hi,
> >>>
> >>>I canceled a already received supplier shipment (generated from a purchase)
> >>>and i found the following behavior:
> >>>
> >>>- Incoming moves are in done state and can not be canceled. Shouldn't they
> >>>be in canceled state as the shipment is in canceled state? If so, the
> >>>purchase workflow will prevent to draft the shipment and enforce that the
> >>>exception is handled from purchase.
> >You can not change the state of a done move. So if you receive the
> >product, there are there.
>
> So what if I made a mistake and for exemple entered 5 as quantity, but in
> the reality I recieved only 4?

You have to sent back 1. But first, don't validate wrong values.

> >>>- I can go from canceled to draft state. In the draft state I can use the -
> >>>button to unlink the already done moves, so no incoming moves are created
> >>>for this done move, as it's not linked to any shipment. So I'm wondering if
> >>>we should prevent modifying the shipment field of a done/canceled move.
> >I don't see any problem here. So I prefer we don't add constraint if it
> >is not needed.
>
> The move can not be added to another shipment, so it's lost in the limbo.

But what is exactly the problem? I see no issue with this behaviour.