client side pre-lock hook not running for single files

50 views
Skip to first unread message

ich, wer sonst

unread,
Feb 10, 2021, 10:35:30 AM2/10/21
to TortoiseSVN

Hi, I'm trying to write a pre-lock hook script but running into a probem.

For folders or multiple files selected the hook is executed, but not for single files.

I could find nothing about this effect either in the documentation nor here in the group.

Also, is there a reason there is no start-lock hook? Would be nice to be able to pre-populate the lock message (with the working copy path for instance).

Lorenz

Stefan

unread,
Feb 10, 2021, 12:38:35 PM2/10/21
to TortoiseSVN
how do you set up the hook script? What paths? via project properties? What are the values you set for the hook script?

ich, wer sonst

unread,
Feb 11, 2021, 3:02:41 AM2/11/21
to TortoiseSVN
Configure Hook Scripts.png

Thats my current setup. The "--" in the name of batch file is a deliberate error.
It results in the expected error message only if try to lock the WC folder, or multiple files inside the folder, not for single files in the folder.

Daniel Sahlberg

unread,
Feb 11, 2021, 4:06:12 AM2/11/21
to TortoiseSVN
I made some changes affecting the pre-lock hook script, committed by Stefan as r29050-29051. I believe I had some simliar problems with getting the hook script to execute. Have you tried the nightly build (https://nightlybuilds.tortoisesvn.net/latest/)?

It seems these changes didn't make it into the 1.14.1 release.

Kind regards
Daniel


--
You received this message because you are subscribed to the Google Groups "TortoiseSVN" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tortoisesvn...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn/4efa1cb2-7780-4bc8-88c0-0adf1ff17f94n%40googlegroups.com.

lorenz

unread,
Feb 11, 2021, 4:39:48 AM2/11/21
to torto...@googlegroups.com
TortoiseSVN wrote:
>I made some changes affecting the pre-lock hook script, committed by Stefan
>as r29050-29051. I believe I had some simliar problems with getting the
>hook script to execute. Have you tried the nightly build (
>https://nightlybuilds.tortoisesvn.net/latest/)?
>
>It seems these changes didn't make it into the 1.14.1 release.

no, still on 1.14.0

going to try a nightly shortly

Lorenz

PS. I've changed the eMail-Account and am now posting via gmane
--

>
>Kind regards
>Daniel
>
>
>Den tors 11 feb. 2021 kl 09:02 skrev ich, wer sonst über TortoiseSVN <
>torto...@googlegroups.com>:
>
>> [image: Configure Hook Scripts.png]
>>
>> Thats my current setup. The "--" in the name of batch file is a deliberate
>> error.
>> It results in the expected error message only if try to lock the WC
>> folder, or multiple files inside the folder, not for single files in the
>> folder.
>>
>> Stefan schrieb am Mittwoch, 10. Februar 2021 um 18:38:35 UTC+1:
>>
>>> how do you set up the hook script? What paths? via project properties?
>>> What are the values you set for the hook script?
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "TortoiseSVN" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to tortoisesvn...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/tortoisesvn/4efa1cb2-7780-4bc8-88c0-0adf1ff17f94n%40googlegroups.com
>> <https://groups.google.com/d/msgid/tortoisesvn/4efa1cb2-7780-4bc8-88c0-0adf1ff17f94n%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>

lorenz

unread,
Feb 11, 2021, 5:45:09 AM2/11/21
to torto...@googlegroups.com
Hi,

I can confirm, that using updating to "1.14.99, Build 29087" solved
the problem that the pre-lock hook was not run for single files.

It also solved the problem, that setting the working copy path to a
drive root (ie D:\) didn't work neither.
--
Lorenz

lorenz

unread,
Feb 11, 2021, 6:30:04 AM2/11/21
to torto...@googlegroups.com
Additionally the files referenced as 1st and 4th parameter to the hook
script are now populated.
With 1.14.0 there were always empty.
Reply all
Reply to author
Forward
0 new messages