Ticket-ID filed with log message

[marku...@googlemail.com]

Hello,

I am using build 1.12.2.28653 and I had the branch/tag dialog open.

I clicked on "Last messages" and selected the last message used in that popup.

When I confirmed and closed the popupü the message was not only put into the message memo as expected,

it was put into the "Ticket-ID" field, which is right of the "Last messages" button.

This of course is no valid number and thus interrupts the workflow.

Is this already known? Can it be fixed that "Last messages" does not put anything into
input fields where it should not put text in?

Best regards and thanks for analyzing this

Markus

[Stefan]

the ticket id is filled according to the issue tracker properties setup.

if you insert a "last message", it is automatically parsed to figure out whether the message is written according to the issue tracker setup and if the parser thinks it is, it fills in the ticket-id field.

This isn't 100% reliable of course (depends on your regex), so you have to check that field before committing.

[marku...@googlemail.com]

Ok, I need to check definition of Bugtracker ID as soon as I can. But the ID should be purely numerical (digits 0-9 are the only allowed chars for Mantis afaik) and I'm quite sure my text didn't contain any number. But ok, I'll look it up and report here.

[marku...@googlemail.com]

I checked my working copy now. There is a property "bugtraq:url" in the root flder of it which contains an URL like:

https://wwws.mydomain.com/subfolder/mantis/view.php?id=%BUGID%

and the pattern is %BUGID%.

It is also defined that the Ticked-Id is numerical and at the end
(so pasting/putting text in a field which is numerical as per this definition would be considered
as bug by me - your view may differ).

There is no RegEx defined.

Ok, the Setting is not set to be applied recursively.

That's what I can tell about it now.

Any idea?

Am Dienstag, 17. September 2019 19:42:44 UTC+2 schrieb Stefan:

[Niemann, Hartmut]

Hi!

 

With a similar bugtraq:url, my bugtraq:logregex is (#\d+) (\d+), i.e.

Message part expression (#\d+)

Bug-ID expression (\d+)

 

So if a ticket number like #1234 shows in the log message, that will be detected (first regex) and from that just the digits (second regex) will be copied to the Bug-ID field.

 

At least that is my understanding how it works.

 

I’d guess you need to read the documentation about the bugtraq:logregex, especially the first part of it, and construct a correct regexp for the format you use.

 

It looks like the system does unexpected things if you leave the logregex empty.

 

Regards

Hartmut

[marku...@googlemail.com]

Hello,

thanks for this explanation. I just still feel there's something not right.

I think my message didn't contain any number and the ID field is defined as numeric.

So why is Tortoise writing some non numeric text into a field which is defined as numeric?

If there's no regex defined it should not search the last log message for any ID at all I guess?

Best regards

Markus

[Stefan]

On Friday, September 20, 2019 at 11:47:14 AM UTC+2, (unknown) wrote:

I checked my working copy now. There is a property "bugtraq:url" in the root flder of it which contains an URL like:

https://wwws.mydomain.com/subfolder/mantis/view.php?id=%BUGID%

and the pattern is %BUGID%.

It is also defined that the Ticked-Id is numerical and at the end
(so pasting/putting text in a field which is numerical as per this definition would be considered
as bug by me - your view may differ).

There is no RegEx defined.

Ok, the Setting is not set to be applied recursively.

When you paste a previous message into the commit dialog, that message is parsed for bug ids.

That parsing is done with the assumption that there is a bug id present.

So, either the first or the last line of the message is considered the bug-id line. But if that message doesn't contain one, then of course that line in the message contains 'garbage' in respect to a bug-id.

Check the bugtraq:message property: it is used to determine whether the message contains a bug-id.