Bug: Hyperlinks to revisions in log window

26 views

Skip to first unread message

Dave Lawrence

unread,

Feb 8, 2022, 4:47:35 PM2/8/22

to TortoiseSVN

Background:

If a commit comment contains a revision number that matches the tsvn:logrevregex regex, the revision number will be turned into a hyperlink in the log window. Clicking on that hyperlink will either:

1) Scroll to that revision if it is already in the list of revisions in the log window

2) Inject that revision into the list of revisions in the existing log window (done if the revision exists in the log cache)

3) Open a new log window of the repository root, starting at that revision number (done if the revision is not in the log cache)

The bug:

When the revision is injected into the existing log window, it doesn't show any modified file paths, so you can't even see what branch that revision made changes in.

Besides this bug, it seem unintuitive to inject an arbitrary revision into the existing log window. We often mention revision numbers when merging revisions from other branches, and it's confusing to have a revision from branch B injected when you are viewing a log of branch A.

Rather than fixing the bug, my suggestion is to remove the try-catch block from CLogDlg::OnEnLinkMsgview() so it always opens the revision in a new window if it isn't already included in the existing list of revisions. Besides bypassing the bug, this will make the behavior consistent whether the revision is cached or not.

Thanks!

Dave Lawrence

Stefan

unread,

Feb 9, 2022, 1:12:47 PM2/9/22

to TortoiseSVN

On Tuesday, February 8, 2022 at 10:47:35 PM UTC+1 Dave Lawrence wrote:

Rather than fixing the bug, my suggestion is to remove the try-catch block from CLogDlg::OnEnLinkMsgview() so it always opens the revision in a new window if it isn't already included in the existing list of revisions. Besides bypassing the bug, this will make the behavior consistent whether the revision is cached or not.