Pre commit hook condition not throwing error

[Void]

I'm looking for a way to cancel a pre commit hook on a error. I only want the user to enter a number between 1 and 2 and if it's not I need to cancel the commit, how can I do this?

     int val;

      if (!int.TryParse(Console.ReadLine(), out val))

      {

        Console.Error.WriteLine("Please enter a number");

        return;

      }

[Stefan]

If there's something written to the console error, the script will read that and show it to the user. But only if the hook script is configured with "wait for the script to finish".

 

[Void]

Unfortunately this is still prompting the user with a window to commit when I try this and does not log an error.

[Stefan]

On Monday, December 11, 2017 at 7:02:35 PM UTC+1, Void wrote:

Unfortunately this is still prompting the user with a window to commit when I try this and does not log an error.

      int val;

      if (!int.TryParse(Console.ReadLine(), out val))

      {

        Console.Error.WriteLine("Please enter a number");

        return;

      }

Did you compile your script as a console program?

If not, the Console.Error.WriteLine has nowhere to write to.

[Void]

Yes it's compiled as a console app since I'm getting my read line. This is also not canceling the commit either, :) 

[Stefan]

On Tuesday, December 12, 2017 at 12:13:46 AM UTC+1, Void wrote:

Yes it's compiled as a console app since I'm getting my read line. This is also not canceling the commit either, :) 

How exactly did you set up your hook script? Is it even called? When is it called?

[Void]

I added it as as a hook script in the Hook Scripts settings. It's a start_commit_hook, and yes it's called as I get console window to enter to the console. 

When I enter a letter and read it with Console.ReadLine() the function should exit out and popup a error message, but it's not showing the error and it continues with the commit. 

[Stefan]

On Tuesday, December 12, 2017 at 10:19:46 PM UTC+1, Void wrote:

I added it as as a hook script in the Hook Scripts settings. It's a start_commit_hook, and yes it's called as I get console window to enter to the console. 

When I enter a letter and read it with Console.ReadLine() the function should exit out and popup a error message, but it's not showing the error and it continues with the commit. 

first: maybe you may want a check-commit hook instead start-commit hook. But that's just my guess.

second: you also have to return from your script with a non-null exit code to indicate an error. If your script returns with zero, then that means no error.

Stefan

[Void]

No, I need to commit a file that the hook updates. So start-commit hook is what I need. 

You are correct about the return, I was using a void. Thank you so much this really helped!