Bug: TortoiseSVN URL: wrong encoding prevents log viewing
J.S.
TortoiseSVN 1.9.7 r27907 and also r28100 do wrong URL‑encoding if viewing non‑cached logs *directly* and the path includes characters to encode (e.g. German umlaute) *twice* (own part in path of repository and one in file/folder structure of repository content).
Steps to reproduce (all with the GUI):
- Create new repository e.g. C:\Temp\repo with default folder structure
- Create Folder trunk/Prüfung
- „Show log“ of the newly created folder
- Success, it works like it should
- Create new repository e.g. “C:\Temp\repo with spaces” with default folder structure
- Create Folder trunk/Prüfung
- „Show log“ of the newly created folder
- Error message “Want to go offline?” is shown (file:///C:/Temp/repo%2520with%2520spaces/trunk/Pr%C3%BCfung)
Workaround:
- View the logs of the parents before
Please remember to clear the cache before repeating the steps to reproduce!
Cheers Jörk S.
I found the same or similar description:
https://groups.google.com/d/msg/tortoisesvn/IsA4pDnKJiw/0KTFro1UBgAJ
https://groups.google.com/d/msg/tortoisesvn/Tf5aJpuZOg4/jGiDNGvdBgAJ
https://groups.google.com/d/msg/tortoisesvn/ysNV9QymMy0/4aN0uuRlEgAJ
Stefan
On Friday, March 2, 2018 at 1:45:31 PM UTC+1, J.S. wrote:
TortoiseSVN 1.9.7 r27907 and also r28100 do wrong URL‑encoding if viewing non‑cached logs *directly* and the path includes characters to encode (e.g. German umlaute) *twice* (own part in path of repository and one in file/folder structure of repository content).
Steps to reproduce (all with the GUI):
- Create new repository e.g. C:\Temp\repo with default folder structure
- Create Folder trunk/Prüfung
- „Show log“ of the newly created folder
- Success, it works like it should
- Create new repository e.g. “C:\Temp\repo with spaces” with default folder structure
you must never create a repository on a path that needs escaping.
Because the 'domain' part of an url can not have escape chars.
You can have special chars *inside* a repository as much as you like, but never in the part of the path *to* the repository.
At least not if you're using the file:/// protocol.
J.S.
> you must never create a repository on a path that needs escaping.
> At least not if you're using the file:/// protocol.
Sorry, my fault!
The file protocol example should only be an simple one – the initial error occurred with the http protocol!
So an example URL is
http://server.domain.tld/repositories/A/Customer with spaces/.
Maybe it is an (un)documented limitation, but it affects also the http protocol …
Cheers Jörk S.
J.S.
> you must never create a repository on a path that needs escaping.
>
> At least not if you're using the file:/// protocol.
Since the commands
svn log "file:///C:/Temp/repo with spaces/trunk/Prüfung"
and
svn log “http(s)://server.domain.tld/repositories/A/Customer with spaces/trunk/Prüfung”
do work, I still think that’s an encoding bug of TortoiseSVN.
Because of lack of knowledge I’m really sorry that I cannot help fixing it.
Cheers Jörk S.
J.S.
> Since the commands
> svn log "file:///C:/Temp/repo with spaces/trunk/Prüfung"
> and
> svn log “http(s)://server.domain.tld/repositories/A/Customer with spaces/trunk/Prüfung”
> do work, I still think that’s an encoding bug of TortoiseSVN.
Can someone please confirm that this bug exists? Thank you!
Cheers Jörk S.
J.S.
> TortoiseSVN 1.9.7 r27907 and also r28100 do wrong URL encoding if viewing non cached logs *directly* and the path includes characters to encode (e.g. German umlaute) *twice* (own part in path of repository and one in file/folder structure of repository content).
> Steps to reproduce (all with the GUI):
> 1. Create new repository e.g. C:\Temp\repo with default folder structure
> 2. Create Folder trunk/Prüfung
> 3. „Show log“ of the newly created folder
> 4. Success, it works like it should
>
> 1. Create new repository e.g. “C:\Temp\repo with spaces” with default folder structure
> 2. Create Folder trunk/Prüfung
> 3. „Show log“ of the newly created folder
> 4. Error message “Want to go offline?” is shown (file:///C:/Temp/repo%2520with%2520spaces/trunk/Pr%C3%BCfung)
>
> Workaround:
> 1. View the logs of the parents before
>
> Please remember to clear the cache before repeating the steps to reproduce!
>
> Cheers Jörk S.
>
> I found the same or similar description:
> https://groups.google.com/d/msg/tortoisesvn/IsA4pDnKJiw/0KTFro1UBgAJ
> https://groups.google.com/d/msg/tortoisesvn/Tf5aJpuZOg4/jGiDNGvdBgAJ
> https://groups.google.com/d/msg/tortoisesvn/ysNV9QymMy0/4aN0uuRlEgAJ
Hello!
Thanks for the active development on such a great tool!
For your information: the bug still exists in v1.10 …
TortoiseSVN 1.10.0, Build 28176 - 64 Bit , 2018/04/14 08:00:32
ipv6 enabled
Subversion 1.10.0, -dev
apr 1.6.3
apr-util 1.6.1
serf 1.3.9
OpenSSL 1.1.0h 27 Mar 2018
zlib 1.2.11
SQLite 3.23.1
Cheers Jörk S.
Spörk Antriebssysteme GmbH, Kottingbrunn, FN 274532z, LG WN
J.S.
Hello!
I have waited for a long period of time (over 2 years), but now it seems to be really fixed! Thanks a lot! (See https://groups.google.com/forum/#!topic/tortoisesvn/bOD2OceFisk)
Maybe this problems are also fixed:
- https://groups.google.com/forum/#!topic/tortoisesvn/9ZeQp_QMUwQ
- https://groups.google.com/forum/#!topic/tortoisesvn/I2T6yCYZ0OY
Regards Jörk S.
--
You received this message because you are subscribed to the Google Groups "TortoiseSVN" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
tortoisesvn...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/tortoisesvn/420051FA628C494C8D7A35940C104623C80BE394%40DATENSERVER.spoerk.local.
For more options, visit https://groups.google.com/d/optout.
Spörk Antriebssysteme GmbH, Kottingbrunn, FN 274532z, LG WN