commit dialog behavior on ESC-keypress

[Alexander Stohr]

i once had the case that when i closed a diff-view that i had opened from the commit dialog i accidentially hit those key twice.

this lead to the result that the underlying commit dialog vanished as well.

i assume by this all this my states were lost:

* entered text in the commit comment text box

* all altered check states in the files from the commit file listing

* my current highlight position in the commit file listing

(* other states i am currently not aware of)

(clicking the right file state again is sometimes a heavy duty; having lost the draft message for the commit is a bit of a mess as well - i lost some of my values...)

i would have liked this dialog to ask me for "do you really want to loose all your changes and close this window? yes/no" first before closing itself.

Is there such an option?

Regards, Alex.

PS: of course the "are you sure" question is not needed if all of the relevant states are still at their defaults.

[Oskar Berggren]

I too have suffered from this unfortunate event.

/Oskar

--
You received this message because you are subscribed to the Google Groups "TortoiseSVN" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tortoisesvn...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn/754fee60-6f37-4218-ae5b-722a3d5e88a4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Senjuu]

The "all altered check states in the files from the commit file listing" and "my current highlight position in the commit file listing" can probably

be solved by using changelist. You could e.g. move all files from "(no checklist)" to new changelist like "next-commit" or "skip this commit".

So you know which files you want to commit now and which not. Then you select all from "next-commit" make the commit and remove all files

from these chnagelists.

The "entered text in the commit comment text box" is no problem at al your entered message can be seen via the button "Recent messages"

directly above the text field.

[Alexander Stohr]

Nah, this thread is about sudden accidental closing - not about preparing a controlled postponing of commits. (The first can happen anytime during editing, the second is a scheduled process.)

And i feel like (have not checked again) that when closing with ESC (=cancel) then no states at all, and not even the "Recent messages" will bring back what vanished.

[Senjuu]

The message can be brought back via "Recent messages" otherwise I would not had mentioned it.

[Tobias Knauss]

This also happens to me from time to time. Before committing changes, I am reviewing everything by opening multiple Comparisons in BC4 at the same time. Then I just close each TabPage in BC4 by ESC key. Pressing that key once to often results in the Commit Dialog closing as well.

Therefore I suggest 2 options

1) "Close Dialogs on ESC"

2) "Close Commit Dialog on ESC"

either in the dialog options or in the advanced options.

The 2 options are required because you don't want to lose the checked state of the items in the commit dialog by accidentally hitting ESC, while on the other hand you usually still want to close all other dialogs by ESC.

These options would have saved me some hours of extra work in the past.

With best regards

Tobias Knauss