Edit Control misbehaving

37 views
Skip to first unread message

sbrueg...@gmx.net

unread,
Aug 29, 2018, 9:14:58 AM8/29/18
to TortoiseSVN-dev
Hello,

the control for entering/editing log messages (Scintilla?) is misbehaving in the latest trunk nightly:

- While typing the text is no longer scrolled when reaching the end of the visible area
- it's impossible to navigate in the text. The cursor up and cursor down keys jump around in the text in an unpredictable way or do nothing depending on the current cursor position

All dialogs tested so far are affected: Commit, Lock, Edit Log Message,...

(I installed trunk 28340 today and was at 1.10.2 28327 before which was still OK).

Kind regards

Stefan

unread,
Aug 30, 2018, 12:23:03 PM8/30/18
to TortoiseSVN-dev
works fine for me here.
Can you try to disable L2R support in the settings dialog->Advanced->ScintillaBidirectional (set to false).

Stefan

sbrueg...@gmx.net

unread,
Aug 31, 2018, 2:53:47 AM8/31/18
to TortoiseSVN-dev
> Can you try to disable L2R support in the settings
> dialog->Advanced->ScintillaBidirectional (set to false).

it works with that setting. To reproduce the behaviour with the original setting you might need to enter a text with word wraps. Simply compy my original post into the control and change it's size if needed to let word wraps occur.

Stefan

unread,
Aug 31, 2018, 7:57:55 AM8/31/18
to TortoiseSVN-dev
I've tested with word wrap as well and couldn't reproduce the problem.
Is your OS language maybe R2L?

Stefan

sbrueg...@gmx.net

unread,
Aug 31, 2018, 11:21:07 AM8/31/18
to TortoiseSVN-dev
No, L2R (German Win 8.1 Pro).

I played around with the Edit Log Messages dialog in the Project Monitor on the TSVN repro:

The first line of the log message has to be word wrapped (indicated by the wrap-symbol at the end of the line, not just line breaks) AND the whole log message has to be longer than the visible area of the control (scroll bar is present).

Place the cursor before the very first character of the log message and press cursor down twice. It depends on the length of the line(s) what actually happens, but here it's never the expected behaviour (go one line down on each keypress and stay in the column or jump to the end if the line if the line is smaller than the one you started from).

Can you reproduce it that way?

Stefan

unread,
Sep 1, 2018, 3:31:27 AM9/1/18
to TortoiseSVN-dev
I've disabled the BiDi-support by default for now (r28341).
Since it's still marked experimental in Scintilla, I think that's the best option.

Stefan
Reply all
Reply to author
Forward
0 new messages