All TortoiseSVN 1.10+ builds inadvertently compile with APR_HAVE_IPV6 = 1?

[Evgeny Kotkov]

Hi,

I see that all TortoiseSVN 1.10 and later builds (both regular and "-ipv6")
have been compiled with APR_HAVE_IPV6 = 1.

This happened because APR 1.6 changed the default value for APR_HAVE_IPV6
from 0 to 1, so apr.build tries to replace the string that no longer exists:

    <replacestring from="#define APR_HAVE_IPV6           0"
                   to="#define APR_HAVE_IPV6           1"
                   if="${ipv6 == 'enabled'}" />

To confirm this, the most recent non-ipv6 build says "ipv6 enabled" in About:
https://osdn.net/projects/tortoisesvn/storage/1.14.3/Application/TortoiseSVN-1.14.3.29387-x64-svn-1.14.2.msi


Maybe the script could be updated to disable IPv6 as originally intended.

Or maybe there is no real problem in enabling IPv6, because the change
happened 5 years ago in TSVN 1.10.0, and apparently it hasn't been causing
issues for the users. If so, it might make sense to keep IPv6 enabled in the
mainstream builds and remove the non-ipv6/ipv6 distinction.

Anyway, reporting this discrepancy just in case…


Thanks,
Evgeny Kotkov

[Daniel Sahlberg]

The ipv6 build option was removed in r29394.

Would it also make sense to remove the ipv6 scripts in contrib\choco? I've searched the source and I can't find them being used anywhere anymore.