tsvn r29468

10 views
Skip to first unread message

Daniel Sahlberg

unread,
Oct 4, 2022, 2:17:36 PM10/4/22
to TortoiseSVN-dev
Meta question: I'm getting notified by the mail from osdn.net about commits. Is this the best way to provide feedback on commits? It isn't clear to me if I can reply to the mail and have it distributed to all committers.

[[[
Modified: trunk/src/TortoiseShell/ContextMenu.cpp
===================================================================
--- trunk/src/TortoiseShell/ContextMenu.cpp     2022-09-26 17:17:51 UTC (rev 29467)
+++ trunk/src/TortoiseShell/ContextMenu.cpp     2022-10-04 18:00:51 UTC (rev 29468)

]]] ... [[[
@@ -1222,9 +1222,9 @@
         }
     }

-    //add sub menu to main context menu
-    //don't use InsertMenu because this will lead to multiple menu entries in the explorer file menu.
-    //see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for details of that.
+    // add sub menu to main context menu
+    // don't use InsertMenu because this will lead to multiple menu entries in the explorer file menu.
+    // see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for details of that.
     MAKESTRING(IDS_MENUSUBMENU);
     if (!g_shellCache.HasShellMenuAccelerators())
     {
]]]

I got curious and checked the link, but Microsoft seems to be deprecating old KB articles and I can't find the article on microsoft.com


Does it seem reasonable to update these kind of links to archive.org (or does someone else know where to find it on microsoft.com)? I can do it, time permitting...

Kind regards,
Daniel


Stefan

unread,
Oct 4, 2022, 2:29:32 PM10/4/22
to TortoiseSVN-dev

-    //add sub menu to main context menu
-    //don't use InsertMenu because this will lead to multiple menu entries in the explorer file menu.
-    //see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for details of that.
+    // add sub menu to main context menu
+    // don't use InsertMenu because this will lead to multiple menu entries in the explorer file menu.
+    // see http://support.microsoft.com/default.aspx?scid=kb;en-us;214477 for details of that.
     MAKESTRING(IDS_MENUSUBMENU);
     if (!g_shellCache.HasShellMenuAccelerators())
     {
]]]


these were just formatting changes (clang-format). So I didn't check if the links are still valid.
 
I got curious and checked the link, but Microsoft seems to be deprecating old KB articles and I can't find the article on microsoft.com


Does it seem reasonable to update these kind of links to archive.org (or does someone else know where to find it on microsoft.com)? I can do it, time permitting...

I guess there are now quite a few dead links in the comments. But I don't think it's worth the time to go through all of them and try to update them.

Stefan
Reply all
Reply to author
Forward
0 new messages