[PATCH] Fix 'apr was not found' errors after upgrading from 1.13.1 to 1.14.0

[Denis Kovalchuk]

Hello.

After upgrading from 1.13.1 to 1.14.0, there is no TortoiseSVN context menu for

files and the following errors occur:

[[[

TortoiseProc.exe - System Error

The code execution cannot proceed because libapr_tsvn.dll was not found.

Reinstalling the program may fix this problem.

]]]

[[[

TortoiseProc.exe - System Error

The code execution cannot proceed because libaprutil_tsvn.dll was not found.

Reinstalling the program may fix this problem.

]]]

As far as I understand, the Windows Installer cannot properly install these apr

dlls, because they were downgraded in 1.14.0.

If I'm not mistaken, there is no easy way to use RemoveExistingProducts [1] to

fix this problem, because it's already used in TortoiseSVNOverlays merge module

that will lead to a duplicate id error. So, as a solution, I suggest explicitly

setting REINSTALLMODE [2] property to 'dmus' value.

I've attached a patch.

[1] https://docs.microsoft.com/en-us/windows/win32/msi/removeexistingproducts-action

[2] https://docs.microsoft.com/en-us/windows/win32/msi/reinstallmode

Thanks and regards,

Denis Kovalchuk

[Stefan]

Thanks!

Committed in r28894

[Danil Shopyrin]

Wondering if there are any plans to build the TortoiseSVN 1.14.1 soon?

It seems that this problem hurts a lot of users. So I think it makes sense to build the TortoiseSVN 1.14.1 without waiting for the SVN 1.14.1.

--

With best regards,

Danil Shopyrin

On Wednesday, June 3, 2020 at 8:09:24 PM UTC+3, Stefan wrote:

Thanks!

Committed in r28894

[sven.n...@gmail.com]

Yes, a new fixed release would be great. SVN 1.14 is new LTS version and there will be probably no fast 1.14.1 SVN update which will be followed by a fixed TortoiseSVN release build.