[PATCH] Fix for duplicated externals in Copy dialog
23 views
Skip to first unread message
Patrick Steinhardt
unread,
May 14, 2018, 6:03:10 AM5/14/18
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to tortois...@googlegroups.com
Hi,
When the registry key "HKCU\Software\TortoiseSVN\CommitReopen" is
set to "1", then the Copy dialog will reopen in case the commit
failed. If this happens and the repository contains externals,
then the list of externals will display all externals multiple
times, as the externals vector is not getting cleared before it's
being repopulated.
The attached patch fixes that by first clearing the externals
vector.
The issue was found in 1.9.7, but applies to 1.10.0 and trunk, as
well. It would be nice if it was applied to all three branches.