Nightlies build failure

15 views
Skip to first unread message

Daniel Sahlberg

unread,
Jul 10, 2022, 11:09:04 AM7/10/22
to TortoiseSVN-dev
Hi,

The nightly builds are currently failing with the following message:

[exec] C:\TSVN\tortoisesvn\ext\TortoisePlink\defs.h(22,1): fatal error C1189: #error: Do not compile this code base with NDEBUG defined! [C:\TSVN\tortoisesvn\ext\TortoisePlink\windows\TPlink\TortoisePlink.vcxproj] [exec] TortoisePlink.c

I believe this is caused by a change to defs.h in r29425 which adds a change from upstream (97f7a7cb4deacbc92a9dbdc1b9394e4e1358e47a) enforcing that NDEBUG is not defined.

As far as I can see this code was added upstream in PuTTY 0.75 (which was added to TSVN in r29211), but I assume that code was manually deleted from defs.h before committing r29211.

I don't know enough about NDEBUG to dare touching this part of the code. I guess we should either remove the #error from defs.h via TortoisePlink.patch or change something to not compile TortoisePlink with NDEBUG.

Kind regards,
Daniel

Reply all
Reply to author
Forward
0 new messages