pane-border-lines breaks arrow indicators

137 views
Skip to first unread message

Thomas Adam

unread,
Feb 4, 2022, 6:52:00 AM2/4/22
to tmux-...@googlegroups.com
Hello,

I was just looking at the pane-border-indicator setting, with the 'arrows'
options and noticed that despite valid UTF-8 characters being drawn for
pane-border-lines, the arrows only showed correctly when pane-border-lines was
set to 'single'.

Setting pane-border-lines to 'double', for example, rendered the lines in
UTF-8, but made the arrow indicators render using ACS equivalents.

I believe the following patch should fix this.

Kindly,
Thomas

diff --git a/screen-redraw.c b/screen-redraw.c
index 8dd75f40c..ef79d9aaa 100644
--- a/screen-redraw.c
+++ b/screen-redraw.c
@@ -727,8 +727,10 @@ screen_redraw_draw_borders_cell(struct screen_redraw_ctx *ctx, u_int i, u_int j)
border == SCREEN_REDRAW_BORDER_RIGHT) ||
(cell_type == CELL_RIGHTJOIN &&
border == SCREEN_REDRAW_BORDER_LEFT)))) &&
- screen_redraw_check_is(x, y, pane_status, active))
+ screen_redraw_check_is(x, y, pane_status, active)) {
+ gc.attr |= GRID_ATTR_CHARSET;
utf8_set(&gc.data, BORDER_MARKERS[border]);
+ }
}

tty_cell(tty, &gc, &grid_default_cell, NULL);

Nicholas Marriott

unread,
Feb 4, 2022, 6:57:46 AM2/4/22
to Thomas Adam, tmux-users
Great, applied, thanks




--
You received this message because you are subscribed to the Google Groups "tmux-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tmux-users+...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/tmux-users/20220204115150.h27bwjxbrrg2dogx%40moo.
Reply all
Reply to author
Forward
0 new messages