First call for planned release of v5.1.20

[Jeremy Ruston]

I’d like to try to get v5.1.20 released in the next week or two. With that in mind, I’d be grateful for assistance in testing and verifying the latest build:

https://tiddlywiki.com/prerelease/

In particular, this is a great time for plugin developers/users to test the new release with important plugins and let us know if there are any backwards compatibility issues. 

Even by TW5 standards, it’s been a long delay since the last release in December. That’s entirely my fault, but I’d like to try to avoid delaying the release with any further pull requests. Having said that, if you’re responsible for any unmerged PRs that you believe are ready to be merged then please do let me know.

Best wishes

Jeremy.

[@TiddlyTweeter]

IMO December to June is FINE.

Its more for me about just checking for backwards compatibility on my fav plugins. Usually everything works. If they don't I'll say. I never needed to yet.

I guess as the system gets more complex chances of breakdown increase?

A view

Josiah

[MidnightLightning]

Thanks Jeremy!

My pull request (https://github.com/Jermolene/TiddlyWiki5/pull/3876) for changing the Markdown plugin to use the Remarkable rendering library has been hanging out there for a while now, and I think it only needs a final ACK? I noticed pull request #3271 is also with regard to the Markdown renderer (and I think switching to the Remarkable library handles that use case too). Could this be considered for the upgrade? Or what else should be done there to make it ready?

[bimlas]

Maybe it's just the plugin's fault, but it seems that for some reason the Kin filter is slower on prerelease (heavily using cache mechanism). I don't know if it's a new indexing system or a performance log issue.

The code of the filter: https://github.com/bimlas/tw5-kin-filter/blob/66e2cbbf85761daa4c33e9c422db0fce3b6ea6f9/plugins/kin-filter/kin.js

Steps of testing:

• Download current and prerelease
• Install Kin filter from https://bimlas.gitlab.io/tw5-kin-filter/
• Enable performance instrumentation
• Save and reload wikis
• Close all opened tiddlers and open "Open" sidebar
• Open Developer Tools Console
• Use "[kin::to[TableOfContents]]" filter in Advanced Search

Results for me on Windows:

• Chrome 75.0.3770.90
• Current:
• mainRefresh: 861.93ms 
• +filter: 691.76ms
• Prerelease
• mainRefresh: 1317.06ms 
• (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; avgTime 331.36000000013155; totalTime 994.0800000003946; percentTime 78.02397042426841
  
• Firefox 67.0.2
• Current
• mainRefresh: 890.00ms
• +filter: 657.00ms 
• Prerelease
• mainRefresh: 1108.00ms 
  
• (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; avgTime 270; totalTime 810; percentTime 71.87222715173026

[Jeremy Ruston]

Hi Bimlas

Thanks for the report, that’s very helpful.

There’s quite a lot that’s changed between v5.1.19 and the current prerelease, not just the indexing. One quick thing to try might be to make some more timings while manually enabling and disabling the indexing mechanism in the prerelease.

The easiest way to disable the indexing is to overwrite the following two tiddlers with new tiddlers that don’t have a module-type field:

$:/core/modules/indexers/field-indexer.js
$:/core/modules/indexers/tag-indexer.js

Then we’d be able to compare three timings:

* v5.1.19

* v5.1.20-prerelease (including indexing)
* v5.1.20-prerelease (without indexing)

Many thanks,

Jeremy.

--
You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikide...@googlegroups.com.
To post to this group, send email to tiddly...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/f549acfa-fc56-4826-9d7a-bac9bd63aa93%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[bimlas]

The results of the first two case are above, so I just doing the test again on prerelease with disabled indexing:

• Chrome:
• Prerelease
• mainRefresh: 1206.61ms
• (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; avgTime 300.8199999991727; totalTime 902.459999997518; percentTime 82.29843968466753
  
• Firefox
• Prerelease
• mainRefresh: 1141.00ms
• (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; avgTime 275; totalTime 825; percentTime 47.79837775202781
  

The results of Firefox are almost the same, but percentTime differs a much! Tried to run the filter again multiple times (indexing still disabled):

• Chrome:
• Prerelease
• mainRefresh: 1285.50ms 
• (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 15; avgTime 523.3866666669201; totalTime 7850.800000003801; percentTime 88.23785602723082
  
• Firefox
• Prerelease
• mainRefresh: 1078.00ms
• (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 15; avgTime 376.93333333333334; totalTime 5654; percentTime 81.83528730641193

2019. június 18., kedd 10:59:26 UTC+2 időpontban Jeremy Ruston a következőt írta:

Hi Bimlas

Thanks for the report, that’s very helpful.

There’s quite a lot that’s changed between v5.1.19 and the current prerelease, not just the indexing. One quick thing to try might be to make some more timings while manually enabling and disabling the indexing mechanism in the prerelease.

The easiest way to disable the indexing is to overwrite the following two tiddlers with new tiddlers that don’t have a module-type field:

$:/core/modules/indexers/field-indexer.js
$:/core/modules/indexers/tag-indexer.js

Then we’d be able to compare three timings:

* v5.1.19

* v5.1.20-prerelease (including indexing)
* v5.1.20-prerelease (without indexing)

Many thanks,

Jeremy.

To unsubscribe from this group and stop receiving emails from it, send an email to tiddly...@googlegroups.com.

[Jeremy Ruston]

Hi Bimlas

Thanks, that’s very helpful. This may get quite involved so I’ve created a GitHub ticket for further discussion:

https://github.com/Jermolene/TiddlyWiki5/issues/3998

Best wishes

Jeremy

To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikide...@googlegroups.com.

To post to this group, send email to tiddly...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/9f1ddb56-9ca6-4133-9e64-c8625036ae32%40googlegroups.com.

[bimlas]

I'm very sorry, but it was a false alarm, see https://github.com/Jermolene/TiddlyWiki5/issues/3998#issuecomment-503312664

[TonyM]

Jeremy,

[Edited] Added join

I wish to contribute directly to this release and have being involved in many discussions. 

However when I am on https://tiddlywiki.com/prerelease/# I cant get the

"Can you help us improve this documentation? Find out how to edit this tiddler on GitHub"

to work.

In this case I am contributing to the documentation that will appear on tiddlywiki.com when the release is made.

But how would I contribute a change to the release itself?

One example may be the observation that the following tiddlers should be tagged with  [[String Operators]]

[[join Operator]]
lowercase
split
splitregexp
trim
uppercase

join

I have being installing items on the pre-release, and testing new features and more with no issues so far.

Regards

Tony

[Mat]

Tony

However when I am on https://tiddlywiki.com/prerelease/# I cant get the

"Can you help us improve this documentation? Find out how to edit this tiddler on GitHub"

to work.

What happens when you click the "this tiddler on GitHub" link? You should come to the gh editor showing that tiddler.

<:-)

[Mat]

TonyM wrote:

In this case I am contributing to the documentation that will appear on tiddlywiki.com when the release is made.

But how would I contribute a change to the release itself?

Unless I misunderstand something basic; You can only contribute to the prerelease edition. Once Big J makes the actual release, that is what replaces what is on tiddlywiki.com.  

<:-)

[Jeremy Ruston]

Hi Mat

Unless I misunderstand something basic; You can only contribute to the prerelease edition. Once Big J makes the actual release, that is what replaces what is on tiddlywiki.com.  

You can contribute to the prerelease by sending a pull request to the “master” branch. To contribute docs changes to the current release the pull request needs to be sent to the “tiddlywiki-com” branch.

Best wishes

Jeremy

<:-)

--
You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikide...@googlegroups.com.
To post to this group, send email to tiddly...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/80ae7e34-17d2-4b5e-ae26-53ed58fe3931%40googlegroups.com.

[TonyM]

Mat,

What happens when you click the "this tiddler on GitHub" link? You should come to the gh editor showing that tiddler.

For example here https://tiddlywiki.com/prerelease/#untrunc%20Operator 

I Edit the tiddler then "this tiddler on GitHub" I get a 404 Error

Regards

Tony

[Mat]

Jeremy Ruston wrote:

You can contribute to the prerelease by sending a pull request to the “master” branch. To contribute docs changes to the current release the pull request needs to be sent to the “tiddlywiki-com” branch.

I did not know this - but in that case, couldn't the "Edit this tidder on GitHub"-link automatically link/lead to the correct one?

<:-)

[Mat]

TonyM wrote:

I Edit the tiddler then "this tiddler on GitHub" I get a 404 Error

That's strange. Just as an experiment, here's a direct link to HelloThere on gh, i.e as accessed when I clicked on "edit this tiddler on gh.."

Just a note: It is not meaningful to edit it while on the tiddlywiki server as it will not transfer. What happens when the link works is you see the raw (rather hard to read) tiddler there where you must make your changes.

<:-)

[Mohammad]

Hi Jeremy,

It was a request from users to improve the TOC macro.

I wish to have the exclude parameter working in 5.1.20

The PR was by PMario here: https://github.com/Jermolene/TiddlyWiki5/pull/3975

--Mohammad

[Jeremy Ruston]

Hi Mat

The “edit this tiddler” links default to making a PR on the tiddlywiki-com branch. That’s what’s needed for simple, immediate documentation updates that aren’t tied to the next release. Documentation for the next release should target the “master” branch, which you’ll need to manually change if using the “edit this tiddler” links.

Best wishes

Jeremy