Building TiddlyDesktop from source, symbolic link broken

[okido]

Hello Jeremy,

I tried to build TiddlyDesktop from source.

The build is made but it has a broken symbolic link to Tiddlywiki5 code.

My proposal is to build it with the TW5 code included, like: cp -RH source/* output/linux64/TiddlyDesktop-linux64-v0.0.13 in bld.sh

Have a nice day, Okido

[Jeremy Ruston]

Hi Okido

I tried to build TiddlyDesktop from source.

Great, any feedback to make the process better for others is gratefully received.

The build is made but it has a broken symbolic link to Tiddlywiki5 code.

I'm not sure what you mean. The scripts expect to find the TiddlyWiki5 repo in a sibling directory; are you suggesting we use a symlink instead?

My proposal is to build it with the TW5 code included, like: cp -RH source/* output/linux64/TiddlyDesktop-linux64-v0.0.13 in bld.sh

Do you mean that the TiddlyDesktop repo should contain a snapshot of the TW5 code?

Best wishes

Jeremy

Have a nice day, Okido

--
You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikide...@googlegroups.com.
To post to this group, send email to tiddly...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/8a25a259-3427-4539-bc04-e6e304b18459%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[okido]

Hello Jeremy,

I'm not sure what you mean. The scripts expect to find the TiddlyWiki5 repo in a sibling directory; are you suggesting we use a symlink instead?

In bld.sh the TiddlyWiki5 repo in the sibling directory is cp with npm install ../TiddlyWiki5, this creates a symbolic link.

This symbolic link is than cp to source/tiddlywiki, this is still OK.

Than the symbolic link in source/tiddlywiki is cp with -R source/* output/linux64/TiddlyDesktop-linux64-v0.0.13, here the link is broken, hence cp with -RH command to preserve the code.

You need to preserve the code if you move the build around.

Hope this makes it clear.

There is a small typo in the image that is used to show on the panel, the name is app-icon.png, in the the code it is used as app_icon.png, this results in a grey smudge instead of the black cat on yellow background.

[Jeremy Ruston]

Hi Okido

Ah, many thanks, that’s very helpful — I had no idea that “npm install” would make a symbolic link in these circumstances.

I’ve made a couple of fixes:

https://github.com/Jermolene/TiddlyDesktop/commit/ffd0c7be4d4220a67211e3b18ece208d11d305e4

https://github.com/Jermolene/TiddlyDesktop/commit/6e79c03fdc3d9be679f67048f2ccec4114161f51

Many thanks for your help,

Best wishes

Jeremy

--
You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikide...@googlegroups.com.
To post to this group, send email to tiddly...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/ee263fd0-26ff-4012-8ea0-af5e4e8fde97%40googlegroups.com.

[okido]

Thanks, builds OK now.