Cool stuff, simple, useful, Andrew.
Some feedback:
1) I'd expect the star button to be a toggle;changing it's style when the tiddler is a favourite, e.g. to yellow.
2) To keep the tabs bar short, I'd...
- make it the first tab
- actually name it ★
3) I'd possibly place the button somewhere else, too, to not overcrowd the toolbar.
But that's just me... e.g. the bottom right of a tiddler, or actually in front of the title.
I think he does not have control over the tab order…
While I agree that the toolbar gets too crowded, I think this is a general TW problem and imo it is good if he follows the conventions of placing stuff like this in the toolbar – I would expect it there.
Thank you both for feedback. I have placed the favorites tab in front of the others and named it with the star icon and gave it a tooltip of favorites. Thank you again for your feedback.
--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/9958109b-c116-4d5f-8972-0615d272f70c%40googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/CAL0r7zt%2B60_zovoHVFK9biOYLmLadV%2BTqVSFxBFXX8oakwB3BA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/CALc1hYfxiUrD%2BQVnrT0BfkA8ZiZmHc4r4f0p6U8V4%3DrgpBzO3w%40mail.gmail.com.
<$button>
<$action-listops $tiddler="MyData" $field="my-favourites" $subfilter="[{!!title}]"/>
Add Me to Favourites
</$button><$button>
<$action-listops $tiddler="MyData" $field="my-favourites" $subfilter="-[{!!title}]"/>
Remove Me to Favourites
</$button><$list filter="[list[MyData!!my-favourites]]" variable="favourite">
* <$link><<favourite>></$link></$list>title: $://ui/Buttons/favoritetags: [[$:/tags/ViewToolbar]]
\define add() [[$(currentTiddler)$]]\define remove() -[[$(currentTiddler)$]]
<$list filter="[list[Favorites]is[current]]"><$button class=<<tv-config-toolbar-class>>><$action-listops $tiddler="Favorites" $field="list" $subfilter=<<remove>>/><span style="color:orange;">★</span></$button></$list><$list filter="[all[current]!list[Favorites]]"><$button class=<<tv-config-toolbar-class>>><$action-listops $tiddler="Favorites" $field="list" $subfilter=<<add>>/><span style="color:#ccc;">★</span></$button></$list>title: Favorites
{{{ [list[]] }}}
{{{ [list[Favorites]] }}}--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/237bc1e7-be49-4dcd-8aed-abd970c6037a%40googlegroups.com.
Ok, introducing miner upgrade to 3.0.1. Please forgive me if this is upsetting. Please note the following warning and I hope I don't make any more huge mistakes. Keep in mind this is a community plugin and not a part of the core plugin library...yet.
Thank you for all your valuable advice @tobias.
Ok, introducing miner upgrade to 3.0.1. Please forgive me if this is upsetting. Please note the following warning and I hope I don't make any more huge mistakes. Keep in mind this is a community plugin and not a part of the core plugin library...yet.
Warning!!! Upgrading from prior to version 3.0.1 will delete all previous favorites so take note of favorites before upgrading so you can reselect them after upgrading. This will not be a problem after version 3.0.1. Again, upgrading to version 3.0.1 or later from a previous version before 3.0.1 will loose all favorites. Thank you for your forgiveness.Happy Connecting. Sent from my Sprint Samsung Galaxy S® 5
-------- Original message --------
From: Tobias Beer <beert...@gmail.com>
Date: 01/27/2016 9:33 AM (GMT-07:00)
To: TiddlyWiki <tiddl...@googlegroups.com>
Subject: Re: [tw] Re: [TW5] FavoritesHi Andrew,--One bit of advise, although, again mildly breaking backwards compatibility — which could be remedied with a simple "migrate" button or instructions that say "please copy the list from A to B" — I would not store the actual favorites at the list field of the template tiddler. I'd rather put it into a tiddler of its own with the entire purpose of storing the Favorites list, e.g.:$:/plugin/ajh/favorites/listBest wishes,Tobias.
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/d45be0a5-f588-4522-87ef-2c01ad97be78%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.