Temporary removal of savetiddlers

99 views
Skip to first unread message

BJ

unread,
Nov 15, 2017, 7:45:05 AM11/15/17
to TiddlyWiki

Unfortunately there cannot be two saver extensions both pretending to be tiddlyfox (that is listening to save messages posted by the TiddlyFoxSaver inside tiddlywiki) at the same time. I have removed the software until I have some method of handling this situation.

BJ

PMario

unread,
Nov 15, 2017, 8:00:59 AM11/15/17
to TiddlyWiki
On Wednesday, November 15, 2017 at 1:45:05 PM UTC+1, BJ wrote:

Unfortunately there cannot be two saver extensions both pretending to be tiddlyfox (that is listening to save messages posted by the TiddlyFoxSaver inside tiddlywiki) at the same time. I have removed the software until I have some method of handling this situation.

BJ

IMO there is no need to install 2 extensions, that do the same thing, at the same time.
But IMO there is a need of choice for our users.

-m

BJ

unread,
Nov 15, 2017, 9:05:43 AM11/15/17
to TiddlyWiki
I totally agree that choice is a good thing.
Although there is no need to install both extensions, there is no way to stop it. It is just a matter of how the extensions indicate (to each other) that they are installed. It is not a problem I had thought about, but you cannot sensibly have two extension both trying to save the same tiddlywiki.

PMario

unread,
Nov 15, 2017, 9:51:47 AM11/15/17
to TiddlyWiki
On Wednesday, November 15, 2017 at 3:05:43 PM UTC+1, BJ wrote:
... but you cannot sensibly have two extension both trying to save the same tiddlywiki.

You are right. ... Not at the same time :) ... or may be even this may make sense for some users.

There are some mechanisms, for extensions to detect each other. We could use this one.

------------ Some more thougts.

It's also possible, that a page detects extensions ..

IMO we can improve the TW messaging system. So the user may be able to decide, on a per TW basis, which backend to use as a saver.
Or even on the button level.

I did send a PR to the TiddlyWiki repo, that should already improve the communication between the user and the TiddlyFox saver, because it can hand down an eg: backup-folder parameter. Which would give the user a much more fine grained controll over the backup strategy. ..

At the moment the AddOn needs to manage this info, which imo is an overhead, that I actually don't want to deal with. The only thing an AddOn should do, is provide sensible defaults. .. The user should be able to use an AddOn out of the box, without any adjustments.

Same thing with "backupsEnabled" .... IMO it would be nice, if the TW / User has the final decision on a per TW basis.

At the moment my addOn needs to manage a list of files, and store information about these files in the local storage. That's ok, but the file names are not really unique. So settings are lost, if a file name changes. .. If the TW file will carry those settings with them, they could overrule the default settings. Which imo would be a much nicer UX.

just some thoughts.
mario

BJ

unread,
Nov 15, 2017, 10:19:26 AM11/15/17
to tiddl...@googlegroups.com
We could use managment api, but then we would have to embed details about each other extensions in our own, also if some new extension apprears, we would need to change our software.

It would be very easy to just add the name of the extension to the messageBox, eg.

messageBox.setAttribute("data-saver-is","savingtiddlers")

This way I don't care what any extension is called, only that some other extension is using the message box.

PMario

unread,
Nov 15, 2017, 11:02:31 AM11/15/17
to TiddlyWiki
On Wednesday, November 15, 2017 at 4:19:26 PM UTC+1, BJ wrote:
messageBox.setAttribute("data-saver-is","savingtiddlers")

This way I don't care what any extension is called, only that some other extension is using the message box.

hihi: https://github.com/pmario/file-backups/issues/1#issuecomment-344632934  Yea, we seem to come to the same conclusion.

I did suggest
messageBox.setAttribute("data-tiddlyfox-creator", "<your-addon-name>")

So may be data-message-box-creator would be the truth.


-m

BJ

unread,
Nov 15, 2017, 11:38:41 AM11/15/17
to TiddlyWiki
that would be fine.

Mark S.

unread,
Nov 15, 2017, 11:39:35 AM11/15/17
to TiddlyWiki
Wouldn't it be better to just post a warning in 72 point font ? Or, if you are withdrawing because of Mario's solution, post a link on your page to Mario?

The thing is, your's is the only stand-alone solution (other than default save)  for FF57 currently published at TiddlyWiki.com. Removing your solution now means that people coming to TiddlyWiki.com are going to be lead to a dead-end immediately. Those same people won't know about Mario's solution since it wasn't part of the 5.1.15 release.

-- Mark

BJ

unread,
Nov 15, 2017, 12:17:41 PM11/15/17
to tiddl...@googlegroups.com
Sorry I was not very clear, the problem is having two savers installed at the same time. Tiddlywiki was designed to only work with one saver - tiddlyfox.

The problem is (was) having no method to find out that there was another saver - which means that every time you save there would be a random behavior, potentially one time one saver would act, then 2 minutes later the other... chaos! This would be worse than no savers, a fatal error.
we just need to agree on how to indicate that a saver is installed and I will make a new version.

Reply all
Reply to author
Forward
0 new messages