Prerelease Comments plugin Style suggestion

[David Gifford]

Hi all

I tweaked the stylesheet for the Comments plugin found in the pre-release. I think this look conforms more closely to the TiddlyWiki aesthetic and would be a better default look. Feedback?

Also, I am not a fan of GitHub - maybe someone would like to push these suggestions there?

Here are the results:

http://giffmex.org/experiments/prerelease.tweaks.html

The two tweaked tiddlers are $:/plugins/tiddlywiki/comments/styles and
$:/plugins/tiddlywiki/comments/toolbar-button-edit

[Mohammad]

Hi David!

 Yes, I think the color and style of comment plugin is not consistent with Vanilla theme and the simple look of empty TW.

-Mohammad

[Jeremy Ruston]

Hi Dave

That’s great. My first thought is that it might be nice if the comment plugin was themable.

I’ve no objection to changing the default styling, but I think our objectives might be contradictory here. I intentionally made the “add comment” button green, a  colour that isn’t part of the default TW5 palette, rather than reusing the standard “blue” primary colour, so that the comment machinery would stand out. I suspect that your changes are trying to stop them standing out. Similarly, I used a faint background colour for the comments to intentionally differentiate them from the tiddlers to which they are attached. So I think these two themes might serve different purposes.

Best wishes

Jeremy.

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/ce81cf71-5802-4365-a51e-90ef545e884e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[@TiddlyTweeter]

Jeremy Ruston wrote:

... My first thought is that it might be nice if the comment plugin was themable.

... I intentionally made the “add comment” button green, a  colour that isn’t part of the default TW5 palette, rather than reusing the standard “blue” primary colour, so that the comment machinery would stand out.

 
That looks right to me as a general approach to comments, that they can be themed differently. At the same time I understand David's impulse to want something conformant with a base aesthetic.

So long as one can theme as needed I think the issue disappears.

Best wishes
Josiah

[David Gifford]

Hi Jeremy

Yes I figured that those were your reasons for making the styling choices you did.

My answer: I think there is a distinction between making something stand out within a color scheme, and making something clash with that color scheme.

I have made another example, this time with a more intense blue to make it pop a little more, and with shading in the background of the comments to make them more distinct. I think this might answer your concerns, while also making it look less jarring than the colors at the official prerelease.

Compare http://giffmex.org/experiments/prerelease.tweaks2.html with my previous http://giffmex.org/experiments/prerelease.tweaks.html

What do you think?

[Julio Peña]

Hello David and all,

Pardon the intrusion...I see very much Jeremy's point regarding the choice he made. 

However, I'm also in accord with David on the above statement. 

@David, that second example looks spot on. ;)

Regards and blessings to all,

Julio