I can't deactivate Tablinks (Firefox version)

[pedruchini]

Hi everyone.
I'm using the Firefox version of Tablinks. It works perfectly except that I cannot deactivate the plugin in the control panel. This happens on my local TW, but also in Mat's http://tablinks-ff.tiddlyspot.com/#On%2FOff when using Firefox. I don't have this problem with the Chrome version. Can Mat or somebody else help me. 
Thanks in advance.
Pedro

[Birthe C]

in Firefox 57.2 on Windows 7 on the link to Mats tablinks I can disable the plugin or toggle the tab links not to show.  Is that what you mean?


Birthe

[Pedruchini]

Birthe,
Thanks for your quick answer. I tried Firefox 57 and Firefox ESR on Windows and an old version with Tiddlyfox on Lubuntu (linux) with no success. A few minutes ago I tried the following (also with no success):

1) Saved http://tablinks-ff.tiddlyspot.com/ (the plugin version for Firefox) to my computer. Clicked on the tab On/Off, and on the toggle button, I click on and off, but in both cases nothing happens (the plugin is active and I can't disable it).

2) I did the same with http://tablinks.tiddlyspot.com/ (the plugin version for Chrome) and it worked (I can disable the plugin).

I wonder what am I doing wrong.

I know there is also Mario's https://wikilabs.github.io/editions/link-to-tabs/ but it's not exactly the same.

[Mat]

pedruchini - I am afraid I don't have time just now and only possibly tomorrow but if you don't solve it yourself I promise to help you out within the next few days. (I rarely make such explicit promises.)

A quick guess, without having looked at the code, might be that the $:/tags/Stylesheet tag is [supposed to be] toggled by the button, .i.e for the stylesheet tiddler that I assume exists. I don't remember, but that's a guess.

Ok, gotta go for now.

<:-)

[Birthe C]

Hi Mat,

You are toggling the value of the field display in the stylesheet tiddler. That value is not transcluded in the stylesheet. I tried  that, but that does not make it either. I think the $:/tags/Stylesheet tag must be toggled, but have not tested it. Windows and Firefox is a slooow combination on my computer. In fact Xmastiddle promised me I would not touch Windows for a couple of days. ;-)

@pedruchini
I am very sorry, I was wrong it does not work as is. It was only my computer being slow, that made it look that way.

Birthe

[pedruchini]

Mat,

If you are busy these days, forget about this. This is not urgent. I can use the Chrome version with Chrome and BJ's SaveTiddlers. Thank you for this wonderful plugin.

[Birthe C]

Hi pedruchini,

Maybe you would like to test if I am still wrong http://pirat.tiddlyspot.com/


Birthe

[pedruchini]

Birthe

Yes, you're right. It works. But... watch this video I recorded with my voice : https://archive.org/download/chirifuvid/tablinks-test.mp4

[Birthe C]

Hi Pedruchini.

Well done and very clear. What you describe is also what I eventually discovered. The only diffent thing I did in the TW I uploaded is in the stylesheet. The tablinks are toggled with a field in the stylesheet. The reason it did not work in Firefox was that that field was not transcluded..

With that stylesheet it works for me on Linux Mint 17.3 Mate 32 bit and Firefox (and on Windows 7 and Firefox). The chrome version toggle button does not look like the buttons in Firefox, but not like yours - that is strange.

Thank you for taking the time to record the video and explain,

Birthe

[pedruchini]

 

 I changed the stylesheet and.... Problem solved !

Thanks a lot for the help.

Pedro

[Mat]

 watch this video I recorded with my voice : https://archive.org/download/chirifuvid/tablinks-test.mp4

Hi again Pedruchini. Good video showing the issue. Actually, I don't think I made that Pirat site, at least I can't remember it. But if that works in FF, then what is the problem? Or did you get your tablinks plugin from tablinks-ff.tiddlyspot.com ? Do you still need help or can you not simply use the Pirat version?

<:-)

[Birthe C]

Hi Mat,

I'm to blame for the pirate site, that is why I called it pirate, tablinks is totally yours and I love it.

Birthe

[Mat]

On Saturday, December 23, 2017 at 3:42:45 PM UTC+1, Birthe C wrote:

Hi Mat,

I'm to blame for the pirate site, that is why I called it pirate, tablinks is totally yours and I love it.

Well, clearly good that you did then.

But did you make any code changes or do you know why/how it works without problems for pedruchini (...or maybe for everyone, I didn't try it)?

<:-)

[Birthe C]

Only a very small change in the stylesheet to transclude the value of field "display". By the way it works for me in Chromium also.

pedruchini wrote above, that problem was solved by changing the  stylesheet.

Birthe

[Mat]

Birthe, so if I merely copy your Pirat version to tablinks-ff.tiddlyspot.com - will everything be alright then for others who get it there? Is it OK that I do this, obviously pointing out that you helped?

<:-)

[Birthe C]

Hi Mat,

Ofcourse, I did it trying to help in this busiest of times ;-). You only need the stylesheet. I think it should work, but I do not know of anyone else testing it. You do not need to point anything out, I just did what you had yourself described in the readme.

Merry Christmas...and thanks for all your goodies.
Birthe

[pedruchini]

Hi Mat,

I can confirm that your plugin works now with the change made by Birthe in the stylesheet.

Pedro