[5.1.23] Text alignment issue in More Actions menu

[Hubert]

Hi All,

I've noticed that the word "Delete" looks as if it had a negative "margin-left" value or there was some other alignment issue (screenshot below).

Before altering a shadow tiddler in my own wiki, I've decided to report it to the Group because the issue can be replicated on TiddlyWiki.com using 5.1.23 (the alignment was correct in 5.1.22), so it appears it's not just me :)

My own wiki:

[Hubert]

Apologies, it looks like the screenshots did not load. Trying again:

[Eric Shulman]

On Friday, 25 December 2020 at 20:21:17 UTC Hubert wrote:

I've noticed that the word "Delete" looks as if it had a negative "margin-left" value or there was some other alignment issue (screenshot below).

I see the same issue (using Chrome on Win10). 

After examining the $:/core/ui/Buttons/* shadow definitions, I note that some (but not all) have <$text text=" "/> preceding the button caption text.  This includes edit, clone, permalink, permaview, open-window, close-others, fold-others, and fold.  However, in contrast, the close, info, new-here, new-journal, and export-tiddler buttons do not have this explicit space preceding their caption text, but still seem to display properly.

Following this pattern, the fix would be to add <$text text=" "/> to the delete button definition.

-e

[PMario]

On Friday, December 25, 2020 at 10:18:22 PM UTC+1 Eric Shulman wrote:

Following this pattern, the fix would be to add <$text text=" "/> to the delete button definition.

That's only partially right. It's a workaround.

Since the development of 5.1.23 we did remove a lot of "hardcoded spaces" and replaced them by proper CSS settings. So the suggested solution is: completely remove that space, because it only wastes processor cycles and add some CSS that should be working with every view.

-m

[PMario]

Hi, I did create an issue at GitHub https://github.com/Jermolene/TiddlyWiki5/issues/5319

-m