Package Proposal - JSON Schema Validator

[Matthew Allan]

Hi everyone,

I wrote a package to validate http://json-schema.org/ schemas.  If you aren't familiar with JSON Schema, a good overview is this article.

Github link

Docs

The package adheres to all of the league quality guidelines and I wrote full documentation.  I've been waiting to tag a stable release until I figure out where the package is going to go.  If the league accepts the package I will come up with a better name. :)

There is one other package that does the same thing, https://github.com/justinrainbow/json-schema.  These are the big improvements of this package:

- Passes the entire test suite for Draft 4 of the schema.  The existing package skips a lot of the tests.

- Fully supports circular references.  The existing package prevents recursion when it should be allowed.

- Allows extending the validator with custom formats.

- Provides detailed error messages a JSON pointer and unique error code.  The existing package just returns the property name and a message.

I wrote this package after spending six months working with the existing package at work and constantly being frustrated.  I would have tried to fix the existing package but the changes were significant enough to merit a rewrite, and the existing package's code was really hard to read IMO.  The reference resolving approach is completely different in order to accomplish the improvements mentioned earlier.

Thanks!

- Matt

[Ben Ramsey]

I support accepting this as a league package.

-Ben

--
You received this message because you are subscribed to the Google Groups "thephpleague" group.
To unsubscribe from this group and stop receiving emails from it, send an email to thephpleague...@googlegroups.com.
To post to this group, send email to thephp...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/thephpleague/443f0b5e-b6c8-487d-bb30-3cc2a7ecc9dd%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Jonathan Reinink]

Yes, same, looks awesome!

To view this discussion on the web visit https://groups.google.com/d/msgid/thephpleague/CAJOjSBhTHT0KTQ44MErrqK_ywaJs3S_vf-pjEQwwOjn_WWrg8A%40mail.gmail.com.

[Woody Gilk]

Excellent introduction to the package and good job doing the due diligence regarding comparing to existing packages! 

I support accepting this package, but would like to see some additional polishing done on it before version 1.0 final. I would suggest accepting it as a version 0.x to allow some method renames and improvements to the code style.

[Matthew Allan]

Hi everyone,

Thanks for the feedback.  Waiting to tag a stable release is fine with me.  I have some things I would like to clean up but the public interface should stay pretty stable.

Definitely let me know if there are specific improvements you would like to see to the code.  You can reach me here, and I'm also in the apisyouwonthate slack as @matthew-james.

Thanks!

- Matt

[Matthew Allan]

Hi League,

I've been busy but I got a lot of refactoring done.  The package moved to https://github.com/yuloh/json-guard and I tagged version 0.1.0. I am 95% happy with it but I'm not ready to tag a stable release yet.

Can we go ahead and move this to the league as a work in progress 0.x package?  What do I need to do?

Thanks!

Matt

[Barry vd. Heuvel]

Hey all,

It seems that a v2 of justinrainbow/json-schema is released, with support for draf4 and changed the way it handles references. I don't know if that fixes the biggest issues you had with the other library?

https://github.com/justinrainbow/json-schema/releases/tag/2.0.0

Barry

Op vrijdag 22 april 2016 20:21:41 UTC+2 schreef Matthew Allan:

[Frank de Jonge]

I like what I'm seeing here. I'm calling an acceptance vote. I'll get back to you when we have the result.

Op vrijdag 22 april 2016 20:21:41 UTC+2 schreef Matthew Allan:

Hi League,

[Frank de Jonge]

Hi Matt,

I'm pleased to be able to tell your package has been accepted. I'll be helping with the transition. Can you email me at info [at] frankdejonge.nl so we can get the transition started?

Op zondag 1 mei 2016 11:43:07 UTC+2 schreef Frank de Jonge: