Opened pull request to re-enable instantiation of reporters with specified parameters

[Scott Babcock]

https://github.com/cbeust/testng/pull/2303

Since XMLReporter was refactored, it's been impossible to instantiate this reporter with a ReporterConfig object with specified parameters injected. The aforementioned PR resolves this issue.

[⇜Krishnan Mahadevan⇝]

Scott,

I think its already supported in TestNG.

Please take a look at https://testng.org/doc/documentation-main.html#logging-xml-reports

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribblings @ https://rationaleemotions.com/

On Fri, May 8, 2020 at 12:05 PM Scott Babcock <sco...@gmail.com> wrote:

https://github.com/cbeust/testng/pull/2303

Since XMLReporter was refactored, it's been impossible to instantiate this reporter with a ReporterConfig object with specified parameters injected. The aforementioned PR resolves this issue.

--
You received this message because you are subscribed to the Google Groups "testng-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/testng-dev/46c68741-3e4d-46d5-ba59-f4f94c3b94b3%40googlegroups.com.

[Julien Herr]

Krishnan,

Check the PR:

The reporter is considered as a POJO when the configuration is applied but a previous refactoring moved all setters in an external class.

The PR is adding the support of reporters with external configuration and restore the documented behavior.

To view this discussion on the web visit https://groups.google.com/d/msgid/testng-dev/CANikZLkQ1vAm1pWxMT0zBXk-bbWV3eFouv6L0O7Wcu9%3DJwFbRg%40mail.gmail.com.

[Krishnan Mahadevan]

Julien,

 

Thanks for calling that out. Yes, now I realize that the PR was attempting at fixing the broken functionality.

 

 

Thanks & Regards

Krishnan Mahadevan

 

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"

My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribbings @ http://rationaleemotions.com/

To view this discussion on the web visit https://groups.google.com/d/msgid/testng-dev/CAPETcL079%2BkBp%2B9kL2MSvqyrSCfFXXZ%3DE%3Dk5mpmFE%3D7aqSO1Sw%40mail.gmail.com.