Hello,
syzbot found the following issue on:
HEAD commit: 666539eecdf4 Merge tag 'assoc-array-fixes-v2'
git tree: upstream
console output:
https://syzkaller.appspot.com/x/log.txt?x=127b43a1580000
kernel config:
https://syzkaller.appspot.com/x/.config?x=b949a9d3c1d44ceb
dashboard link:
https://syzkaller.appspot.com/bug?extid=70e7520e4a7d94c17113
compiler: Debian clang version 22.1.8 (1~deb13u4), Debian LLD 22.1.8
CC: [
linux-...@vger.kernel.org linux-tra...@vger.kernel.org mathieu....@efficios.com mhir...@kernel.org ros...@goodmis.org vdonn...@google.com]
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image:
https://storage.googleapis.com/syzbot-assets/a943b9915869/disk-666539ee.raw.xz
vmlinux:
https://storage.googleapis.com/syzbot-assets/9bfd839d7ea5/vmlinux-666539ee.xz
kernel image:
https://storage.googleapis.com/syzbot-assets/0f20b9720a71/bzImage-666539ee.xz
AI-generated root cause summary:
In kernel/trace/ring_buffer.c, ring_buffer_unlock_commit() calls rb_wakeups()
after rb_commit() has decremented cpu_buffer->committing to 0, with interrupts
still enabled on the local CPU. Inside rb_wakeups(), cpu_buffer->commit_page is
read without READ_ONCE() to compare against cpu_buffer->reader_page. An
interrupt on the same CPU (e.g., perf hrtimer running a BPF program calling
bpf_trace_printk()) can re-enter the ring buffer via a different interrupt
context bit in trace_recursive_lock(), acquire committing == 1, and advance
cpu_buffer->commit_page via rb_move_tail() -> rb_end_commit() ->
rb_set_commit_to_write() -> rb_inc_page() without WRITE_ONCE(), causing a KCSAN
data race.
full analysis:
https://syzkaller.appspot.com/x/ai_root_cause?x=70e7520e4a7d94c17113
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by:
syzbot+70e752...@syzkaller.appspotmail.com
==================================================================
BUG: KCSAN: data-race in rb_move_tail / ring_buffer_unlock_commit
read-write to 0xffff88810007a860 of 8 bytes by interrupt on cpu 0:
rb_inc_page kernel/trace/ring_buffer.c:1471 [inline]
rb_set_commit_to_write kernel/trace/ring_buffer.c:4278 [inline]
rb_end_commit kernel/trace/ring_buffer.c:4323 [inline]
rb_move_tail+0x620/0xdc0 kernel/trace/ring_buffer.c:4011
__rb_reserve_next+0x51c/0x790 kernel/trace/ring_buffer.c:4856
rb_reserve_next_event kernel/trace/ring_buffer.c:5012 [inline]
ring_buffer_lock_reserve+0x7e4/0x9c0 kernel/trace/ring_buffer.c:5071
__trace_buffer_lock_reserve kernel/trace/trace.h:1674 [inline]
trace_event_buffer_lock_reserve+0x14a/0x300 kernel/trace/trace.c:1935
trace_event_buffer_reserve+0x120/0x180 kernel/trace/trace_events.c:724
do_trace_event_raw_event_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
trace_event_raw_event_bpf_trace_printk+0x9d/0x190 kernel/trace/bpf_trace.h:11
__do_trace_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
trace_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
____bpf_trace_printk kernel/trace/bpf_trace.c:409 [inline]
bpf_trace_printk+0x1b9/0x1e0 kernel/trace/bpf_trace.c:392
bpf_prog_484c593dea3d67e5+0x3b/0x41
bpf_dispatcher_nop_func include/linux/bpf.h:1547 [inline]
__bpf_prog_run include/linux/filter.h:813 [inline]
bpf_prog_run include/linux/filter.h:820 [inline]
bpf_overflow_handler kernel/events/core.c:10822 [inline]
__perf_event_overflow+0x331/0x950 kernel/events/core.c:10921
perf_event_overflow kernel/events/core.c:11004 [inline]
perf_swevent_hrtimer+0x293/0x320 kernel/events/core.c:12424
__run_hrtimer kernel/time/hrtimer.c:2079 [inline]
__hrtimer_run_queues+0x1f8/0x540 kernel/time/hrtimer.c:2136
hrtimer_interrupt+0x27b/0x870 kernel/time/hrtimer.c:2255
local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1051 [inline]
__sysvec_apic_timer_interrupt+0x5f/0x1f0 arch/x86/kernel/apic/apic.c:1068
instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1062 [inline]
sysvec_apic_timer_interrupt+0x6f/0x80 arch/x86/kernel/apic/apic.c:1062
asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:674
rdtsc_ordered arch/x86/include/asm/tsc.h:57 [inline]
delay_tsc+0x5b/0xa0 arch/x86/lib/delay.c:70
udelay include/asm-generic/delay.h:64 [inline]
delay_access kernel/kcsan/core.c:332 [inline]
kcsan_setup_watchpoint+0x255/0x3f0 kernel/kcsan/core.c:622
rb_wakeups kernel/trace/ring_buffer.c:4396 [inline]
ring_buffer_unlock_commit+0x191/0x3b0 kernel/trace/ring_buffer.c:4582
__buffer_unlock_commit kernel/trace/trace.h:1695 [inline]
trace_buffer_unlock_commit_regs+0x43/0x310 kernel/trace/trace.c:2060
trace_event_buffer_commit+0x149/0x5b0 kernel/trace/trace.c:2035
do_trace_event_raw_event_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
trace_event_raw_event_bpf_trace_printk+0xee/0x190 kernel/trace/bpf_trace.h:11
__do_trace_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
trace_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
____bpf_trace_printk kernel/trace/bpf_trace.c:409 [inline]
bpf_trace_printk+0x1b9/0x1e0 kernel/trace/bpf_trace.c:392
bpf_prog_ac2694f0a96ddbc2+0x43/0x6a
bpf_dispatcher_nop_func include/linux/bpf.h:1547 [inline]
__bpf_prog_run include/linux/filter.h:813 [inline]
bpf_prog_run include/linux/filter.h:820 [inline]
bpf_test_run+0x29b/0x620 net/bpf/test_run.c:422
bpf_prog_test_run_skb+0xaa1/0x11d0 net/bpf/test_run.c:1226
bpf_prog_test_run+0x21b/0x360 kernel/bpf/syscall.c:4860
__sys_bpf+0x914/0xc50 kernel/bpf/syscall.c:6478
__do_sys_bpf kernel/bpf/syscall.c:6582 [inline]
__se_sys_bpf kernel/bpf/syscall.c:6579 [inline]
__x64_sys_bpf+0x69/0x80 kernel/bpf/syscall.c:6579
x64_sys_call+0xf26/0x2550 arch/x86/include/generated/asm/syscalls_64.h:322
do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
entry_SYSCALL_64_after_hwframe+0x77/0x7f
read to 0xffff88810007a860 of 8 bytes by task 9170 on cpu 0:
rb_wakeups kernel/trace/ring_buffer.c:4396 [inline]
ring_buffer_unlock_commit+0x191/0x3b0 kernel/trace/ring_buffer.c:4582
__buffer_unlock_commit kernel/trace/trace.h:1695 [inline]
trace_buffer_unlock_commit_regs+0x43/0x310 kernel/trace/trace.c:2060
trace_event_buffer_commit+0x149/0x5b0 kernel/trace/trace.c:2035
do_trace_event_raw_event_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
trace_event_raw_event_bpf_trace_printk+0xee/0x190 kernel/trace/bpf_trace.h:11
__do_trace_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
trace_bpf_trace_printk kernel/trace/bpf_trace.h:11 [inline]
____bpf_trace_printk kernel/trace/bpf_trace.c:409 [inline]
bpf_trace_printk+0x1b9/0x1e0 kernel/trace/bpf_trace.c:392
bpf_prog_ac2694f0a96ddbc2+0x43/0x6a
bpf_dispatcher_nop_func include/linux/bpf.h:1547 [inline]
__bpf_prog_run include/linux/filter.h:813 [inline]
bpf_prog_run include/linux/filter.h:820 [inline]
bpf_test_run+0x29b/0x620 net/bpf/test_run.c:422
bpf_prog_test_run_skb+0xaa1/0x11d0 net/bpf/test_run.c:1226
bpf_prog_test_run+0x21b/0x360 kernel/bpf/syscall.c:4860
__sys_bpf+0x914/0xc50 kernel/bpf/syscall.c:6478
__do_sys_bpf kernel/bpf/syscall.c:6582 [inline]
__se_sys_bpf kernel/bpf/syscall.c:6579 [inline]
__x64_sys_bpf+0x69/0x80 kernel/bpf/syscall.c:6579
x64_sys_call+0xf26/0x2550 arch/x86/include/generated/asm/syscalls_64.h:322
do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
entry_SYSCALL_64_after_hwframe+0x77/0x7f
value changed: 0xffff8881206ca040 -> 0xffff8881206ca000
Reported by Kernel Concurrency Sanitizer on:
CPU: 0 UID: 0 PID: 9170 Comm: syz.1.1277 Not tainted syzkaller #0 PREEMPT(lazy)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================
---
This report is generated by a bot. It may contain errors.
See
https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at
syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup