[moderation] [perf?] KCSAN: data-race in __blk_flush_plug / perf_prepare_sample

0 views
Skip to first unread message

syzbot

unread,
7:08 PM (1 hour ago) 7:08 PM
to syzkaller-upst...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 666539eecdf4 Merge tag 'assoc-array-fixes-v2'
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1031e94e580000
kernel config: https://syzkaller.appspot.com/x/.config?x=b949a9d3c1d44ceb
dashboard link: https://syzkaller.appspot.com/bug?extid=e01554782fff4caed19b
compiler: Debian clang version 22.1.8 (1~deb13u4), Debian LLD 22.1.8
CC: [ac...@kernel.org adrian...@intel.com alexander...@linux.intel.com iro...@google.com james...@linaro.org jo...@kernel.org linux-...@vger.kernel.org linux-pe...@vger.kernel.org mark.r...@arm.com mi...@redhat.com namh...@kernel.org pet...@infradead.org]

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/a943b9915869/disk-666539ee.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9bfd839d7ea5/vmlinux-666539ee.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0f20b9720a71/bzImage-666539ee.xz

AI-generated root cause summary:
A KCSAN data race occurs between task context and an asynchronous interrupt on
the same CPU: `__blk_flush_plug()` performs an unmarked read-modify-write on
`current->flags` (`current->flags &= ~PF_BLOCK_TS;`) while an APIC timer
interrupt calls `perf_sample_regs_user()` -> `is_user_task()`, which executes an
unmarked read of `task->flags` (`task->flags & (PF_KTHREAD | PF_USER_WORKER)`).
Under the Linux Kernel Memory Model (LKMM), concurrent unmarked writes and reads
without annotations such as `READ_ONCE()` or atomic bit operations constitute a
data race. In practice, this race is benign because the interrupt handler only
inspects immutable task flags on disjoint bit positions without modifying the
field.

full analysis: https://syzkaller.appspot.com/x/ai_root_cause?x=e01554782fff4caed19b

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+e01554...@syzkaller.appspotmail.com

==================================================================
BUG: KCSAN: data-race in __blk_flush_plug / perf_prepare_sample

read to 0xffff888101de22ac of 4 bytes by interrupt on cpu 1:
is_user_task include/linux/sched.h:1874 [inline]
perf_sample_regs_user kernel/events/core.c:7947 [inline]
perf_prepare_sample+0x3d5/0x1550 kernel/events/core.c:8844
__perf_event_output kernel/events/core.c:9070 [inline]
perf_event_output_forward+0x61/0x170 kernel/events/core.c:9091
__perf_event_overflow+0x62f/0x950 kernel/events/core.c:10980
perf_event_overflow kernel/events/core.c:11004 [inline]
perf_swevent_hrtimer+0x293/0x320 kernel/events/core.c:12424
__run_hrtimer kernel/time/hrtimer.c:2079 [inline]
__hrtimer_run_queues+0x1f8/0x540 kernel/time/hrtimer.c:2136
hrtimer_interrupt+0x27b/0x870 kernel/time/hrtimer.c:2255
local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1051 [inline]
__sysvec_apic_timer_interrupt+0x5f/0x1f0 arch/x86/kernel/apic/apic.c:1068
instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1062 [inline]
sysvec_apic_timer_interrupt+0x6f/0x80 arch/x86/kernel/apic/apic.c:1062
asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:674
__preempt_count_add arch/x86/include/asm/preempt.h:98 [inline]
delay_tsc+0x4b/0xa0 arch/x86/lib/delay.c:77
udelay include/asm-generic/delay.h:64 [inline]
delay_access kernel/kcsan/core.c:332 [inline]
kcsan_setup_watchpoint+0x255/0x3f0 kernel/kcsan/core.c:622
__blk_flush_plug+0x26e/0x2b0 block/blk-core.c:1285
blk_finish_plug+0x47/0x70 block/blk-core.c:1301
lru_gen_shrink_lruvec mm/vmscan.c:5427 [inline]
shrink_lruvec mm/vmscan.c:6199 [inline]
shrink_node_memcgs mm/vmscan.c:6438 [inline]
shrink_node+0x9f6/0x4600 mm/vmscan.c:6482
shrink_zones mm/vmscan.c:6701 [inline]
do_try_to_free_pages+0x310/0xb80 mm/vmscan.c:6763
try_to_free_mem_cgroup_pages+0x201/0x450 mm/vmscan.c:7044
try_charge_memcg+0x460/0xc50 mm/memcontrol.c:2776
try_charge mm/memcontrol.c:2924 [inline]
obj_cgroup_charge_pages mm/memcontrol.c:3225 [inline]
__memcg_kmem_charge_page+0x1bd/0x3e0 mm/memcontrol.c:3269
__alloc_frozen_pages_noprof+0x1ff/0x3d0 mm/page_alloc.c:5514
alloc_pages_mpol+0xaf/0x1d0 mm/mempolicy.c:2513
alloc_frozen_pages_noprof mm/mempolicy.c:2584 [inline]
alloc_pages_noprof+0x94/0x160 mm/mempolicy.c:2604
vm_area_alloc_pages mm/vmalloc.c:3801 [inline]
__vmalloc_area_node mm/vmalloc.c:3948 [inline]
__vmalloc_node_range_noprof+0xa35/0x10b0 mm/vmalloc.c:4152
__bpf_map_area_alloc kernel/bpf/syscall.c:404 [inline]
bpf_map_area_alloc+0xfa/0x140 kernel/bpf/syscall.c:411
dev_map_init_map kernel/bpf/devmap.c:154 [inline]
dev_map_alloc+0x13d/0x350 kernel/bpf/devmap.c:173
map_create_alloc kernel/bpf/syscall.c:1553 [inline]
map_create+0xb14/0x1050 kernel/bpf/syscall.c:1663
__sys_bpf+0x8e0/0xc50 kernel/bpf/syscall.c:6437
__do_sys_bpf kernel/bpf/syscall.c:6582 [inline]
__se_sys_bpf kernel/bpf/syscall.c:6579 [inline]
__x64_sys_bpf+0x69/0x80 kernel/bpf/syscall.c:6579
x64_sys_call+0xf26/0x2550 arch/x86/include/generated/asm/syscalls_64.h:322
do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
entry_SYSCALL_64_after_hwframe+0x77/0x7f

read-write to 0xffff888101de22ac of 4 bytes by task 13850 on cpu 1:
__blk_flush_plug+0x26e/0x2b0 block/blk-core.c:1285
blk_finish_plug+0x47/0x70 block/blk-core.c:1301
lru_gen_shrink_lruvec mm/vmscan.c:5427 [inline]
shrink_lruvec mm/vmscan.c:6199 [inline]
shrink_node_memcgs mm/vmscan.c:6438 [inline]
shrink_node+0x9f6/0x4600 mm/vmscan.c:6482
shrink_zones mm/vmscan.c:6701 [inline]
do_try_to_free_pages+0x310/0xb80 mm/vmscan.c:6763
try_to_free_mem_cgroup_pages+0x201/0x450 mm/vmscan.c:7044
try_charge_memcg+0x460/0xc50 mm/memcontrol.c:2776
try_charge mm/memcontrol.c:2924 [inline]
obj_cgroup_charge_pages mm/memcontrol.c:3225 [inline]
__memcg_kmem_charge_page+0x1bd/0x3e0 mm/memcontrol.c:3269
__alloc_frozen_pages_noprof+0x1ff/0x3d0 mm/page_alloc.c:5514
alloc_pages_mpol+0xaf/0x1d0 mm/mempolicy.c:2513
alloc_frozen_pages_noprof mm/mempolicy.c:2584 [inline]
alloc_pages_noprof+0x94/0x160 mm/mempolicy.c:2604
vm_area_alloc_pages mm/vmalloc.c:3801 [inline]
__vmalloc_area_node mm/vmalloc.c:3948 [inline]
__vmalloc_node_range_noprof+0xa35/0x10b0 mm/vmalloc.c:4152
__bpf_map_area_alloc kernel/bpf/syscall.c:404 [inline]
bpf_map_area_alloc+0xfa/0x140 kernel/bpf/syscall.c:411
dev_map_init_map kernel/bpf/devmap.c:154 [inline]
dev_map_alloc+0x13d/0x350 kernel/bpf/devmap.c:173
map_create_alloc kernel/bpf/syscall.c:1553 [inline]
map_create+0xb14/0x1050 kernel/bpf/syscall.c:1663
__sys_bpf+0x8e0/0xc50 kernel/bpf/syscall.c:6437
__do_sys_bpf kernel/bpf/syscall.c:6582 [inline]
__se_sys_bpf kernel/bpf/syscall.c:6579 [inline]
__x64_sys_bpf+0x69/0x80 kernel/bpf/syscall.c:6579
x64_sys_call+0xf26/0x2550 arch/x86/include/generated/asm/syscalls_64.h:322
do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
entry_SYSCALL_64_after_hwframe+0x77/0x7f

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 UID: 0 PID: 13850 Comm: syz.1.2653 Not tainted syzkaller #0 PREEMPT(lazy)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages