[moderation] [mm?] [fs?] KCSAN: data-race in fprop_new_period / fprop_reflect_period_percpu (12)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 2d3090a8aeb5 Merge tag 'v7.1-p5' of git://git.kernel.org/p..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13d691b6580000
kernel config: https://syzkaller.appspot.com/x/.config?x=f571f22917457cd8
dashboard link: https://syzkaller.appspot.com/bug?extid=4aa04afa96d122358ff0
compiler: Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8
CC: [ak...@linux-foundation.org ja...@suse.cz linux-...@vger.kernel.org linux-...@vger.kernel.org linu...@kvack.org wi...@infradead.org]

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/26be1447042c/disk-2d3090a8.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/670d370f999e/vmlinux-2d3090a8.xz
kernel image: https://storage.googleapis.com/syzbot-assets/c666178a2688/bzImage-2d3090a8.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+4aa04a...@syzkaller.appspotmail.com

==================================================================
BUG: KCSAN: data-race in fprop_new_period / fprop_reflect_period_percpu

read-write to 0xffffffff893c2e40 of 4 bytes by interrupt on cpu 0:
fprop_new_period+0xa4/0x110 lib/flex_proportions.c:80
writeout_period+0x5a/0xe0 mm/page-writeback.c:607
call_timer_fn+0x3b/0x240 kernel/time/timer.c:1748
expire_timers kernel/time/timer.c:1799 [inline]
__run_timers kernel/time/timer.c:2374 [inline]
__run_timer_base+0x415/0x5f0 kernel/time/timer.c:2386
run_timer_base kernel/time/timer.c:2395 [inline]
run_timer_softirq+0x45/0x70 kernel/time/timer.c:2406
handle_softirqs+0xb9/0x280 kernel/softirq.c:622
__do_softirq kernel/softirq.c:656 [inline]
invoke_softirq kernel/softirq.c:496 [inline]
__irq_exit_rcu+0x42/0xd0 kernel/softirq.c:735
instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1061 [inline]
sysvec_apic_timer_interrupt+0x74/0x80 arch/x86/kernel/apic/apic.c:1061
asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:697
kcsan_setup_watchpoint+0x404/0x410 kernel/kcsan/core.c:705
step_into fs/namei.c:2142 [inline]
walk_component fs/namei.c:2284 [inline]
link_path_walk+0x6db/0xe30 fs/namei.c:2652
path_openat+0x1c6/0x2050 fs/namei.c:4854
do_file_open+0x16c/0x290 fs/namei.c:4887
do_sys_openat2+0x94/0x130 fs/open.c:1364
do_sys_open fs/open.c:1370 [inline]
__do_sys_openat fs/open.c:1386 [inline]
__se_sys_openat fs/open.c:1381 [inline]
__x64_sys_openat+0xf2/0x120 fs/open.c:1381
x64_sys_call+0x1e39/0x3020 arch/x86/include/generated/asm/syscalls_64.h:258
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0x12c/0x3b0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f

read to 0xffffffff893c2e40 of 4 bytes by task 30 on cpu 1:
fprop_reflect_period_percpu+0x22/0x190 lib/flex_proportions.c:112
__fprop_add_percpu lib/flex_proportions.c:143 [inline]
__fprop_add_percpu_max+0x57/0x190 lib/flex_proportions.c:201
wb_domain_writeout_add mm/page-writeback.c:554 [inline]
__wb_writeout_add+0x75/0x1b0 mm/page-writeback.c:578
__folio_end_writeback+0x14b/0x360 mm/page-writeback.c:2970
folio_end_writeback_no_dropbehind+0x6d/0x1d0 mm/filemap.c:1667
folio_end_writeback+0x1c/0x70 mm/filemap.c:1693
ext4_finish_bio+0x450/0x760 fs/ext4/page-io.c:144
ext4_release_io_end+0x9f/0x1f0 fs/ext4/page-io.c:159
ext4_end_io_end+0x18d/0x240 fs/ext4/page-io.c:210
ext4_do_flush_completed_IO fs/ext4/page-io.c:290 [inline]
ext4_end_io_rsv_work+0x15b/0x1f0 fs/ext4/page-io.c:305
process_one_work kernel/workqueue.c:3314 [inline]
process_scheduled_works+0x4f0/0x9c0 kernel/workqueue.c:3397
worker_thread+0x58a/0x780 kernel/workqueue.c:3478
kthread+0x22a/0x280 kernel/kthread.c:436
ret_from_fork+0x146/0x330 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

value changed: 0x00000005 -> 0x00000006

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 UID: 0 PID: 30 Comm: kworker/u8:1 Not tainted syzkaller #0 PREEMPT(lazy)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Workqueue: ext4-rsv-conversion ext4_end_io_rsv_work
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup