Hello,
syzbot found the following issue on:
HEAD commit: a08b41ab9e2e Merge tag 'for-linus' of git://git.armlinux.o..
git tree: upstream
console output:
https://syzkaller.appspot.com/x/log.txt?x=115bcc57b00000
kernel config:
https://syzkaller.appspot.com/x/.config?x=916d34c0d501b86
dashboard link:
https://syzkaller.appspot.com/bug?extid=1365960e12f1f93a06ec
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
CC: [
gre...@linuxfoundation.org linux-...@vger.kernel.org t...@kernel.org]
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by:
syzbot+136596...@syzkaller.appspotmail.com
usb 6-1: Direct firmware load for ueagle-atm/eagleII.fw failed with error -2
usb 6-1: Falling back to sysfs fallback for: ueagle-atm/eagleII.fw
==================================================================
BUG: KASAN: use-after-free in instrument_atomic_read include/linux/instrumented.h:71 [inline]
BUG: KASAN: use-after-free in atomic_read include/linux/atomic/atomic-instrumented.h:27 [inline]
BUG: KASAN: use-after-free in kernfs_get.part.0+0x17/0x80 fs/kernfs/dir.c:496
Read of size 4 at addr ffff8880399c19f8 by task kworker/1:23/5149
CPU: 1 PID: 5149 Comm: kworker/1:23 Not tainted 5.17.0-rc1-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events request_firmware_work_func
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
print_address_description.constprop.0.cold+0x8d/0x336 mm/kasan/report.c:255
__kasan_report mm/kasan/report.c:442 [inline]
kasan_report.cold+0x83/0xdf mm/kasan/report.c:459
check_region_inline mm/kasan/generic.c:183 [inline]
kasan_check_range+0x13d/0x180 mm/kasan/generic.c:189
instrument_atomic_read include/linux/instrumented.h:71 [inline]
atomic_read include/linux/atomic/atomic-instrumented.h:27 [inline]
kernfs_get.part.0+0x17/0x80 fs/kernfs/dir.c:496
kernfs_get+0x1b/0x30 fs/kernfs/dir.c:495
sysfs_get include/linux/sysfs.h:635 [inline]
create_dir lib/kobject.c:111 [inline]
kobject_add_internal+0x5c3/0xa60 lib/kobject.c:255
kobject_add_varg lib/kobject.c:390 [inline]
kobject_add+0x150/0x1c0 lib/kobject.c:442
class_dir_create_and_add drivers/base/core.c:2942 [inline]
get_device_parent+0x3d7/0x590 drivers/base/core.c:2997
device_add+0x2a8/0x1ee0 drivers/base/core.c:3326
fw_load_sysfs_fallback drivers/base/firmware_loader/fallback.c:512 [inline]
fw_load_from_user_helper drivers/base/firmware_loader/fallback.c:588 [inline]
firmware_fallback_sysfs+0x402/0xe70 drivers/base/firmware_loader/fallback.c:664
_request_firmware+0xb97/0xfe0 drivers/base/firmware_loader/main.c:774
request_firmware_work_func+0xdd/0x230 drivers/base/firmware_loader/main.c:1020
process_one_work+0x9ac/0x1650 kernel/workqueue.c:2307
worker_thread+0x657/0x1110 kernel/workqueue.c:2454
kthread+0x2e9/0x3a0 kernel/kthread.c:377
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
</TASK>
Allocated by task 5149:
kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38
kasan_set_track mm/kasan/common.c:45 [inline]
set_alloc_info mm/kasan/common.c:436 [inline]
__kasan_slab_alloc+0x90/0xc0 mm/kasan/common.c:469
kasan_slab_alloc include/linux/kasan.h:260 [inline]
slab_post_alloc_hook mm/slab.h:732 [inline]
slab_alloc_node mm/slub.c:3230 [inline]
slab_alloc mm/slub.c:3238 [inline]
kmem_cache_alloc+0x202/0x3a0 mm/slub.c:3243
kmem_cache_zalloc include/linux/slab.h:705 [inline]
__kernfs_new_node+0xd4/0x8b0 fs/kernfs/dir.c:585
kernfs_new_node fs/kernfs/dir.c:647 [inline]
kernfs_create_dir_ns+0x9c/0x220 fs/kernfs/dir.c:994
sysfs_create_dir_ns+0x127/0x290 fs/sysfs/dir.c:59
create_dir lib/kobject.c:89 [inline]
kobject_add_internal+0x2d2/0xa60 lib/kobject.c:255
kobject_add_varg lib/kobject.c:390 [inline]
kobject_add+0x150/0x1c0 lib/kobject.c:442
class_dir_create_and_add drivers/base/core.c:2942 [inline]
get_device_parent+0x3d7/0x590 drivers/base/core.c:2997
device_add+0x2a8/0x1ee0 drivers/base/core.c:3326
fw_load_sysfs_fallback drivers/base/firmware_loader/fallback.c:512 [inline]
fw_load_from_user_helper drivers/base/firmware_loader/fallback.c:588 [inline]
firmware_fallback_sysfs+0x402/0xe70 drivers/base/firmware_loader/fallback.c:664
_request_firmware+0xb97/0xfe0 drivers/base/firmware_loader/main.c:774
request_firmware_work_func+0xdd/0x230 drivers/base/firmware_loader/main.c:1020
process_one_work+0x9ac/0x1650 kernel/workqueue.c:2307
worker_thread+0x657/0x1110 kernel/workqueue.c:2454
kthread+0x2e9/0x3a0 kernel/kthread.c:377
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
Freed by task 13219:
kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38
kasan_set_track+0x21/0x30 mm/kasan/common.c:45
kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:370
____kasan_slab_free mm/kasan/common.c:366 [inline]
____kasan_slab_free+0x130/0x160 mm/kasan/common.c:328
kasan_slab_free include/linux/kasan.h:236 [inline]
slab_free_hook mm/slub.c:1728 [inline]
slab_free_freelist_hook+0x8b/0x1c0 mm/slub.c:1754
slab_free mm/slub.c:3509 [inline]
kmem_cache_free+0xd8/0x340 mm/slub.c:3526
kernfs_put.part.0+0x2c4/0x540 fs/kernfs/dir.c:539
kernfs_put+0x42/0x50 fs/kernfs/dir.c:513
__kernfs_remove+0x7a3/0xb20 fs/kernfs/dir.c:1388
kernfs_remove+0x6d/0x90 fs/kernfs/dir.c:1403
sysfs_remove_dir+0xc1/0x100 fs/sysfs/dir.c:101
__kobject_del+0xe2/0x200 lib/kobject.c:620
kobject_del lib/kobject.c:643 [inline]
kobject_del+0x3c/0x60 lib/kobject.c:635
device_del+0x82c/0xd50 drivers/base/core.c:3603
usb_disconnect.cold+0x4ba/0x78e drivers/usb/core/hub.c:2254
hub_port_connect drivers/usb/core/hub.c:5202 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5502 [inline]
port_event drivers/usb/core/hub.c:5660 [inline]
hub_event+0x1e39/0x44d0 drivers/usb/core/hub.c:5742
process_one_work+0x9ac/0x1650 kernel/workqueue.c:2307
process_scheduled_works kernel/workqueue.c:2370 [inline]
worker_thread+0x833/0x1110 kernel/workqueue.c:2456
kthread+0x2e9/0x3a0 kernel/kthread.c:377
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
The buggy address belongs to the object at ffff8880399c19f8
which belongs to the cache kernfs_node_cache of size 168
The buggy address is located 0 bytes inside of
168-byte region [ffff8880399c19f8, ffff8880399c1aa0)
The buggy address belongs to the page:
page:ffffea0000e67040 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x399c1
flags: 0xfff00000000200(slab|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000000200 ffffea0001e63080 dead000000000006 ffff888010dd3a00
raw: 0000000000000000 0000000080110011 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x112cc0(GFP_USER|__GFP_NOWARN|__GFP_NORETRY), pid 1101, ts 1550795052467, free_ts 1550459314389
prep_new_page mm/page_alloc.c:2434 [inline]
get_page_from_freelist+0xa72/0x2f50 mm/page_alloc.c:4165
__alloc_pages+0x1b2/0x500 mm/page_alloc.c:5389
alloc_pages+0x1aa/0x310 mm/mempolicy.c:2271
alloc_slab_page mm/slub.c:1799 [inline]
allocate_slab mm/slub.c:1944 [inline]
new_slab+0x28a/0x3b0 mm/slub.c:2004
___slab_alloc+0x87c/0xe90 mm/slub.c:3018
__slab_alloc.constprop.0+0x4d/0xa0 mm/slub.c:3105
slab_alloc_node mm/slub.c:3196 [inline]
slab_alloc mm/slub.c:3238 [inline]
kmem_cache_alloc+0x35c/0x3a0 mm/slub.c:3243
kmem_cache_zalloc include/linux/slab.h:705 [inline]
__kernfs_new_node+0xd4/0x8b0 fs/kernfs/dir.c:585
kernfs_new_node+0x93/0x120 fs/kernfs/dir.c:647
__kernfs_create_file+0x51/0x350 fs/kernfs/file.c:987
sysfs_add_file_mode_ns+0x20f/0x3f0 fs/sysfs/file.c:294
create_files fs/sysfs/group.c:64 [inline]
internal_create_group+0x322/0xb10 fs/sysfs/group.c:148
internal_create_groups.part.0+0x90/0x140 fs/sysfs/group.c:188
internal_create_groups fs/sysfs/group.c:184 [inline]
sysfs_create_groups+0x25/0x50 fs/sysfs/group.c:214
device_add_groups drivers/base/core.c:2471 [inline]
device_add_attrs drivers/base/core.c:2630 [inline]
device_add+0x8c7/0x1ee0 drivers/base/core.c:3356
usb_new_device.cold+0x63f/0x108e drivers/usb/core/hub.c:2566
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1352 [inline]
free_pcp_prepare+0x374/0x870 mm/page_alloc.c:1404
free_unref_page_prepare mm/page_alloc.c:3325 [inline]
free_unref_page+0x19/0x690 mm/page_alloc.c:3404
__vunmap+0x798/0xc50 mm/vmalloc.c:2635
__vfree+0x3c/0xd0 mm/vmalloc.c:2683
vfree+0x5a/0x90 mm/vmalloc.c:2714
n_tty_close+0xcf/0x1e0 drivers/tty/n_tty.c:1795
tty_ldisc_close+0x110/0x190 drivers/tty/tty_ldisc.c:456
tty_ldisc_kill+0x94/0x150 drivers/tty/tty_ldisc.c:608
tty_ldisc_release+0x1ef/0x2a0 drivers/tty/tty_ldisc.c:776
tty_release_struct+0x20/0xe0 drivers/tty/tty_io.c:1694
tty_release+0xc70/0x1200 drivers/tty/tty_io.c:1865
__fput+0x286/0x9f0 fs/file_table.c:311
task_work_run+0xdd/0x1a0 kernel/task_work.c:164
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_user_mode_loop kernel/entry/common.c:175 [inline]
exit_to_user_mode_prepare+0x27e/0x290 kernel/entry/common.c:207
__syscall_exit_to_user_mode_work kernel/entry/common.c:289 [inline]
syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:300
do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86
Memory state around the buggy address:
ffff8880399c1880: fb fb fb fb fb fb fb fb fb fb fc fc fc fc fc fc
ffff8880399c1900: fc fc fa fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8880399c1980: fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc fa
^
ffff8880399c1a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8880399c1a80: fb fb fb fb fc fc fc fc fc fc fc fc fa fb fb fb
==================================================================
---
This report is generated by a bot. It may contain errors.
See
https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at
syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.