[moderation] [bpf?] BUG: corrupted list in __bpf_lru_node_move

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 2ccbdf43d5e7 Merge tag 'for-linus' of git://git.kernel.org..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17c6c41e980000
kernel config: https://syzkaller.appspot.com/x/.config?x=81c0d76ceef02b39
dashboard link: https://syzkaller.appspot.com/bug?extid=0811f13beac071cf0f20
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: i386
CC: [and...@kernel.org a...@kernel.org b...@vger.kernel.org dan...@iogearbox.net edd...@gmail.com hao...@google.com john.fa...@gmail.com jo...@kernel.org kps...@kernel.org linux-...@vger.kernel.org marti...@linux.dev s...@google.com so...@kernel.org yongho...@linux.dev]

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7bc7510fe41f/non_bootable_disk-2ccbdf43.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/13cdb5bfbafa/vmlinux-2ccbdf43.xz
kernel image: https://storage.googleapis.com/syzbot-assets/7a14f5d07f81/bzImage-2ccbdf43.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+0811f1...@syzkaller.appspotmail.com

bridge: RTM_NEWNEIGH bridge0 without NUD_PERMANENT
list_add corruption. next->prev should be prev (ffffe8ffad25b4d0), but was ffffe8ffad25b4e6. (next=ffffe8ffad25b4d0).
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:29!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI
CPU: 2 PID: 10128 Comm: syz-executor.3 Not tainted 6.10.0-rc3-syzkaller-00044-g2ccbdf43d5e7 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
RIP: 0010:__list_add_valid_or_report+0xa9/0x100 lib/list_debug.c:29
Code: c7 8f 8b e8 b9 30 e9 fc 90 0f 0b 48 c7 c7 c0 c7 8f 8b e8 aa 30 e9 fc 90 0f 0b 48 89 d9 48 c7 c7 20 c8 8f 8b e8 98 30 e9 fc 90 <0f> 0b 48 89 f1 48 c7 c7 a0 c8 8f 8b 48 89 de e8 83 30 e9 fc 90 0f
RSP: 0018:ffffc9000385f8c0 EFLAGS: 00010086
RAX: 0000000000000075 RBX: ffffe8ffad25b4d0 RCX: ffffc90003499000
RDX: 0000000000000000 RSI: ffffffff816fcdb6 RDI: 0000000000000005
RBP: ffff8880286885d0 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000080000001 R11: 0000000000000002 R12: ffffe8ffad25b4d0
R13: ffffe8ffad25b4d0 R14: 0000000000000010 R15: ffff888028688590
FS: 0000000000000000(0000) GS:ffff88802c200000(0063) knlGS:00000000f5e52b40
CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033
CR2: 0000000020000080 CR3: 0000000000d8a000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__list_add_valid include/linux/list.h:88 [inline]
__list_add include/linux/list.h:150 [inline]
list_add include/linux/list.h:169 [inline]
list_move include/linux/list.h:299 [inline]
__bpf_lru_node_move+0x21a/0x480 kernel/bpf/bpf_lru_list.c:126
bpf_percpu_lru_pop_free kernel/bpf/bpf_lru_list.c:428 [inline]
bpf_lru_pop_free+0x25a/0x17e0 kernel/bpf/bpf_lru_list.c:502
prealloc_lru_pop kernel/bpf/hashtab.c:308 [inline]
__htab_lru_percpu_map_update_elem+0x17e/0xbd0 kernel/bpf/hashtab.c:1355
bpf_percpu_hash_update+0x122/0x240 kernel/bpf/hashtab.c:2421
bpf_map_update_value+0x3e1/0x6c0 kernel/bpf/syscall.c:181
generic_map_update_batch+0x454/0x5f0 kernel/bpf/syscall.c:1889
bpf_map_do_batch+0x615/0x6e0 kernel/bpf/syscall.c:5197
__sys_bpf+0x18cb/0x5830 kernel/bpf/syscall.c:5752
__do_sys_bpf kernel/bpf/syscall.c:5795 [inline]
__se_sys_bpf kernel/bpf/syscall.c:5793 [inline]
__ia32_sys_bpf+0x76/0xe0 kernel/bpf/syscall.c:5793
do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline]
__do_fast_syscall_32+0x73/0x120 arch/x86/entry/common.c:386
do_fast_syscall_32+0x32/0x80 arch/x86/entry/common.c:411
entry_SYSENTER_compat_after_hwframe+0x84/0x8e
RIP: 0023:0xf7260579
Code: b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 00 00 00 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00
RSP: 002b:00000000f5e525ac EFLAGS: 00000292 ORIG_RAX: 0000000000000165
RAX: ffffffffffffffda RBX: 000000000000001a RCX: 0000000020000080
RDX: 0000000000000038 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000292 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:__list_add_valid_or_report+0xa9/0x100 lib/list_debug.c:29
Code: c7 8f 8b e8 b9 30 e9 fc 90 0f 0b 48 c7 c7 c0 c7 8f 8b e8 aa 30 e9 fc 90 0f 0b 48 89 d9 48 c7 c7 20 c8 8f 8b e8 98 30 e9 fc 90 <0f> 0b 48 89 f1 48 c7 c7 a0 c8 8f 8b 48 89 de e8 83 30 e9 fc 90 0f
RSP: 0018:ffffc9000385f8c0 EFLAGS: 00010086
RAX: 0000000000000075 RBX: ffffe8ffad25b4d0 RCX: ffffc90003499000
RDX: 0000000000000000 RSI: ffffffff816fcdb6 RDI: 0000000000000005
RBP: ffff8880286885d0 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000080000001 R11: 0000000000000002 R12: ffffe8ffad25b4d0
R13: ffffe8ffad25b4d0 R14: 0000000000000010 R15: ffff888028688590
FS: 0000000000000000(0000) GS:ffff88802c200000(0063) knlGS:00000000f5e52b40
CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033
CR2: 0000000020000080 CR3: 0000000000d8a000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess), 2 bytes skipped:
0: 10 06 adc %al,(%rsi)
2: 03 74 b4 01 add 0x1(%rsp,%rsi,4),%esi
6: 10 07 adc %al,(%rdi)
8: 03 74 b0 01 add 0x1(%rax,%rsi,4),%esi
c: 10 08 adc %cl,(%rax)
e: 03 74 d8 01 add 0x1(%rax,%rbx,8),%esi
1e: 00 51 52 add %dl,0x52(%rcx)
21: 55 push %rbp
22: 89 e5 mov %esp,%ebp
24: 0f 34 sysenter
26: cd 80 int $0x80
* 28: 5d pop %rbp <-- trapping instruction
29: 5a pop %rdx
2a: 59 pop %rcx
2b: c3 ret
2c: 90 nop
2d: 90 nop
2e: 90 nop
2f: 90 nop
30: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi
37: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup