openbsd build error (15)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: fe510045a1df Same as -N, don't send if 0 arguments and -R.
git tree: openbsd
console output: https://syzkaller.appspot.com/x/log.txt?x=16fa77c8b00000
kernel config: https://syzkaller.appspot.com/x/.config?x=fe55924c11e64b0a
dashboard link: https://syzkaller.appspot.com/bug?extid=2a7b6e3afecd54f9d502

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+2a7b6e...@syzkaller.appspotmail.com

sys/kern/vfs_vops.c:102:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:120:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:155:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:173:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:209:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:226:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:244:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:326:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:347:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:348:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:364:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:385:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:403:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:419:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:420:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:441:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:459:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:475:2: error: use of undeclared identifier 'LK_EXCLUSIVE'
sys/kern/vfs_vops.c:504:2: error: use of undeclared identifier 'LK_EXCLUSIVE'

---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[Greg Steuck]

#syz fix: vnode: remove VLOCKSWORK and check locking when vop_islocked != nullop                

[Anton Lindqvist]

On Tue, Oct 19, 2021 at 07:14:58PM -0700, Greg Steuck wrote:
> #syz fix: vnode: remove VLOCKSWORK and check locking when vop_islocked !=
> nullop

ci-openbsd-main seems stuck on an older Git revision...

[Sebastien Marie]

I just reverted the VLOCKSWORK removal. syzkaller found that I broke 'GENERIC + VFSLCKDEBUG'.

There is a conditional include for <sys/lock.h> inside <sys/sched.h>
which makes LK_EXCLUSIVE not visible without MULTIPROCESSOR.

--
Sebastien Marie