Re: assert failed: sc->sc_parent->dk_rawopens > NUM

[syzbot]

> #syz test: https://github.com/NetBSD/src trunk

Your commands are accepted, but please keep syzkaller-...@googlegroups.com mailing list in CC next time. It serves as a history of what happened with each bug report. Thank you.

>
> https://syzkaller.appspot.com/bug?id=b0f4eb12650965fba1bfdf540a2056195c36079d

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+407665...@syzkaller.appspotmail.com

Tested on:

commit: 374ad73a lint: eliminate redundant code
git tree: https://github.com/NetBSD/src trunk
console output: https://syzkaller.appspot.com/x/log.txt?x=1569ae52a80000
kernel config: https://syzkaller.appspot.com/x/.config?x=739e57438eb9ed9e
dashboard link: https://syzkaller.appspot.com/bug?extid=4076654b4f6ab4c97c19
compiler: Debian clang version 15.0.6

Note: no patches were applied.
Note: testing is done by a robot and is best-effort only.

[Taylor R Campbell]

#syz test: https://github.com/NetBSD/src 6b91a4e1d350a8a24ea9d0327286164e3e18c5f2

https://syzkaller.appspot.com/bug?id=b0f4eb12650965fba1bfdf540a2056195c36079d

Curious to see if it was fixed before the device reference changes.

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+407665...@syzkaller.appspotmail.com

Tested on:

commit: 6b91a4e1 dk(4): Need pdk->dk_openlock to read pdk->dk_..
git tree: https://github.com/NetBSD/src
console output: https://syzkaller.appspot.com/x/log.txt?x=103f6516a80000

[Taylor R Campbell]

#syz fix: dk(4): Use disk_begindetach and rely on vdevgone to close instances.

Not sure exactly which commit fixed it, but this or the next one,
`dk(4): Set .d_cfdriver and .d_devtounit to plug open/detach race.',
are the best candidates, without having bisected to find the exact one
-- also some commits along the way broke and fixed some other things
so pinpointing the commit that fixed _this_ issue might be tricky. In
any case, pretty sure it's fixed along with a slew of other locking
bugs and invariant violations.