[v5.15] possible deadlock in ocfs2_lock_global_qf (2)

0 views
Skip to first unread message

syzbot

unread,
Jun 1, 2026, 11:12:24 PM (11 hours ago) Jun 1
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: dc027a595035 Linux 5.15.209
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12ffb486580000
kernel config: https://syzkaller.appspot.com/x/.config?x=353ae28c40b35af5
dashboard link: https://syzkaller.appspot.com/bug?extid=c84b64c6278551b24c13
compiler: Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/586ac2a2fd9d/disk-dc027a59.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/06dcb6a2fcd3/vmlinux-dc027a59.xz
kernel image: https://storage.googleapis.com/syzbot-assets/567131e0cbcc/bzImage-dc027a59.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c84b64...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.5.3596/19321 is trying to acquire lock:
ffff88807258bf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1fe/0x290 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff88807258c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88807258c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1d7/0x290 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}:
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:787 [inline]
ocfs2_lock_global_qf+0x1d7/0x290 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x29d/0xb10 fs/ocfs2/quota_global.c:816
dqget+0x72b/0xc30 fs/quota/dquot.c:1010
__dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1539
ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
ocfs2_mknod+0x8ab/0x2510 fs/ocfs2/namei.c:310
ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3470 [inline]
open_last_lookups fs/namei.c:3540 [inline]
path_openat+0x11db/0x2fa0 fs/namei.c:3747
do_filp_open+0x1e2/0x410 fs/namei.c:3777
do_sys_openat2+0x150/0x4b0 fs/open.c:1255
do_sys_open fs/open.c:1271 [inline]
__do_sys_open fs/open.c:1279 [inline]
__se_sys_open fs/open.c:1275 [inline]
__x64_sys_open+0x11b/0x140 fs/open.c:1275
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
__mutex_lock_common+0x1e3/0x2400 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
dquot_commit+0x5a/0x410 fs/quota/dquot.c:532
ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6212
mark_dquot_dirty fs/quota/dquot.c:397 [inline]
mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:437
__dquot_alloc_space+0x5d0/0xe20 fs/quota/dquot.c:1774
dquot_alloc_space_nodirty include/linux/quotaops.h:290 [inline]
dquot_alloc_space include/linux/quotaops.h:303 [inline]
dquot_alloc_block include/linux/quotaops.h:327 [inline]
ext4_mb_new_blocks+0xfb1/0x4820 fs/ext4/mballoc.c:5750
ext4_ext_map_blocks+0x18ab/0x65e0 fs/ext4/extents.c:4357
ext4_map_blocks+0x98e/0x1b30 fs/ext4/inode.c:675
ext4_iomap_alloc fs/ext4/inode.c:3410 [inline]
ext4_iomap_begin+0x81f/0xba0 fs/ext4/inode.c:3460
iomap_iter+0x620/0xdb0 fs/iomap/iter.c:74
__iomap_dio_rw+0xade/0x1b00 fs/iomap/direct-io.c:589
iomap_dio_rw+0x38/0x90 fs/iomap/direct-io.c:676
ext4_dio_write_iter fs/ext4/file.c:540 [inline]
ext4_file_write_iter+0x12ad/0x1700 fs/ext4/file.c:660
do_iter_readv_writev+0x47e/0x5f0 fs/read_write.c:-1
do_iter_write+0x205/0x7b0 fs/read_write.c:855
vfs_writev fs/read_write.c:928 [inline]
do_pwritev+0x240/0x3a0 fs/read_write.c:1025
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (&ei->i_data_sem){++++}-{3:3}:
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ext4_map_blocks+0x8bf/0x1b30 fs/ext4/inode.c:668
mpage_map_one_extent fs/ext4/inode.c:2410 [inline]
mpage_map_and_submit_extent fs/ext4/inode.c:2463 [inline]
ext4_writepages+0x135b/0x2df0 fs/ext4/inode.c:2831
do_writepages+0x476/0x6e0 mm/page-writeback.c:2386
__writeback_single_inode+0x153/0xda0 fs/fs-writeback.c:1657
writeback_sb_inodes+0xa4e/0x1680 fs/fs-writeback.c:1940
__writeback_inodes_wb+0x12a/0x3f0 fs/fs-writeback.c:2011
wb_writeback+0x46f/0xbe0 fs/fs-writeback.c:2116
wb_check_background_flush fs/fs-writeback.c:2182 [inline]
wb_do_writeback fs/fs-writeback.c:2270 [inline]
wb_workfn+0xbd6/0xf20 fs/fs-writeback.c:2298
process_one_work+0x85f/0x1010 kernel/workqueue.c:2310
worker_thread+0xaa6/0x1290 kernel/workqueue.c:2457
kthread+0x436/0x520 kernel/kthread.c:334
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #3 (jbd2_handle){++++}-{0:0}:
wait_transaction_locked+0x1bb/0x270 fs/jbd2/transaction.c:178
add_transaction_credits+0x103/0xc80 fs/jbd2/transaction.c:242
start_this_handle+0x74d/0x15c0 fs/jbd2/transaction.c:423
jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
ocfs2_start_trans+0x3b2/0x6f0 fs/ocfs2/journal.c:376
ocfs2_del_inode_from_orphan+0x169/0x7a0 fs/ocfs2/namei.c:2722
ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
ocfs2_dio_end_io+0x103a/0x13c0 fs/ocfs2/aops.c:2446
dio_complete+0x249/0x720 fs/direct-io.c:272
do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
__blockdev_direct_IO+0x2e31/0x3a70 fs/direct-io.c:1368
ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
generic_file_direct_write+0x22c/0x490 mm/filemap.c:3687
__generic_file_write_iter+0x2b1/0x4e0 mm/filemap.c:3869
ocfs2_file_write_iter+0x1670/0x1e70 fs/ocfs2/file.c:2472
do_iter_readv_writev+0x47e/0x5f0 fs/read_write.c:-1
do_iter_write+0x205/0x7b0 fs/read_write.c:855
iter_file_splice_write+0x699/0xcc0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe1/0x130 fs/splice.c:956
splice_direct_to_actor+0x4ea/0xc10 fs/splice.c:902
do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
do_sendfile+0x5fc/0xeb0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374
ocfs2_modify_bh+0xe0/0x4c0 fs/ocfs2/quota_local.c:101
ocfs2_local_read_info+0x13c8/0x1750 fs/ocfs2/quota_local.c:764
dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2485
dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2522
ocfs2_enable_quotas+0x1c5/0x490 fs/ocfs2/super.c:927
ocfs2_fill_super+0x3cd2/0x50f0 fs/ocfs2/super.c:1140
mount_bdev+0x287/0x3c0 fs/super.c:1400
legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
vfs_get_tree+0x88/0x270 fs/super.c:1530
do_new_mount+0x24a/0xa40 fs/namespace.c:3034
do_mount fs/namespace.c:3377 [inline]
__do_sys_mount fs/namespace.c:3585 [inline]
__se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (sb_internal#4){.+.+}-{0:0}:
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2a7/0x6f0 fs/ocfs2/journal.c:372
ocfs2_write_info+0x112/0x360 fs/ocfs2/quota_global.c:982
dquot_set_dqinfo+0x459/0x6c0 fs/quota/dquot.c:2926
quota_setinfo+0x2cf/0x2e0 fs/quota/quota.c:173
__do_sys_quotactl fs/quota/quota.c:959 [inline]
__se_sys_quotactl+0x28b/0x6f0 fs/quota/quota.c:915
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x1fe/0x290 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x29d/0xb10 fs/ocfs2/quota_global.c:816
dqget+0x72b/0xc30 fs/quota/dquot.c:1010
__dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1539
ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
ocfs2_mknod+0x8ab/0x2510 fs/ocfs2/namei.c:310
ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3470 [inline]
open_last_lookups fs/namei.c:3540 [inline]
path_openat+0x11db/0x2fa0 fs/namei.c:3747
do_filp_open+0x1e2/0x410 fs/namei.c:3777
do_sys_openat2+0x150/0x4b0 fs/open.c:1255
do_sys_open fs/open.c:1271 [inline]
__do_sys_open fs/open.c:1279 [inline]
__se_sys_open fs/open.c:1275 [inline]
__x64_sys_open+0x11b/0x140 fs/open.c:1275
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
&ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8);
lock(&dquot->dq_lock);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8);
lock(&ocfs2_quota_ip_alloc_sem_key);

*** DEADLOCK ***

5 locks held by syz.5.3596/19321:
#0: ffff88807bc7c460 (sb_writers#27){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
#1: ffff88805f86df48 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
#1: ffff88805f86df48 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3537 [inline]
#1: ffff88805f86df48 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: path_openat+0x803/0x2fa0 fs/namei.c:3747
#2: ffff8880414909c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
#2: ffff8880414909c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x44d0 fs/ocfs2/suballoc.c:782
#3: ffff88804cb440a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28b/0xb10 fs/ocfs2/quota_global.c:811
#4: ffff88807258c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
#4: ffff88807258c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1d7/0x290 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 0 PID: 19321 Comm: syz.5.3596 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
<TASK>
dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x1fe/0x290 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x29d/0xb10 fs/ocfs2/quota_global.c:816
dqget+0x72b/0xc30 fs/quota/dquot.c:1010
__dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1539
ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
ocfs2_mknod+0x8ab/0x2510 fs/ocfs2/namei.c:310
ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3470 [inline]
open_last_lookups fs/namei.c:3540 [inline]
path_openat+0x11db/0x2fa0 fs/namei.c:3747
do_filp_open+0x1e2/0x410 fs/namei.c:3777
do_sys_openat2+0x150/0x4b0 fs/open.c:1255
do_sys_open fs/open.c:1271 [inline]
__do_sys_open fs/open.c:1279 [inline]
__se_sys_open fs/open.c:1275 [inline]
__x64_sys_open+0x11b/0x140 fs/open.c:1275
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7efccfe39e59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007efcce093028 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007efcd00b2fa0 RCX: 00007efccfe39e59
RDX: 0000000000000000 RSI: 0000000000145142 RDI: 0000200000000240
RBP: 00007efccfecfd6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007efcd00b3038 R14: 00007efcd00b2fa0 R15: 00007ffda8440398
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages