[v6.6] possible deadlock in ntfs_look_for_free_space

0 views
Skip to first unread message

syzbot

unread,
Jun 30, 2025, 2:00:43 PM6/30/25
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 3f5b4c104b7d Linux 6.6.95
git tree: linux-6.6.y
console output: https://syzkaller.appspot.com/x/log.txt?x=134c1982580000
kernel config: https://syzkaller.appspot.com/x/.config?x=b80883c3ded77c16
dashboard link: https://syzkaller.appspot.com/bug?extid=9eec4661d23cadccd5b6
compiler: Debian clang version 20.1.6 (++20250514063057+1e4d39e07757-1~exp1~20250514183223.118), Debian LLD 20.1.6

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/0efd4e01816e/disk-3f5b4c10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f7c9d20858cc/vmlinux-3f5b4c10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/18f8dc74ef68/bzImage-3f5b4c10.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9eec46...@syzkaller.appspotmail.com

ntfs3: loop6: ino=3, ntfs_set_state failed, -22.
ntfs3: loop6: Failed to initialize $Extend/$Reparse.
======================================================
WARNING: possible circular locking dependency detected
6.6.95-syzkaller #0 Not tainted
------------------------------------------------------
syz.6.7595/748 is trying to acquire lock:
ffff88805f654270 (&wnd->rw_lock){++++}-{3:3}, at: ntfs_look_for_free_space+0xd4/0x600 fs/ntfs3/fsntfs.c:362

but task is already holding lock:
ffff8880609ada30 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x13e/0x450 fs/ntfs3/fsntfs.c:511

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ni->file.run_lock#2){++++}-{3:3}:
down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
run_unpack_ex+0x7e6/0xba0 fs/ntfs3/run.c:1117
ntfs_read_mft fs/ntfs3/inode.c:401 [inline]
ntfs_iget5+0x22e3/0x3750 fs/ntfs3/inode.c:533
dir_search_u+0x1e0/0x2b0 fs/ntfs3/dir.c:264
ntfs_atomic_open+0x23b/0x520 fs/ntfs3/namei.c:412
atomic_open fs/namei.c:3351 [inline]
lookup_open fs/namei.c:3459 [inline]
open_last_lookups fs/namei.c:3556 [inline]
path_openat+0xf27/0x3190 fs/namei.c:3786
do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
do_sys_open fs/open.c:1434 [inline]
__do_sys_openat fs/open.c:1450 [inline]
__se_sys_openat fs/open.c:1445 [inline]
__x64_sys_openat+0x139/0x160 fs/open.c:1445
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&wnd->rw_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
down_write_nested+0x9e/0x1f0 kernel/locking/rwsem.c:1689
ntfs_look_for_free_space+0xd4/0x600 fs/ntfs3/fsntfs.c:362
attr_allocate_clusters+0x1c2/0x6d0 fs/ntfs3/attrib.c:159
attr_set_size+0x14a0/0x2c60 fs/ntfs3/attrib.c:575
ntfs_extend_mft+0x163/0x450 fs/ntfs3/fsntfs.c:512
ntfs_look_free_mft+0x5f6/0xd40 fs/ntfs3/fsntfs.c:709
ntfs_create_inode+0x524/0x3680 fs/ntfs3/inode.c:1338
ntfs_symlink+0xda/0x120 fs/ntfs3/namei.c:208
vfs_symlink+0x138/0x2b0 fs/namei.c:4473
do_symlinkat+0x1b2/0x3f0 fs/namei.c:4499
__do_sys_symlink fs/namei.c:4520 [inline]
__se_sys_symlink fs/namei.c:4518 [inline]
__x64_sys_symlink+0x7e/0x90 fs/namei.c:4518
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ni->file.run_lock#2);
lock(&wnd->rw_lock);
lock(&ni->file.run_lock#2);
lock(&wnd->rw_lock);

*** DEADLOCK ***

5 locks held by syz.6.7595/748:
#0: ffff88805f656418 (sb_writers#16){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:403
#1: ffff88807825e390 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:839 [inline]
#1: ffff88807825e390 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: filename_create+0x1f6/0x460 fs/namei.c:3882
#2: ffff88807825e0e0 (&ni->ni_lock/6){+.+.}-{3:3}, at: ni_lock_dir fs/ntfs3/ntfs_fs.h:1125 [inline]
#2: ffff88807825e0e0 (&ni->ni_lock/6){+.+.}-{3:3}, at: ntfs_create_inode+0x171/0x3680 fs/ntfs3/inode.c:1252
#3: ffff88805f654128 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_look_free_mft+0x164/0xd40 fs/ntfs3/fsntfs.c:571
#4: ffff8880609ada30 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x13e/0x450 fs/ntfs3/fsntfs.c:511

stack backtrace:
CPU: 0 PID: 748 Comm: syz.6.7595 Not tainted 6.6.95-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
<TASK>
dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
down_write_nested+0x9e/0x1f0 kernel/locking/rwsem.c:1689
ntfs_look_for_free_space+0xd4/0x600 fs/ntfs3/fsntfs.c:362
attr_allocate_clusters+0x1c2/0x6d0 fs/ntfs3/attrib.c:159
attr_set_size+0x14a0/0x2c60 fs/ntfs3/attrib.c:575
ntfs_extend_mft+0x163/0x450 fs/ntfs3/fsntfs.c:512
ntfs_look_free_mft+0x5f6/0xd40 fs/ntfs3/fsntfs.c:709
ntfs_create_inode+0x524/0x3680 fs/ntfs3/inode.c:1338
ntfs_symlink+0xda/0x120 fs/ntfs3/namei.c:208
vfs_symlink+0x138/0x2b0 fs/namei.c:4473
do_symlinkat+0x1b2/0x3f0 fs/namei.c:4499
__do_sys_symlink fs/namei.c:4520 [inline]
__se_sys_symlink fs/namei.c:4518 [inline]
__x64_sys_symlink+0x7e/0x90 fs/namei.c:4518
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f657f58e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f658033d038 EFLAGS: 00000246 ORIG_RAX: 0000000000000058
RAX: ffffffffffffffda RBX: 00007f657f7b5fa0 RCX: 00007f657f58e929
RDX: 0000000000000000 RSI: 0000200000000800 RDI: 0000200000000540
RBP: 00007f657f610b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f657f7b5fa0 R15: 00007fffea63de88
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot

unread,
Jul 30, 2025, 8:17:49 AM7/30/25
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: dbcb8d8e4163 Linux 6.6.100
git tree: linux-6.6.y
console output: https://syzkaller.appspot.com/x/log.txt?x=172b34a2580000
kernel config: https://syzkaller.appspot.com/x/.config?x=293251cfa8d8100
dashboard link: https://syzkaller.appspot.com/bug?extid=9eec4661d23cadccd5b6
compiler: Debian clang version 20.1.7 (++20250616065708+6146a88f6049-1~exp1~20250616065826.132), Debian LLD 20.1.7
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=106a8834580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=133a89bc580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d0b56817a2c3/disk-dbcb8d8e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f0d646b2f7fa/vmlinux-dbcb8d8e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/1e0b752a5011/bzImage-dbcb8d8e.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/f710400879dd/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/51e8cc98e366/mount_2.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+9eec46...@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 4096
ntfs3: loop0: Different NTFS sector size (1024) and media sector size (512).
======================================================
WARNING: possible circular locking dependency detected
6.6.100-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.19/5968 is trying to acquire lock:
ffff8880307a4270 (&wnd->rw_lock){++++}-{3:3}, at: ntfs_look_for_free_space+0xd4/0x600 fs/ntfs3/fsntfs.c:362

but task is already holding lock:
ffff8880604d9f30 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x13e/0x450 fs/ntfs3/fsntfs.c:511

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ni->file.run_lock#2){++++}-{3:3}:
down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
run_unpack_ex+0x7e6/0xba0 fs/ntfs3/run.c:1117
ntfs_read_mft fs/ntfs3/inode.c:401 [inline]
ntfs_iget5+0x22e3/0x3750 fs/ntfs3/inode.c:533
dir_search_u+0x1e0/0x2b0 fs/ntfs3/dir.c:264
ntfs_lookup+0xfb/0x1f0 fs/ntfs3/namei.c:85
lookup_one_qstr_excl+0x112/0x250 fs/namei.c:1609
do_unlinkat+0x18c/0x570 fs/namei.c:4377
__do_sys_unlink fs/namei.c:4439 [inline]
__se_sys_unlink fs/namei.c:4437 [inline]
__x64_sys_unlink+0x49/0x50 fs/namei.c:4437
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&wnd->rw_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
down_write_nested+0x9e/0x1f0 kernel/locking/rwsem.c:1689
ntfs_look_for_free_space+0xd4/0x600 fs/ntfs3/fsntfs.c:362
attr_allocate_clusters+0x1c2/0x6d0 fs/ntfs3/attrib.c:159
attr_set_size+0x14a0/0x2c60 fs/ntfs3/attrib.c:575
ntfs_extend_mft+0x163/0x450 fs/ntfs3/fsntfs.c:512
ntfs_look_free_mft+0x5f6/0xd40 fs/ntfs3/fsntfs.c:709
ntfs_create_inode+0x524/0x3680 fs/ntfs3/inode.c:1338
ntfs_atomic_open+0x3f4/0x520 fs/ntfs3/namei.c:434
atomic_open fs/namei.c:3351 [inline]
lookup_open fs/namei.c:3459 [inline]
open_last_lookups fs/namei.c:3556 [inline]
path_openat+0xf27/0x3190 fs/namei.c:3786
do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
do_sys_open fs/open.c:1434 [inline]
__do_sys_open fs/open.c:1442 [inline]
__se_sys_open fs/open.c:1438 [inline]
__x64_sys_open+0x11f/0x140 fs/open.c:1438
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ni->file.run_lock#2);
lock(&wnd->rw_lock);
lock(&ni->file.run_lock#2);
lock(&wnd->rw_lock);

*** DEADLOCK ***

5 locks held by syz.0.19/5968:
#0: ffff8880303f2418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:403
#1: ffff888076e19270 (&type->i_mutex_dir_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
#1: ffff888076e19270 (&type->i_mutex_dir_key#8){++++}-{3:3}, at: open_last_lookups fs/namei.c:3553 [inline]
#1: ffff888076e19270 (&type->i_mutex_dir_key#8){++++}-{3:3}, at: path_openat+0x7c6/0x3190 fs/namei.c:3786
#2: ffff888076e18fc0 (&ni->ni_lock#2/6){+.+.}-{3:3}, at: ni_lock_dir fs/ntfs3/ntfs_fs.h:1125 [inline]
#2: ffff888076e18fc0 (&ni->ni_lock#2/6){+.+.}-{3:3}, at: ntfs_atomic_open+0x1ec/0x520 fs/ntfs3/namei.c:404
#3: ffff8880307a4128 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_look_free_mft+0x164/0xd40 fs/ntfs3/fsntfs.c:571
#4: ffff8880604d9f30 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x13e/0x450 fs/ntfs3/fsntfs.c:511

stack backtrace:
CPU: 0 PID: 5968 Comm: syz.0.19 Not tainted 6.6.100-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
<TASK>
dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
down_write_nested+0x9e/0x1f0 kernel/locking/rwsem.c:1689
ntfs_look_for_free_space+0xd4/0x600 fs/ntfs3/fsntfs.c:362
attr_allocate_clusters+0x1c2/0x6d0 fs/ntfs3/attrib.c:159
attr_set_size+0x14a0/0x2c60 fs/ntfs3/attrib.c:575
ntfs_extend_mft+0x163/0x450 fs/ntfs3/fsntfs.c:512
ntfs_look_free_mft+0x5f6/0xd40 fs/ntfs3/fsntfs.c:709
ntfs_create_inode+0x524/0x3680 fs/ntfs3/inode.c:1338
ntfs_atomic_open+0x3f4/0x520 fs/ntfs3/namei.c:434
atomic_open fs/namei.c:3351 [inline]
lookup_open fs/namei.c:3459 [inline]
open_last_lookups fs/namei.c:3556 [inline]
path_openat+0xf27/0x3190 fs/namei.c:3786
do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
do_sys_open fs/open.c:1434 [inline]
__do_sys_open fs/open.c:1442 [inline]
__se_sys_open fs/open.c:1438 [inline]
__x64_sys_open+0x11f/0x140 fs/open.c:1438
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f8a9a58e9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffef00d0948 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007f8a9a7b5fa0 RCX: 00007f8a9a58e9a9
RDX: 0000000000000000 RSI: 000000000014d27c RDI: 0000200000000180
RBP: 00007f8a9a610d69 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f8a9a7b5fa0 R14: 00007f8a9a7b5fa0 R15: 0000000000000003
</TASK>
ntfs3: loop0: ino=0, attr_set_size


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
Reply all
Reply to author
Forward
0 new messages