[v6.6] possible deadlock in hfs_extend_file

2 views
Skip to first unread message

syzbot

unread,
Jun 17, 2025, 9:12:28 AM6/17/25
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: c2603c511feb Linux 6.6.93
git tree: linux-6.6.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17c4c370580000
kernel config: https://syzkaller.appspot.com/x/.config?x=486bade17c8c30b9
dashboard link: https://syzkaller.appspot.com/bug?extid=c50f306994c052787c32
compiler: Debian clang version 20.1.6 (++20250514063057+1e4d39e07757-1~exp1~20250514183223.118), Debian LLD 20.1.6

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/8754f950a6e7/disk-c2603c51.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/3b19332dbf63/vmlinux-c2603c51.xz
kernel image: https://storage.googleapis.com/syzbot-assets/cb245e836038/bzImage-c2603c51.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c50f30...@syzkaller.appspotmail.com

loop1: detected capacity change from 0 to 64
======================================================
WARNING: possible circular locking dependency detected
6.6.93-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.134/6251 is trying to acquire lock:
ffff888077dd3b78 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397

but task is already holding lock:
ffff88802ee280b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x15f/0x1d0 fs/hfs/bfind.c:-1

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock#2/1){+.+.}-{3:3}:
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
hfs_find_init+0x15f/0x1d0 fs/hfs/bfind.c:-1
hfs_ext_read_extent fs/hfs/extent.c:200 [inline]
hfs_extend_file+0x2ef/0x1220 fs/hfs/extent.c:401
hfs_bmap_reserve+0x107/0x430 fs/hfs/btree.c:234
hfs_cat_create+0x1b4/0x620 fs/hfs/catalog.c:104
hfs_create+0x66/0xd0 fs/hfs/dir.c:202
lookup_open fs/namei.c:3488 [inline]
open_last_lookups fs/namei.c:3556 [inline]
path_openat+0x1277/0x3190 fs/namei.c:3786
do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
do_sys_open fs/open.c:1434 [inline]
__do_sys_openat fs/open.c:1450 [inline]
__se_sys_openat fs/open.c:1445 [inline]
__x64_sys_openat+0x139/0x160 fs/open.c:1445
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397
hfs_bmap_reserve+0x107/0x430 fs/hfs/btree.c:234
__hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
__hfs_ext_cache_extent+0x6b/0x9b0 fs/hfs/extent.c:174
hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
hfs_extend_file+0x317/0x1220 fs/hfs/extent.c:401
hfs_get_block+0x3d8/0xbd0 fs/hfs/extent.c:353
__block_write_begin_int+0x566/0x1ad0 fs/buffer.c:2124
__block_write_begin fs/buffer.c:2173 [inline]
block_write_begin+0x9a/0x1e0 fs/buffer.c:2234
cont_write_begin+0x5c8/0x7e0 fs/buffer.c:2591
hfs_write_begin+0x8b/0xd0 fs/hfs/inode.c:58
generic_perform_write+0x2fb/0x5b0 mm/filemap.c:4016
generic_file_write_iter+0xaf/0x2e0 mm/filemap.c:4137
call_write_iter include/linux/fs.h:2018 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x43b/0x940 fs/read_write.c:584
ksys_write+0x147/0x250 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&tree->tree_lock#2/1);
lock(&HFS_I(tree->inode)->extents_lock);
lock(&tree->tree_lock#2/1);
lock(&HFS_I(tree->inode)->extents_lock);

*** DEADLOCK ***

5 locks held by syz.1.134/6251:
#0: ffff88807d101748 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2a3/0x330 fs/file.c:1042
#1: ffff88802c4a0418 (sb_writers#18){.+.+}-{0:0}, at: vfs_write+0x20e/0x940 fs/read_write.c:580
#2: ffff888077dd50b8 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
#2: ffff888077dd50b8 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: generic_file_write_iter+0x83/0x2e0 mm/filemap.c:4134
#3: ffff888077dd4ef8 (&HFS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397
#4: ffff88802ee280b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x15f/0x1d0 fs/hfs/bfind.c:-1

stack backtrace:
CPU: 1 PID: 6251 Comm: syz.1.134 Not tainted 6.6.93-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
<TASK>
dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397
hfs_bmap_reserve+0x107/0x430 fs/hfs/btree.c:234
__hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
__hfs_ext_cache_extent+0x6b/0x9b0 fs/hfs/extent.c:174
hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
hfs_extend_file+0x317/0x1220 fs/hfs/extent.c:401
hfs_get_block+0x3d8/0xbd0 fs/hfs/extent.c:353
__block_write_begin_int+0x566/0x1ad0 fs/buffer.c:2124
__block_write_begin fs/buffer.c:2173 [inline]
block_write_begin+0x9a/0x1e0 fs/buffer.c:2234
cont_write_begin+0x5c8/0x7e0 fs/buffer.c:2591
hfs_write_begin+0x8b/0xd0 fs/hfs/inode.c:58
generic_perform_write+0x2fb/0x5b0 mm/filemap.c:4016
generic_file_write_iter+0xaf/0x2e0 mm/filemap.c:4137
call_write_iter include/linux/fs.h:2018 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x43b/0x940 fs/read_write.c:584
ksys_write+0x147/0x250 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fe253f8e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe254d5c038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fe2541b5fa0 RCX: 00007fe253f8e929
RDX: 0000000000001006 RSI: 00002000000029c0 RDI: 0000000000000004
RBP: 00007fe254010b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fe2541b5fa0 R15: 00007ffcec9cca18
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot

unread,
Jul 9, 2025, 3:39:31 AM7/9/25
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: a5df3a702b2c Linux 6.6.96
git tree: linux-6.6.y
console output: https://syzkaller.appspot.com/x/log.txt?x=142d7f70580000
kernel config: https://syzkaller.appspot.com/x/.config?x=2632deddafa957e8
dashboard link: https://syzkaller.appspot.com/bug?extid=c50f306994c052787c32
compiler: Debian clang version 20.1.7 (++20250616065708+6146a88f6049-1~exp1~20250616065826.132), Debian LLD 20.1.7
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=122d7f70580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=162d7f70580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9ba5b19f9f4d/disk-a5df3a70.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2cd779015729/vmlinux-a5df3a70.xz
kernel image: https://storage.googleapis.com/syzbot-assets/b56fc39e5cb8/bzImage-a5df3a70.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/dc7e0cbd15d7/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/b9c9752817a1/mount_2.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c50f30...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
6.6.96-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.63/6060 is trying to acquire lock:
ffff888079014ef8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397

but task is already holding lock:
ffff88807b9b60b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x15f/0x1d0 fs/hfs/bfind.c:-1

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock/1){+.+.}-{3:3}:
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
hfs_find_init+0x15f/0x1d0 fs/hfs/bfind.c:-1
hfs_ext_read_extent fs/hfs/extent.c:200 [inline]
hfs_extend_file+0x2ef/0x1220 fs/hfs/extent.c:401
hfs_bmap_reserve+0x107/0x430 fs/hfs/btree.c:234
hfs_cat_move+0x18d/0x930 fs/hfs/catalog.c:310
hfs_rename+0x1dc/0x2c0 fs/hfs/dir.c:299
vfs_rename+0xb96/0xec0 fs/namei.c:4872
do_renameat2+0x8a1/0xc70 fs/namei.c:5025
__do_sys_rename fs/namei.c:5071 [inline]
__se_sys_rename fs/namei.c:5069 [inline]
__x64_sys_rename+0x86/0x90 fs/namei.c:5069
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397
hfs_bmap_reserve+0x107/0x430 fs/hfs/btree.c:234
__hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
__hfs_ext_cache_extent+0x6b/0x9b0 fs/hfs/extent.c:174
hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
hfs_extend_file+0x317/0x1220 fs/hfs/extent.c:401
hfs_get_block+0x3d8/0xbd0 fs/hfs/extent.c:353
__block_write_begin_int+0x566/0x1ad0 fs/buffer.c:2124
__block_write_begin fs/buffer.c:2173 [inline]
block_write_begin+0x9a/0x1e0 fs/buffer.c:2234
cont_write_begin+0x5c8/0x7e0 fs/buffer.c:2591
hfs_write_begin+0x8b/0xd0 fs/hfs/inode.c:58
cont_expand_zero fs/buffer.c:2518 [inline]
cont_write_begin+0x2ad/0x7e0 fs/buffer.c:2581
hfs_write_begin+0x8b/0xd0 fs/hfs/inode.c:58
hfs_file_truncate+0x191/0x9b0 fs/hfs/extent.c:494
hfs_inode_setattr+0x4af/0x6e0 fs/hfs/inode.c:659
notify_change+0xb0d/0xe10 fs/attr.c:499
do_truncate+0x19b/0x220 fs/open.c:66
vfs_truncate+0x266/0x300 fs/open.c:112
do_sys_truncate+0xe0/0x1a0 fs/open.c:135
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&tree->tree_lock/1);
lock(&HFS_I(tree->inode)->extents_lock);
lock(&tree->tree_lock/1);
lock(&HFS_I(tree->inode)->extents_lock);

*** DEADLOCK ***

4 locks held by syz.2.63/6060:
#0: ffff88805ee82418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:403
#1: ffff8880790136b8 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
#1: ffff8880790136b8 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: do_truncate+0x187/0x220 fs/open.c:64
#2: ffff8880790134f8 (&HFS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397
#3: ffff88807b9b60b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x15f/0x1d0 fs/hfs/bfind.c:-1

stack backtrace:
CPU: 1 PID: 6060 Comm: syz.2.63 Not tainted 6.6.96-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
<TASK>
dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain kernel/locking/lockdep.c:3869 [inline]
__lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x129/0xcc0 kernel/locking/mutex.c:747
hfs_extend_file+0xdb/0x1220 fs/hfs/extent.c:397
hfs_bmap_reserve+0x107/0x430 fs/hfs/btree.c:234
__hfs_ext_write_extent+0x1fa/0x470 fs/hfs/extent.c:121
__hfs_ext_cache_extent+0x6b/0x9b0 fs/hfs/extent.c:174
hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
hfs_extend_file+0x317/0x1220 fs/hfs/extent.c:401
hfs_get_block+0x3d8/0xbd0 fs/hfs/extent.c:353
__block_write_begin_int+0x566/0x1ad0 fs/buffer.c:2124
__block_write_begin fs/buffer.c:2173 [inline]
block_write_begin+0x9a/0x1e0 fs/buffer.c:2234
cont_write_begin+0x5c8/0x7e0 fs/buffer.c:2591
hfs_write_begin+0x8b/0xd0 fs/hfs/inode.c:58
cont_expand_zero fs/buffer.c:2518 [inline]
cont_write_begin+0x2ad/0x7e0 fs/buffer.c:2581
hfs_write_begin+0x8b/0xd0 fs/hfs/inode.c:58
hfs_file_truncate+0x191/0x9b0 fs/hfs/extent.c:494
hfs_inode_setattr+0x4af/0x6e0 fs/hfs/inode.c:659
notify_change+0xb0d/0xe10 fs/attr.c:499
do_truncate+0x19b/0x220 fs/open.c:66
vfs_truncate+0x266/0x300 fs/open.c:112
do_sys_truncate+0xe0/0x1a0 fs/open.c:135
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f93bc78e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc789ffdb8 EFLAGS: 00000246 ORIG_RAX: 000000000000004c
RAX: ffffffffffffffda RBX: 00007f93bc9b5fa0 RCX: 00007f93bc78e929
RDX: 0000000000000000 RSI: 0000000008800000 RDI: 0000200000000040
RBP: 00007f93bc810b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f93bc9b5fa0 R14: 00007f93bc9b5fa0 R15: 0000000000000002
</TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
Reply all
Reply to author
Forward
0 new messages