[v6.1] KASAN: slab-out-of-bounds Read in hfsplus_bnode_read

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3a8358583626 Linux 6.1.129
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=141058b7980000
kernel config: https://syzkaller.appspot.com/x/.config?x=ff93ecc085d8436e
dashboard link: https://syzkaller.appspot.com/bug?extid=4c6680758f5b535c27ee
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/3cc3985223b7/disk-3a835858.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e40398fb298b/vmlinux-3a835858.xz
kernel image: https://storage.googleapis.com/syzbot-assets/40469708dc9a/Image-3a835858.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+4c6680...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: slab-out-of-bounds in hfsplus_bnode_read+0x9c/0x270 fs/hfsplus/bnode.c:32
Read of size 8 at addr ffff0000d1561ee0 by task syz.0.142/5025

CPU: 0 PID: 5025 Comm: syz.0.142 Not tainted 6.1.129-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
print_address_description mm/kasan/report.c:316 [inline]
print_report+0x174/0x4c0 mm/kasan/report.c:427
kasan_report+0xd4/0x130 mm/kasan/report.c:531
__asan_report_load8_noabort+0x2c/0x38 mm/kasan/report_generic.c:351
hfsplus_bnode_read+0x9c/0x270 fs/hfsplus/bnode.c:32
hfsplus_bnode_dump+0x2ec/0x534
hfsplus_brec_remove+0x3d0/0x4a4 fs/hfsplus/brec.c:229
__hfsplus_delete_attr+0x1dc/0x3e4 fs/hfsplus/attributes.c:299
hfsplus_delete_attr+0x234/0x2c8 fs/hfsplus/attributes.c:345
__hfsplus_setxattr+0x3b8/0x1d3c fs/hfsplus/xattr.c:342
hfsplus_setxattr+0xdc/0x12c fs/hfsplus/xattr.c:434
hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30
__vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
__vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216
__vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
vfs_setxattr+0x1a8/0x344 fs/xattr.c:309
do_setxattr fs/xattr.c:594 [inline]
setxattr+0x230/0x294 fs/xattr.c:617
path_setxattr+0x17c/0x258 fs/xattr.c:636
__do_sys_setxattr fs/xattr.c:652 [inline]
__se_sys_setxattr fs/xattr.c:648 [inline]
__arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:648
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Allocated by task 5025:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4c/0x80 mm/kasan/common.c:52
kasan_save_alloc_info+0x24/0x30 mm/kasan/generic.c:505
____kasan_kmalloc mm/kasan/common.c:374 [inline]
__kasan_kmalloc+0xac/0xc4 mm/kasan/common.c:383
kasan_kmalloc include/linux/kasan.h:211 [inline]
__do_kmalloc_node mm/slab_common.c:936 [inline]
__kmalloc+0xd8/0x1c4 mm/slab_common.c:949
kmalloc include/linux/slab.h:568 [inline]
kzalloc include/linux/slab.h:699 [inline]
__hfs_bnode_create+0xe4/0x6d4 fs/hfsplus/bnode.c:409
hfsplus_bnode_find+0x1f8/0xc60 fs/hfsplus/bnode.c:486
hfsplus_brec_find+0x134/0x4a0 fs/hfsplus/bfind.c:172
hfsplus_find_attr+0x13c/0x1e0
hfsplus_attr_exists+0x154/0x1c8 fs/hfsplus/attributes.c:182
__hfsplus_setxattr+0x384/0x1d3c fs/hfsplus/xattr.c:336
hfsplus_setxattr+0xdc/0x12c fs/hfsplus/xattr.c:434
hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30
__vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
__vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216
__vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
vfs_setxattr+0x1a8/0x344 fs/xattr.c:309
do_setxattr fs/xattr.c:594 [inline]
setxattr+0x230/0x294 fs/xattr.c:617
path_setxattr+0x17c/0x258 fs/xattr.c:636
__do_sys_setxattr fs/xattr.c:652 [inline]
__se_sys_setxattr fs/xattr.c:648 [inline]
__arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:648
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Last potentially related work creation:
kasan_save_stack+0x40/0x70 mm/kasan/common.c:45
__kasan_record_aux_stack+0xcc/0xe8 mm/kasan/generic.c:486
kasan_record_aux_stack_noalloc+0x14/0x20 mm/kasan/generic.c:496
insert_work+0x64/0x384 kernel/workqueue.c:1361
__queue_work+0xd48/0x136c kernel/workqueue.c:1520
queue_work_on+0xc0/0x16c kernel/workqueue.c:1548
queue_work include/linux/workqueue.h:512 [inline]
addr_event+0x30c/0x3f8 drivers/infiniband/core/roce_gid_mgmt.c:853
inetaddr_event+0x108/0x1b0 drivers/infiniband/core/roce_gid_mgmt.c:869
notifier_call_chain kernel/notifier.c:87 [inline]
blocking_notifier_call_chain+0xf0/0x198 kernel/notifier.c:382
__inet_insert_ifa+0x8b0/0xa90 net/ipv4/devinet.c:569
inet_rtm_newaddr+0xe78/0x1748 net/ipv4/devinet.c:971
rtnetlink_rcv_msg+0x734/0xd9c net/core/rtnetlink.c:6150
netlink_rcv_skb+0x20c/0x3b8 net/netlink/af_netlink.c:2493
rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:6168
netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline]
netlink_unicast+0x65c/0x898 net/netlink/af_netlink.c:1337
netlink_sendmsg+0x844/0xb28 net/netlink/af_netlink.c:1859
sock_sendmsg_nosec net/socket.c:718 [inline]
__sock_sendmsg net/socket.c:730 [inline]
__sys_sendto+0x3b8/0x508 net/socket.c:2153
__do_sys_sendto net/socket.c:2165 [inline]
__se_sys_sendto net/socket.c:2161 [inline]
__arm64_sys_sendto+0xd8/0xf8 net/socket.c:2161
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Second to last potentially related work creation:
kasan_save_stack+0x40/0x70 mm/kasan/common.c:45
__kasan_record_aux_stack+0xcc/0xe8 mm/kasan/generic.c:486
kasan_record_aux_stack_noalloc+0x14/0x20 mm/kasan/generic.c:496
insert_work+0x64/0x384 kernel/workqueue.c:1361
__queue_work+0xd48/0x136c kernel/workqueue.c:1520
queue_work_on+0xc0/0x16c kernel/workqueue.c:1548
queue_work include/linux/workqueue.h:512 [inline]
call_usermodehelper_exec+0x238/0x48c kernel/umh.c:437
kobject_uevent_env+0x654/0x874 lib/kobject_uevent.c:633
kobject_uevent+0x2c/0x3c lib/kobject_uevent.c:657
driver_register+0x29c/0x378 drivers/base/driver.c:254
usb_register_driver+0x1bc/0x3a0 drivers/usb/core/driver.c:1062
emi26_driver_init+0x28/0x34 drivers/usb/misc/emi26.c:249
do_one_initcall+0x260/0xacc init/main.c:1298
do_initcall_level+0x154/0x214 init/main.c:1371
do_initcalls+0x58/0xac init/main.c:1387
do_basic_setup+0x8c/0xa0 init/main.c:1406
kernel_init_freeable+0x3a4/0x528 init/main.c:1626
kernel_init+0x24/0x29c init/main.c:1514
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:864

The buggy address belongs to the object at ffff0000d1561e00
which belongs to the cache kmalloc-256 of size 256
The buggy address is located 224 bytes inside of
256-byte region [ffff0000d1561e00, ffff0000d1561f00)

The buggy address belongs to the physical page:
page:00000000f85015c4 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x111560
head:00000000f85015c4 order:1 compound_mapcount:0 compound_pincount:0
flags: 0x5ffc00000010200(slab|head|node=0|zone=2|lastcpupid=0x7ff)
raw: 05ffc00000010200 fffffc0003474000 dead000000000004 ffff0000c0002480
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff0000d1561d80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff0000d1561e00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff0000d1561e80: 00 00 00 fc fc fc fc fc fc fc fc fc fc fc fc fc
^
ffff0000d1561f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff0000d1561f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================
Unable to handle kernel paging request at virtual address ffff635000009f07
KASAN: maybe wild-memory-access in range [0xffff1a800004f838-0xffff1a800004f83f]
Mem abort info:
ESR = 0x0000000096000004
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
FSC = 0x04: level 0 translation fault
Data abort info:
ISV = 0, ISS = 0x00000004
CM = 0, WnR = 0
swapper pgtable: 4k pages, 48-bit VAs, pgdp=00000001ab074000
[ffff635000009f07] pgd=0000000000000000, p4d=0000000000000000
Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 5025 Comm: syz.0.142 Tainted: G B 6.1.129-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : bytes_is_nonzero mm/kasan/generic.c:85 [inline]
pc : memory_is_nonzero mm/kasan/generic.c:102 [inline]
pc : memory_is_poisoned_n mm/kasan/generic.c:128 [inline]
pc : memory_is_poisoned mm/kasan/generic.c:159 [inline]
pc : check_region_inline mm/kasan/generic.c:180 [inline]
pc : kasan_check_range+0x64/0x2a4 mm/kasan/generic.c:189
lr : memcpy+0x48/0x90 mm/kasan/shadow.c:65
sp : ffff800021736df0
x29: ffff800021736df0 x28: 0000000000000001 x27: 0000000040000000
x26: 1ffff00002a9d86b x25: 0000000000000fff x24: 0000000000001000
x23: 0000000000000001 x22: ffff800009084cf0 x21: ffff800021736f00
x20: ffff1a800004f83f x19: 0000000000000001 x18: 1fffe0003679cb76
x17: 0000000000000000 x16: ffff80001226f180 x15: 0000000000000000
x14: 00000000000000ff x13: ffff0000c6fe9bc0 x12: 0000000000000001
x11: 1fffe35000009f07 x10: 1fffe35000009f07 x9 : ffffffffffffffff
x8 : ffff635000009f07 x7 : 0000000000000001 x6 : 00000000000000ff
x5 : ffff800021736f22 x4 : ffff0000e163900c x3 : ffff800009084cf0
x2 : 0000000000000000 x1 : 0000000000000001 x0 : ffff1a800004f83f
Call trace:
bytes_is_nonzero mm/kasan/generic.c:84 [inline]
memory_is_nonzero mm/kasan/generic.c:102 [inline]
memory_is_poisoned_n mm/kasan/generic.c:128 [inline]
memory_is_poisoned mm/kasan/generic.c:159 [inline]
check_region_inline mm/kasan/generic.c:180 [inline]
kasan_check_range+0x64/0x2a4 mm/kasan/generic.c:189
memcpy+0x48/0x90 mm/kasan/shadow.c:65
memcpy_from_page include/linux/highmem.h:393 [inline]
hfsplus_bnode_read+0x134/0x270 fs/hfsplus/bnode.c:32
hfsplus_bnode_dump+0x2ec/0x534
hfsplus_brec_remove+0x3d0/0x4a4 fs/hfsplus/brec.c:229
__hfsplus_delete_attr+0x1dc/0x3e4 fs/hfsplus/attributes.c:299
hfsplus_delete_attr+0x234/0x2c8 fs/hfsplus/attributes.c:345
__hfsplus_setxattr+0x3b8/0x1d3c fs/hfsplus/xattr.c:342
hfsplus_setxattr+0xdc/0x12c fs/hfsplus/xattr.c:434
hfsplus_trusted_setxattr+0x54/0x6c fs/hfsplus/xattr_trusted.c:30
__vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
__vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216
__vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
vfs_setxattr+0x1a8/0x344 fs/xattr.c:309
do_setxattr fs/xattr.c:594 [inline]
setxattr+0x230/0x294 fs/xattr.c:617
path_setxattr+0x17c/0x258 fs/xattr.c:636
__do_sys_setxattr fs/xattr.c:652 [inline]
__se_sys_setxattr fs/xattr.c:648 [inline]
__arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:648
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
Code: 5400014c b4000b8c aa2a03e9 8b0b0129 (3940010a)
---[ end trace 0000000000000000 ]---
----------------
Code disassembly (best guess):
0: 5400014c b.gt 0x28
4: b4000b8c cbz x12, 0x174
8: aa2a03e9 mvn x9, x10
c: 8b0b0129 add x9, x9, x11
* 10: 3940010a ldrb w10, [x8] <-- trapping instruction


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 3a8358583626 Linux 6.1.129
git tree: linux-6.1.y

console output: https://syzkaller.appspot.com/x/log.txt?x=13266fb8580000

kernel config: https://syzkaller.appspot.com/x/.config?x=ff93ecc085d8436e
dashboard link: https://syzkaller.appspot.com/bug?extid=4c6680758f5b535c27ee
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=125fe464580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17266fb8580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/3cc3985223b7/disk-3a835858.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e40398fb298b/vmlinux-3a835858.xz
kernel image: https://storage.googleapis.com/syzbot-assets/40469708dc9a/Image-3a835858.gz.xz

mounted in repro: https://storage.googleapis.com/syzbot-assets/52562db1f3a2/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+4c6680...@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 1024
hfsplus: request for non-existent node 211 in B*Tree
hfsplus: request for non-existent node 211 in B*Tree

==================================================================
BUG: KASAN: slab-out-of-bounds in hfsplus_bnode_read+0x9c/0x270 fs/hfsplus/bnode.c:32

Read of size 8 at addr ffff0000c08644e0 by task syz-executor136/4290

CPU: 1 PID: 4290 Comm: syz-executor136 Not tainted 6.1.129-syzkaller #0

Allocated by task 4290:

The buggy address belongs to the object at ffff0000c0864400

which belongs to the cache kmalloc-256 of size 256
The buggy address is located 224 bytes inside of

256-byte region [ffff0000c0864400, ffff0000c0864500)

The buggy address belongs to the physical page:

page:000000001e034d97 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x100864
head:000000001e034d97 order:1 compound_mapcount:0 compound_pincount:0

flags: 0x5ffc00000010200(slab|head|node=0|zone=2|lastcpupid=0x7ff)

raw: 05ffc00000010200 fffffc0003021980 dead000000000003 ffff0000c0002480
raw: 0000000000000000 0000000080100010 00000001ffffffff 0000000000000000

page dumped because: kasan: bad access detected

Memory state around the buggy address:

ffff0000c0864380: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff0000c0864400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff0000c0864480: 00 00 00 fc fc fc fc fc fc fc fc fc fc fc fc fc
^
ffff0000c0864500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff0000c0864580: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================
Unable to handle kernel paging request at virtual address ffff75080000880f
KASAN: maybe wild-memory-access in range [0xffffa84000044078-0xffffa8400004407f]

Mem abort info:
ESR = 0x0000000096000004
EC = 0x25: DABT (current EL), IL = 32 bits
SET = 0, FnV = 0
EA = 0, S1PTW = 0
FSC = 0x04: level 0 translation fault
Data abort info:
ISV = 0, ISS = 0x00000004
CM = 0, WnR = 0
swapper pgtable: 4k pages, 48-bit VAs, pgdp=00000001ab074000

[ffff75080000880f] pgd=0000000000000000, p4d=0000000000000000

Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP
Modules linked in:

CPU: 1 PID: 4290 Comm: syz-executor136 Tainted: G B 6.1.129-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : bytes_is_nonzero mm/kasan/generic.c:85 [inline]
pc : memory_is_nonzero mm/kasan/generic.c:102 [inline]
pc : memory_is_poisoned_n mm/kasan/generic.c:128 [inline]
pc : memory_is_poisoned mm/kasan/generic.c:159 [inline]
pc : check_region_inline mm/kasan/generic.c:180 [inline]
pc : kasan_check_range+0x64/0x2a4 mm/kasan/generic.c:189
lr : memcpy+0x48/0x90 mm/kasan/shadow.c:65

sp : ffff800021096df0
x29: ffff800021096df0 x28: 0000000000000001 x27: 0000000040000000

x26: 1ffff00002a9d86b x25: 0000000000000fff x24: 0000000000001000

x23: 0000000000000001 x22: ffff800009084cf0 x21: ffff800021096f00
x20: ffffa8400004407f x19: 0000000000000001 x18: 1fffe0003679cb76

x17: 0000000000000000 x16: ffff80001226f180 x15: 0000000000000000

x14: 00000000000000ff x13: ffff0000dea7b780 x12: 0000000000000001
x11: 1ffff5080000880f x10: 1ffff5080000880f x9 : ffffffffffffffff
x8 : ffff75080000880f x7 : 0000000000000001 x6 : 00000000000000ff
x5 : ffff800021096f22 x4 : ffff0000e354c00c x3 : ffff800009084cf0
x2 : 0000000000000000 x1 : 0000000000000001 x0 : ffffa8400004407f

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.