Hello,
syzbot found the following issue on:
HEAD commit: 003148680b79 Linux 5.15.177
git tree: linux-5.15.y
console output:
https://syzkaller.appspot.com/x/log.txt?x=10aa25f8580000
kernel config:
https://syzkaller.appspot.com/x/.config?x=27ad1047990e0f7e
dashboard link:
https://syzkaller.appspot.com/bug?extid=0ef649bd6963b601e4aa
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image:
https://storage.googleapis.com/syzbot-assets/c8625d198744/disk-00314868.raw.xz
vmlinux:
https://storage.googleapis.com/syzbot-assets/94b56bdfa2ae/vmlinux-00314868.xz
kernel image:
https://storage.googleapis.com/syzbot-assets/640b14c1ba43/Image-00314868.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by:
syzbot+0ef649...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.177-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor/4030 is trying to acquire lock:
ffff0000cedaf138 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: flush_workqueue+0x120/0x11c4 kernel/workqueue.c:2830
but task is already holding lock:
ffff0000d29b40e0 (&type->s_umount_key#53){++++}-{3:3}, at: deactivate_super+0x100/0x128 fs/super.c:365
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&type->s_umount_key#53){++++}-{3:3}:
down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_finish_quota_recovery+0x18c/0x2014 fs/ocfs2/quota_local.c:600
ocfs2_complete_recovery+0x1444/0x22cc fs/ocfs2/journal.c:1295
process_one_work+0x790/0x11b8 kernel/workqueue.c:2310
worker_thread+0x910/0x1034 kernel/workqueue.c:2457
kthread+0x37c/0x45c kernel/kthread.c:334
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870
-> #1 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}:
process_one_work+0x6d4/0x11b8 kernel/workqueue.c:2286
worker_thread+0x910/0x1034 kernel/workqueue.c:2457
kthread+0x37c/0x45c kernel/kthread.c:334
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870
-> #0 ((wq_completion)ocfs2_wq){+.+.}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
flush_workqueue+0x14c/0x11c4 kernel/workqueue.c:2830
ocfs2_shutdown_local_alloc+0x104/0x8d8 fs/ocfs2/localalloc.c:379
ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882
ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610
generic_shutdown_super+0x130/0x2f0 fs/super.c:475
kill_block_super+0x70/0xdc fs/super.c:1427
deactivate_locked_super+0xb8/0x13c fs/super.c:335
deactivate_super+0x108/0x128 fs/super.c:366
cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143
__cleanup_mnt+0x20/0x30 fs/namespace.c:1150
task_work_run+0x130/0x1e4 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
(wq_completion)ocfs2_wq --> (work_completion)(&journal->j_recovery_work) --> &type->s_umount_key#53
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->s_umount_key#53);
lock((work_completion)(&journal->j_recovery_work));
lock(&type->s_umount_key#53);
lock((wq_completion)ocfs2_wq);
*** DEADLOCK ***
1 lock held by syz-executor/4030:
#0: ffff0000d29b40e0 (&type->s_umount_key#53){++++}-{3:3}, at: deactivate_super+0x100/0x128 fs/super.c:365
stack backtrace:
CPU: 1 PID: 4030 Comm: syz-executor Not tainted 5.15.177-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
flush_workqueue+0x14c/0x11c4 kernel/workqueue.c:2830
ocfs2_shutdown_local_alloc+0x104/0x8d8 fs/ocfs2/localalloc.c:379
ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882
ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610
generic_shutdown_super+0x130/0x2f0 fs/super.c:475
kill_block_super+0x70/0xdc fs/super.c:1427
deactivate_locked_super+0xb8/0x13c fs/super.c:335
deactivate_super+0x108/0x128 fs/super.c:366
cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143
__cleanup_mnt+0x20/0x30 fs/namespace.c:1150
task_work_run+0x130/0x1e4 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
ocfs2: Unmounting device (7,4) on (node local)
ocfs2: Unmounting device (7,4) on (node local)
---
This report is generated by a bot. It may contain errors.
See
https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at
syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup