Hello,
syzbot found the following issue on:
HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output:
https://syzkaller.appspot.com/x/log.txt?x=14a47fd0580000
kernel config:
https://syzkaller.appspot.com/x/.config?x=4d3fd5cca89ae935
dashboard link:
https://syzkaller.appspot.com/bug?extid=2603b448a5ecd6d26356
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image:
https://storage.googleapis.com/syzbot-assets/ef5025f3d708/disk-3a592870.raw.xz
vmlinux:
https://storage.googleapis.com/syzbot-assets/776fbdad3aa8/vmlinux-3a592870.xz
kernel image:
https://storage.googleapis.com/syzbot-assets/79541db5bd16/bzImage-3a592870.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by:
syzbot+2603b4...@syzkaller.appspotmail.com
loop4: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.4.1304/9377 is trying to acquire lock:
ffff88802356a988 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:458
but task is already holding lock:
ffff88802712c0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 fs/hfsplus/bfind.c:28
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&tree->tree_lock/1){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hfsplus_find_init+0x146/0x1c0 fs/hfsplus/bfind.c:28
hfsplus_ext_read_extent fs/hfsplus/extents.c:216 [inline]
hfsplus_get_block+0x5c0/0x14e0 fs/hfsplus/extents.c:268
block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290
do_read_cache_page+0x752/0x1040
read_mapping_page include/linux/pagemap.h:515 [inline]
__hfs_bnode_create+0x4f2/0xbb0 fs/hfsplus/bnode.c:447
hfsplus_bnode_create+0x120/0x460 fs/hfsplus/bnode.c:587
hfsplus_bmap_alloc+0x63c/0x720 fs/hfsplus/btree.c:414
hfs_btree_inc_height+0x11a/0xdb0 fs/hfsplus/brec.c:475
hfsplus_brec_insert+0x776/0xdd0 fs/hfsplus/brec.c:148
hfsplus_create_cat+0x498/0x1ba0 fs/hfsplus/catalog.c:292
hfsplus_fill_super+0x13e6/0x1c90 fs/hfsplus/super.c:560
mount_bdev+0x2c9/0x3f0 fs/super.c:1398
legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
vfs_get_tree+0x88/0x270 fs/super.c:1528
do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:458
hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357
__hfsplus_ext_write_extent+0x2a4/0x5b0 fs/hfsplus/extents.c:104
__hfsplus_ext_cache_extent+0x84/0xe00 fs/hfsplus/extents.c:186
hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline]
hfsplus_file_extend+0x435/0x1b10 fs/hfsplus/extents.c:462
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
__block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
__block_write_begin fs/buffer.c:2062 [inline]
block_write_begin fs/buffer.c:2122 [inline]
cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
__generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944
call_write_iter include/linux/fs.h:2172 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacd/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&tree->tree_lock/1);
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock/1);
lock(&HFSPLUS_I(inode)->extents_lock);
*** DEADLOCK ***
5 locks held by syz.4.1304/9377:
#0: ffff888024aecd70 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1084
#1: ffff8880724c2460 (sb_writers#14){.+.+}-{0:0}, at: vfs_write+0x29a/0xe50 fs/read_write.c:590
#2: ffff88802356c680 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#2: ffff88802356c680 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: generic_file_write_iter+0x7c/0x1b0 mm/filemap.c:3941
#3: ffff88802356c488 (&hip->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:458
#4: ffff88802712c0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 fs/hfsplus/bfind.c:28
stack backtrace:
CPU: 1 PID: 9377 Comm: syz.4.1304 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:458
hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357
__hfsplus_ext_write_extent+0x2a4/0x5b0 fs/hfsplus/extents.c:104
__hfsplus_ext_cache_extent+0x84/0xe00 fs/hfsplus/extents.c:186
hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline]
hfsplus_file_extend+0x435/0x1b10 fs/hfsplus/extents.c:462
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
__block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
__block_write_begin fs/buffer.c:2062 [inline]
block_write_begin fs/buffer.c:2122 [inline]
cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
__generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944
call_write_iter include/linux/fs.h:2172 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacd/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f73fe175ff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f73fc5ee038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f73fe32df80 RCX: 00007f73fe175ff9
RDX: 000000000208e24b RSI: 0000000020000240 RDI: 0000000000000004
RBP: 00007f73fe1e8296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f73fe32df80 R15: 00007fff41354788
</TASK>
---
This report is generated by a bot. It may contain errors.
See
https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at
syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup