[v6.1] possible deadlock in ocfs2_write_begin_nolock

3 views
Skip to first unread message

syzbot

unread,
Oct 11, 2024, 7:44:28 PM10/11/24
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: aa4cd140bba5 Linux 6.1.112
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1273b840580000
kernel config: https://syzkaller.appspot.com/x/.config?x=853183e9ecc0ae5a
dashboard link: https://syzkaller.appspot.com/bug?extid=13376da5d4f789911f90
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f386960d8754/disk-aa4cd140.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/a7eceea2ab69/vmlinux-aa4cd140.xz
kernel image: https://storage.googleapis.com/syzbot-assets/b07057222188/Image-aa4cd140.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+13376d...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
6.1.112-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.1085/7607 is trying to acquire lock:
ffff0000ca126650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
ffff0000ca126650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
ffff0000ca126650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0xa1c/0x3f6c fs/ocfs2/aops.c:1671

but task is already holding lock:
ffff0000f1ec0660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x178/0x38c fs/ocfs2/aops.c:1903

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
dqget+0x660/0xcec fs/quota/dquot.c:986
ocfs2_setattr+0xe34/0x1b3c fs/ocfs2/file.c:1240
notify_change+0xb58/0xe1c fs/attr.c:499
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
inode_lock include/linux/fs.h:758 [inline]
ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
dqget+0x660/0xcec fs/quota/dquot.c:986
ocfs2_setattr+0xe34/0x1b3c fs/ocfs2/file.c:1240
notify_change+0xb58/0xe1c fs/attr.c:499
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
__mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
dquot_commit+0x54/0x240 fs/quota/dquot.c:507
ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6776
ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6836
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
__dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1750
dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
dquot_alloc_space include/linux/quotaops.h:313 [inline]
dquot_alloc_block include/linux/quotaops.h:337 [inline]
ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5730
ext4_ext_map_blocks+0x15a8/0x6638 fs/ext4/extents.c:4318
ext4_map_blocks+0x810/0x1810 fs/ext4/inode.c:678
ext4_getblk+0x198/0x6ec fs/ext4/inode.c:889
ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:945
ext4_append+0x260/0x4cc fs/ext4/namei.c:83
ext4_init_new_dir+0x294/0x8e4 fs/ext4/namei.c:3028
ext4_mkdir+0x3d4/0xa64 fs/ext4/namei.c:3074
vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
do_mkdirat+0x220/0x510 fs/namei.c:4133
__do_sys_mkdirat fs/namei.c:4148 [inline]
__se_sys_mkdirat fs/namei.c:4146 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (&ei->i_data_sem){++++}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283
ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5598
notify_change+0xb58/0xe1c fs/attr.c:499
do_truncate+0x1c0/0x28c fs/open.c:65
do_sys_ftruncate+0x288/0x31c fs/open.c:193
__do_sys_ftruncate fs/open.c:204 [inline]
__se_sys_ftruncate fs/open.c:202 [inline]
__arm64_sys_ftruncate+0x60/0x74 fs/open.c:202
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (jbd2_handle){++++}-{0:0}:
start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463
jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354
ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879
ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609
generic_shutdown_super+0x130/0x328 fs/super.c:501
kill_block_super+0x70/0xdc fs/super.c:1470
deactivate_locked_super+0xac/0x124 fs/super.c:332
deactivate_super+0xf0/0x110 fs/super.c:363
cleanup_mnt+0x394/0x41c fs/namespace.c:1186
__cleanup_mnt+0x20/0x30 fs/namespace.c:1193
task_work_run+0x240/0x2f0 kernel/task_work.c:203
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
do_notify_resume+0x2148/0x3474 arch/arm64/kernel/signal.c:1132
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
down_read+0x64/0x308 kernel/locking/rwsem.c:1520
ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352
ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879
ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609
generic_shutdown_super+0x130/0x328 fs/super.c:501
kill_block_super+0x70/0xdc fs/super.c:1470
deactivate_locked_super+0xac/0x124 fs/super.c:332
deactivate_super+0xf0/0x110 fs/super.c:363
cleanup_mnt+0x394/0x41c fs/namespace.c:1186
__cleanup_mnt+0x20/0x30 fs/namespace.c:1193
task_work_run+0x240/0x2f0 kernel/task_work.c:203
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
do_notify_resume+0x2148/0x3474 arch/arm64/kernel/signal.c:1132
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (sb_internal#5){.+.+}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
ocfs2_write_begin_nolock+0xa1c/0x3f6c fs/ocfs2/aops.c:1671
ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1905
generic_perform_write+0x278/0x55c mm/filemap.c:3817
__generic_file_write_iter+0x168/0x388 mm/filemap.c:3945
ocfs2_file_write_iter+0x15ac/0x1fbc fs/ocfs2/file.c:2456
call_write_iter include/linux/fs.h:2265 [inline]
aio_write+0x588/0x824 fs/aio.c:1615
io_submit_one+0x824/0x15b8 fs/aio.c:2034
__do_sys_io_submit fs/aio.c:2093 [inline]
__se_sys_io_submit fs/aio.c:2063 [inline]
__arm64_sys_io_submit+0x248/0x3c8 fs/aio.c:2063
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
sb_internal#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(sb_internal#5);

*** DEADLOCK ***

2 locks held by syz.1.1085/7607:
#0: ffff0000f1ec09c8 (&sb->s_type->i_mutex_key#46){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#0: ffff0000f1ec09c8 (&sb->s_type->i_mutex_key#46){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x3b4/0x1fbc fs/ocfs2/file.c:2388
#1: ffff0000f1ec0660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x178/0x38c fs/ocfs2/aops.c:1903

stack backtrace:
CPU: 1 PID: 7607 Comm: syz.1.1085 Not tainted 6.1.112-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
ocfs2_write_begin_nolock+0xa1c/0x3f6c fs/ocfs2/aops.c:1671
ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1905
generic_perform_write+0x278/0x55c mm/filemap.c:3817
__generic_file_write_iter+0x168/0x388 mm/filemap.c:3945
ocfs2_file_write_iter+0x15ac/0x1fbc fs/ocfs2/file.c:2456
call_write_iter include/linux/fs.h:2265 [inline]
aio_write+0x588/0x824 fs/aio.c:1615
io_submit_one+0x824/0x15b8 fs/aio.c:2034
__do_sys_io_submit fs/aio.c:2093 [inline]
__se_sys_io_submit fs/aio.c:2063 [inline]
__arm64_sys_io_submit+0x248/0x3c8 fs/aio.c:2063
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot

unread,
Jan 4, 2026, 11:37:26 PMJan 4
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 50cbba13faa2 Linux 6.1.159
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1318f69a580000
kernel config: https://syzkaller.appspot.com/x/.config?x=31ea1cecaf34f0db
dashboard link: https://syzkaller.appspot.com/bug?extid=13376da5d4f789911f90
compiler: Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8
userspace arch: arm64
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=152fee22580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14decf92580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/7ad0bd66715a/disk-50cbba13.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/3284d626258e/vmlinux-50cbba13.xz
kernel image: https://storage.googleapis.com/syzbot-assets/a1f92ca7bbfc/Image-50cbba13.gz.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/272850f213c7/mount_0.gz
fsck result: OK (log: https://syzkaller.appspot.com/x/fsck.log?x=17f14074580000)

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+13376d...@syzkaller.appspotmail.com

jbd2_journal_bmap: journal block not found at offset 32 on loop0-75
JBD2: bad block at offset 32
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/4517 is trying to acquire lock:
ffff0000d44be650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
ffff0000d44be650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
ffff0000d44be650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x1784/0x3ab4 fs/ocfs2/aops.c:1670

but task is already holding lock:
ffff0000e99294a0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x190/0x30c fs/ocfs2/aops.c:1902

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){++++}-{3:3}:
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
ocfs2_try_remove_refcount_tree+0xb4/0x2d8 fs/ocfs2/refcounttree.c:932
ocfs2_xattr_set+0x45c/0xe98 fs/ocfs2/xattr.c:3673
ocfs2_set_acl+0x3ec/0x4a0 fs/ocfs2/acl.c:254
ocfs2_iop_set_acl+0x174/0x240 fs/ocfs2/acl.c:285
set_posix_acl fs/posix_acl.c:1160 [inline]
posix_acl_xattr_set+0x2f8/0x398 fs/posix_acl.c:1189
__vfs_removexattr+0x370/0x38c fs/xattr.c:479
__vfs_removexattr_locked+0x1d0/0x208 fs/xattr.c:514
vfs_removexattr+0x80/0x190 fs/xattr.c:536
removexattr fs/xattr.c:878 [inline]
__do_sys_fremovexattr fs/xattr.c:925 [inline]
__se_sys_fremovexattr fs/xattr.c:915 [inline]
__arm64_sys_fremovexattr+0x208/0x2c0 fs/xattr.c:915
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
down_read+0x64/0x304 kernel/locking/rwsem.c:1520
ocfs2_init_acl+0x258/0x5f0 fs/ocfs2/acl.c:365
ocfs2_mknod+0x1168/0x1f18 fs/ocfs2/namei.c:410
ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3490 [inline]
open_last_lookups fs/namei.c:3558 [inline]
path_openat+0x112c/0x2680 fs/namei.c:3788
do_filp_open+0x174/0x344 fs/namei.c:3818
do_sys_openat2+0x128/0x3d8 fs/open.c:1320
do_sys_open fs/open.c:1336 [inline]
__do_sys_openat fs/open.c:1352 [inline]
__se_sys_openat fs/open.c:1347 [inline]
__arm64_sys_openat+0x120/0x154 fs/open.c:1347
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (jbd2_handle){++++}-{0:0}:
start_this_handle+0xfe0/0x122c fs/jbd2/transaction.c:463
jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
ocfs2_start_trans+0x380/0x6c4 fs/ocfs2/journal.c:376
ocfs2_mknod+0xc7c/0x1f18 fs/ocfs2/namei.c:361
ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3490 [inline]
open_last_lookups fs/namei.c:3558 [inline]
path_openat+0x112c/0x2680 fs/namei.c:3788
do_filp_open+0x174/0x344 fs/namei.c:3818
do_sys_openat2+0x128/0x3d8 fs/open.c:1320
do_sys_open fs/open.c:1336 [inline]
__do_sys_openat fs/open.c:1352 [inline]
__se_sys_openat fs/open.c:1347 [inline]
__arm64_sys_openat+0x120/0x154 fs/open.c:1347
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
down_read+0x64/0x304 kernel/locking/rwsem.c:1520
ocfs2_start_trans+0x374/0x6c4 fs/ocfs2/journal.c:374
ocfs2_mknod+0xc7c/0x1f18 fs/ocfs2/namei.c:361
ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
lookup_open fs/namei.c:3490 [inline]
open_last_lookups fs/namei.c:3558 [inline]
path_openat+0x112c/0x2680 fs/namei.c:3788
do_filp_open+0x174/0x344 fs/namei.c:3818
do_sys_openat2+0x128/0x3d8 fs/open.c:1320
do_sys_open fs/open.c:1336 [inline]
__do_sys_openat fs/open.c:1352 [inline]
__se_sys_openat fs/open.c:1347 [inline]
__arm64_sys_openat+0x120/0x154 fs/open.c:1347
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (sb_internal#2){.+.+}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x20c/0x6c4 fs/ocfs2/journal.c:372
ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
ocfs2_write_begin_nolock+0x1784/0x3ab4 fs/ocfs2/aops.c:1670
ocfs2_write_begin+0x1b4/0x30c fs/ocfs2/aops.c:1904
generic_perform_write+0x230/0x4e4 mm/filemap.c:3862
__generic_file_write_iter+0x130/0x250 mm/filemap.c:3960
ocfs2_file_write_iter+0x1300/0x1bf4 fs/ocfs2/file.c:2469
call_write_iter include/linux/fs.h:2265 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x5ac/0x7c4 fs/read_write.c:584
ksys_write+0x120/0x210 fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&oi->ip_alloc_sem);
lock(&oi->ip_xattr_sem);
lock(&oi->ip_alloc_sem);
lock(sb_internal#2);

*** DEADLOCK ***

3 locks held by syz.0.17/4517:
#0: ffff0000d44be460 (sb_writers#12){.+.+}-{0:0}, at: vfs_write+0x23c/0x7c4 fs/read_write.c:580
#1: ffff0000e9929808 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#1: ffff0000e9929808 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x3a4/0x1bf4 fs/ocfs2/file.c:2399
#2: ffff0000e99294a0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x190/0x30c fs/ocfs2/aops.c:1902

stack backtrace:
CPU: 0 PID: 4517 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/03/2025
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack+0x30/0x40 lib/dump_stack.c:88
dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106
dump_stack+0x1c/0x5c lib/dump_stack.c:113
print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048
check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x20c/0x6c4 fs/ocfs2/journal.c:372
ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
ocfs2_write_begin_nolock+0x1784/0x3ab4 fs/ocfs2/aops.c:1670
ocfs2_write_begin+0x1b4/0x30c fs/ocfs2/aops.c:1904
generic_perform_write+0x230/0x4e4 mm/filemap.c:3862
__generic_file_write_iter+0x130/0x250 mm/filemap.c:3960
ocfs2_file_write_iter+0x1300/0x1bf4 fs/ocfs2/file.c:2469
call_write_iter include/linux/fs.h:2265 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x5ac/0x7c4 fs/read_write.c:584
ksys_write+0x120/0x210 fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
Reply all
Reply to author
Forward
0 new messages